[PATCH 0/1] MR10479: dsound: Make i signed in downsample.

[Anton Baskanov (＠baskanov)]

Otherwise, the output array index will be unsigned, which leads to a
crash on 64-bit systems.

Fixes: 97f3bffa60b173c43ceef6c96ed5d9a46fccef12
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59548

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10479

[PATCH 1/1] dsound: Make i signed in downsample.

[Anton Baskanov]

From: Anton Baskanov <[e-mail]>

Otherwise, the output array index will be unsigned, which leads to a
crash on 64-bit systems.

Fixes: 97f3bffa60b173c43ceef6c96ed5d9a46fccef12
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59548
---
 dlls/dsound/mixer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c
index 43a9a8c4f91..b4032f5a6f0 100644
--- a/dlls/dsound/mixer.c
+++ b/dlls/dsound/mixer.c
@@ -330,7 +330,7 @@ static void downsample(LONG64 freq_adjust_num, LONG64 freq_adjust_den, LONG64 fr
         float input_value0 = (1.0f - rem) * input_value;
         float input_value1 = rem * input_value;
 
-        UINT i;
+        int i;
         for (i = 0; i < fir_width; ++i)
             output[opos + i] += fir[idx + i] * input_value0 + fir[idx + fir_width + i] * input_value1;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10479

[PATCH 0/1] MR10479: dsound: Make i signed in downsample. - approved

[Matteo Bruni (＠Mystral)]

This merge request was approved by Matteo Bruni.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10479

[PATCH 0/1] MR10479: dsound: Make i signed in downsample. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10479