[PATCH 0/1] MR11118: winegstreamer: Update instead of overriding the latency settings in transform_src_query_latency().

[Conor McCarthy (＠cmccarthy)]

A valid GstQuery is passed to the function, so we should update the
values already set there.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11118

[PATCH 1/1] winegstreamer: Update instead of overriding the latency settings in transform_src_query_latency().

[Conor McCarthy]

From: Conor McCarthy <[e-mail]>

A valid GstQuery is passed to the function, so we should update the
values already set there.
---
 dlls/winegstreamer/wg_transform.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/wg_transform.c b/dlls/winegstreamer/wg_transform.c
index 1537a88d614..2b98f27df41 100644
--- a/dlls/winegstreamer/wg_transform.c
+++ b/dlls/winegstreamer/wg_transform.c
@@ -296,8 +296,13 @@ static GstFlowReturn transform_sink_chain_cb(GstPad *pad, GstObject *parent, Gst
 
 static gboolean transform_src_query_latency(struct wg_transform *transform, GstQuery *query)
 {
+    GstClockTime min, max;
+    gboolean live;
+
     GST_LOG("transform %p, %"GST_PTR_FORMAT, transform, query);
-    gst_query_set_latency(query, transform->attrs.low_latency, 0, 0);
+
+    gst_query_parse_latency(query, &live, &min, &max);
+    gst_query_set_latency(query, live | transform->attrs.low_latency, min, max);
     return true;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/11118

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c:
> static gboolean transform_src_query_latency(struct wg_transform *transform, GstQuery *query)
>  {
> +    GstClockTime min, max;
> +    gboolean live;
> +
>      GST_LOG("transform %p, %"GST_PTR_FORMAT, transform, query);
> -    gst_query_set_latency(query, transform->attrs.low_latency, 0, 0);
> +
> +    gst_query_parse_latency(query, &live, &min, &max);
> +    gst_query_set_latency(query, live | transform->attrs.low_latency, min, max);

```suggestion:-0+0
    gst_query_set_latency(query, live || transform->attrs.low_latency, min, max);
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11118#note_142769

[Rémi Bernon (＠rbernon)]

What does this fix exactly? How does it happen that the source is set to live latency?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11118#note_142770

[Conor McCarthy (＠cmccarthy)]

On Thu Jun 11 06:49:51 2026 +0000, Rémi Bernon wrote:
> What does this fix exactly? How does it happen that the source is set to
> live latency?
> I'm not aware of this fixing anything, or of any case where the source sets `live`. I came across this, and apparently `max` should default to UINT64_MAX, but setting 0 may not have any effect down the chain. It can be closed if you like.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11118#note_142924