[PATCH 0/1] MR1471: dwrite: Avoid memcpy source overflow in GetFontAxisValues.

[Rémi Bernon]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1471

[PATCH 1/1] dwrite: Avoid memcpy source overflow in GetFontAxisValues.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/dwrite/font.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c
index d2d2b7963f7..5e1fb1c8cbf 100644
--- a/dlls/dwrite/font.c
+++ b/dlls/dwrite/font.c
@@ -7039,7 +7039,7 @@ static HRESULT WINAPI fontfacereference1_GetFontAxisValues(IDWriteFontFaceRefere
     if (value_count < reference->axis_values_count)
         return E_NOT_SUFFICIENT_BUFFER;
 
-    memcpy(axis_values, reference->axis_values, value_count * sizeof(*axis_values));
+    memcpy(axis_values, reference->axis_values, reference->axis_values_count * sizeof(*axis_values));
 
     return S_OK;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1471

[PATCH 1/1] dwrite: Avoid memcpy source overflow in GetFontAxisValues.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126532

Your paranoid android.


=== debian11 (32 bit report) ===

d3d9:
stateblock: Timeout
visual: Timeout

d3dcompiler_43:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_46:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_47:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3drm:
d3drm: Timeout
vector: Timeout

d3dx10_34:
d3dx10: Timeout

d3dx10_35:
d3dx10: Timeout

d3dx10_36:
d3dx10: Timeout

Report validation errors:
d3dx10: Timeout

=== debian11 (build log) ===

WineRunWineTest.pl:error: The task timed out

[PATCH 0/1] MR1471: dwrite: Avoid memcpy source overflow in GetFontAxisValues. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1471