[PATCH v2 0/1] MR10408: mf: Add stub for MFCreateDeviceSource().

[eric pouech (＠epo)]

Signed-off-by: Eric Pouech <[e-mail]>

--
  v2: mf: Add stub for MFCreateDeviceSource().
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10408

[PATCH v2 1/1] mf: Add stub for MFCreateDeviceSource().

[Eric Pouech]

From: Eric Pouech <[e-mail]>

Signed-off-by: Eric Pouech <[e-mail]>
---
 dlls/mf/main.c    | 12 ++++++++++++
 dlls/mf/mf.spec   |  2 +-
 include/mfidl.idl |  1 +
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/dlls/mf/main.c b/dlls/mf/main.c
index 537db3174cf..3dfa551bfa5 100644
--- a/dlls/mf/main.c
+++ b/dlls/mf/main.c
@@ -772,6 +772,18 @@ HRESULT WINAPI MFEnumDeviceSources(IMFAttributes *attributes, IMFActivate ***sou
     return E_INVALIDARG;
 }
 
+/***********************************************************************
+ *      MFCreateDeviceSource (mf.@)
+ */
+HRESULT WINAPI MFCreateDeviceSource(IMFAttributes *attributes, IMFMediaSource **source)
+{
+    FIXME("%p %p: stub!\n", attributes, source);
+
+    if (!attributes || !source) return E_INVALIDARG;
+    *source = NULL;
+    return E_NOTIMPL;
+}
+
 struct simple_type_handler
 {
     IMFMediaTypeHandler IMFMediaTypeHandler_iface;
diff --git a/dlls/mf/mf.spec b/dlls/mf/mf.spec
index de607f1d322..2b5b088f2f5 100644
--- a/dlls/mf/mf.spec
+++ b/dlls/mf/mf.spec
@@ -30,7 +30,7 @@
 @ stub MFCreateByteCacheFile
 @ stub MFCreateCacheManager
 @ stub MFCreateCredentialCache
-@ stub MFCreateDeviceSource
+@ stdcall MFCreateDeviceSource(ptr ptr)
 @ stub MFCreateDeviceSourceActivate
 @ stub MFCreateDrmNetNDSchemePlugin
 @ stub MFCreateFileBlockMap
diff --git a/include/mfidl.idl b/include/mfidl.idl
index e7258f26ed6..e1f53963082 100644
--- a/include/mfidl.idl
+++ b/include/mfidl.idl
@@ -739,6 +739,7 @@ cpp_quote("HRESULT WINAPI MFCreateTrackedSample(IMFTrackedSample **sample);")
 cpp_quote("HRESULT WINAPI MFRequireProtectedEnvironment(IMFPresentationDescriptor *pd);")
 cpp_quote("HRESULT WINAPI MFTranscodeGetAudioOutputAvailableTypes(REFGUID subtype, DWORD flags,")
 cpp_quote("        IMFAttributes *config, IMFCollection **types);")
+cpp_quote("HRESULT WINAPI MFCreateDeviceSource(IMFAttributes *, IMFMediaSource **);")
 
 typedef enum _MFMEDIASOURCE_CHARACTERISTICS
 {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10408

[eric pouech (＠epo)]

On Mon Mar 23 08:10:00 2026 +0000, Nikolay Sivov wrote:
> Should we maybe set output to null, just in case?
> done in V2

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10408#note_133272

[eric pouech (＠epo)]

V2 pushed:

* zero out output pointer
* removed extraneous ws

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10408#note_133274

[PATCH v2 0/1] MR10408: mf: Add stub for MFCreateDeviceSource(). - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10408