Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
Nov. 13, 2023
8:56 a.m.
not supported
not sure what you mean by that? I can build it fine with mingw-w64-g++ and it runs.
cancellation does not work
this is not true. callback could still be called after MFCancelWorkItem returns success, the [documentation](https://learn.microsoft.com/en-us/windows/win32/api/mfapi/nf-mfapi-mfcancelw...) says as much. and the thing is, more than this "hit race" case, our current rtworkq implementation triggers a assert in threadpool that says exactly what i predicted (callback is running when you try to close it). and that's exactly the race I am trying to avoid here. what more proof do you want? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52135
865
Age (days ago)
865
Last active (days ago)
0 comments
1 participants
participants (1)
-
Yuxuan Shui (@yshui)