[PATCH 0/1] MR2983: winevulkan: Include function name in asserts.
It is really useful to see at a glance what function is segfaulting/crashing here when debugging games/apps. This code is generated, and when generating WineVulkan against different Vulkan spec versions, etc it may be misleading that the Line: referred to by the assert dialog does not match what is generated locally on a different machine for the same Wine version/commit. Signed-off-by: Joshua Ashton <joshua(a)froggi.es> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2983
From: Joshua Ashton <joshua(a)froggi.es> It is really useful to see at a glance what function is segfaulting/crashing here when debugging games/apps. This code is generated, and when generating WineVulkan against different Vulkan spec versions, etc it may be misleading that the Line: referred to by the assert dialog does not match what is generated locally on a different machine for the same Wine version/commit. Signed-off-by: Joshua Ashton <joshua(a)froggi.es> --- dlls/winevulkan/make_vulkan | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index e8b3bfa6471..d6e455a13ea 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -773,7 +773,7 @@ class VkFunction(object): body += " UNIX_CALL({0}, ¶ms);\n".format(self.name) else: body += " status = UNIX_CALL({0}, ¶ms);\n".format(self.name) - body += " assert(!status);\n" + body += " assert(!status && \"{0}\");\n".format(self.name) if self.type != "void": body += " return params.result;\n" -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2983
This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2983
participants (3)
-
Jacek Caban (＠jacek) -
Joshua Ashton
-
Joshua Ashton (＠joshua)