Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
March 12, 2026
9:38 a.m.
Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c:
DeleteFileA( long_path ); }
+static void test_getmodulefilename_string_termination(void) +{ + WCHAR dll_name[MAX_PATH]; + int dll_name_len, i; + + dll_name[0] = 0; + GetModuleFileNameW(NULL, dll_name, MAX_PATH); + dll_name_len = wcslen(dll_name); + ok(dll_name_len > 0, "can't get path for NULL module\n"); + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); + + memset(dll_name, 0x9, sizeof(dll_name));
It would be better to avoid using magic numbers and use `'\t'` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132028
14
Age (days ago)
14
Last active (days ago)
0 comments
1 participants
participants (1)
-
Akihiro Sagawa (@sgwaki)