Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination

[Akihiro Sagawa (＠sgwaki)]

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c:
> DeleteFileA( long_path );
>  }
>
> +static void test_getmodulefilename_string_termination(void)
> +{
> +    WCHAR dll_name[MAX_PATH];
> +    int dll_name_len, i;
> +
> +    dll_name[0] = 0;
> +    GetModuleFileNameW(NULL, dll_name, MAX_PATH);
> +    dll_name_len = wcslen(dll_name);
> +    ok(dll_name_len > 0, "can't get path for NULL module\n");
> +    ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n");

It's unclear what the actual value of `dll_name_len` is. See [[Writing good error messages|Wine-Developer's-Guide/Writing-Conformance-Tests#writing-good-error-messages]] for details.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132017