Re: [PATCH v5 0/5] MR6386: winewayland: Reduce window surface buffer queue recreations.
Thanks, LGTM! Note that with this MR we can sometimes get artifacts in GL applications such as:  However this is not a problem with the change itself, but rather this change is interacting with two existing deficiencies in the driver: 1. `wayland_window_surface_set_clip()` is not implemented, hence we get such artifacts in our committed window surface buffers. 2. OpenGL surfaces not presented opaquely hence we can actually see the artifacts in the window surface behind the GL subsurface. We might want to revisit using EGL_EXT_present_opaque now that https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28153 has been merged, although this would require a Mesa version check in the Wayland driver to use the feature safely. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6386#note_80510
participants (1)
-
Alexandros Frantzis (ļ¼ afrantzis)