[PATCH 0/1] MR8903: vccorlib: Fix out of bounds access in debug helper (Coverity).

[Nikolay Sivov (＠nsivov)]

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8903

[PATCH 1/1] vccorlib: Fix out of bounds access in debug helper (Coverity).

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/vccorlib140/vccorlib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/vccorlib140/vccorlib.c b/dlls/vccorlib140/vccorlib.c
index 784b574eec0..39877f407bb 100644
--- a/dlls/vccorlib140/vccorlib.c
+++ b/dlls/vccorlib140/vccorlib.c
@@ -441,8 +441,8 @@ static const char *debugstr_typecode(int typecode)
         [TYPECODE_RECT] = "Rect",
         [TYPECODE_GUID] = "Guid",
     };
-    if (typecode > ARRAY_SIZE(str) || !str[typecode]) return wine_dbg_sprintf("%d", typecode);
-    return wine_dbg_sprintf("%s", str[typecode]);
+    if (typecode < ARRAY_SIZE(str) && str[typecode]) return wine_dbg_sprintf("%s", str[typecode]);
+    return wine_dbg_sprintf("%d", typecode);
 }
 
 void *WINAPI CreateValue(int typecode, const void *val)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8903