Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
Nov. 13, 2025
11:07 a.m.
Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c:
+ full_pidl = ILCombine(This->pidl, This->apidl[0]); + if (!full_pidl) + { + ERR("Out of Memory\n"); + return; + } + + hr = IShellLinkW_SetIDList(shelllink, full_pidl); + ILFree(full_pidl); + if (FAILED(hr)) + { + ERR("SetIDList failed\n"); + return; + } + _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH); + length = wcslen(filename) + wcslen(shortcutW); This looks like a duplicate check. There is another one in the loop below.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121803
134
Age (days ago)
134
Last active (days ago)
0 comments
1 participants
participants (1)
-
Sven Baars (@sbaars)