[PATCH v2 0/1] MR9804: ntdll: Allow region allocation for some non growable heaps.
Thanks to Bernhard Übelacker for debugging this issue. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55176 --- We could alternatively do this based on a Windows version check, but it doesn't seem very convenient and it's probably even harmless to allow allocations here, it's just not what any Windows version after Windows 95 does. -- v2: ntdll: Allow region allocation for some non growable heaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/9804
From: Rémi Bernon <rbernon@codeweavers.com> Thanks to Bernhard Übelacker for debugging this issue. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55176 --- dlls/ntdll/heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/heap.c b/dlls/ntdll/heap.c index b40b2d2ace8..a5ec0f95205 100644 --- a/dlls/ntdll/heap.c +++ b/dlls/ntdll/heap.c @@ -975,7 +975,7 @@ static void *allocate_region( struct heap *heap, ULONG flags, SIZE_T *region_siz void *addr = NULL; NTSTATUS status; - if (heap && !(flags & HEAP_GROWABLE)) + if (heap && !(flags & HEAP_GROWABLE) && (NtCurrentTeb()->Peb->OSPlatformId != VER_PLATFORM_WIN32_WINDOWS)) { WARN( "Heap %p isn't growable, cannot allocate %#Ix bytes\n", heap, *region_size ); return NULL; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9804
v2: Use a version check instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9804#note_125921
participants (1)
-
Rémi Bernon