[PATCH 0/1] MR10304: ddraw: Fix caps tracing in IDirectDraw7::GetCaps().
From: Elizabeth Figura <zfigura@codeweavers.com> The output pointers don't necessarily point to a v7 caps structure, and we currently may trace invalid members, e.g. ddsCaps. --- dlls/ddraw/ddraw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 388671e2a4e..c4ce81234bc 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -1594,9 +1594,8 @@ static HRESULT WINAPI ddraw7_GetCaps(IDirectDraw7 *iface, DDCAPS *DriverCaps, DD if (TRACE_ON(ddraw)) { TRACE("Driver Caps :\n"); - DDRAW_dump_DDCAPS(DriverCaps); + DDRAW_dump_DDCAPS(&caps); } - } if(HELCaps) { @@ -1604,7 +1603,7 @@ static HRESULT WINAPI ddraw7_GetCaps(IDirectDraw7 *iface, DDCAPS *DriverCaps, DD if (TRACE_ON(ddraw)) { TRACE("HEL Caps :\n"); - DDRAW_dump_DDCAPS(HELCaps); + DDRAW_dump_DDCAPS(&caps); } } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/10304
participants (2)
-
Elizabeth Figura -
Elizabeth Figura (@zfigura)