Re: [PATCH v2 0/14] MR10349: opengl32: Implement wglGetProcAddress on the client side.
On Thu Mar 26 12:51:57 2026 +0000, Rémi Bernon wrote:
Well arguably we have years of testing showing that exposing these extensions do not break the applications *which are currently working*. It says nothing about applications that don't work or that weren't tested. I've recently fixed some compatibility issue caused by passing through host GL_RENDERER string as is, which broke an application in some cases, as it was expecting a shorter string than what we returned. Anyway, I don't mind too much adding support for registered extensions, although I think we should argue whether it does fix anything, rather than whether not exposing them breaks something, but I don't think we should be hardcoding extensions which aren't in the registry. There's no reason to list Mesa extensions more than other vendors, and we have a general policy in Wine not to add vendor or backend specific workaround unless proven necessary, ie: that it *is* native behavior and that doing it fixes some application. If ARM Windows uses Mesa for its OpenGL implementation, and if some application depends on a Mesa specific extension in such situation, we could *then* consider adding them in such case, but that actually would need to be done regardless of the host GL implementation because Wine on ARM isn't always going to run with Mesa. Note that this probably means that we would be better off with PE Zink in such case anyway, because otherwise we might end up being simply unable to implement the missing extension if the host cannot do it for us. Again, it's not about fixing anything. It is about not changing behavior that do not need to be changed in an MR that is already very invasive. We expose it today, and we have no evidence that it is harmful. And again, removing it on top of this MR is trivial and better for bisectability than doing it here.
Anyway, I think it is time to agree to disagree. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10349#note_133867
participants (1)
-
Jacek Caban (@jacek)