Re: [PATCH v3 0/1] MR5522: sppc: Add stub SLInstallLicense().

[Daniel Tang (＠danielzgtg)]

> Adding a stub that doesn't actually help anything is basically just extra noise, and more code in the tree. In cases where someone is actively working on a proper implementation, it also often gets in their way. It may not be a big deal, but it's not exactly like there are zero disadvantages either.

Do you think the Waterfall development model could actually work better than Agile, especially in open source?
> author has probably given up on collaborating with the Wine project

Yeah, it was frustrating. But the reason was unrelated, being my team switching to Notion from Office. I also missed the email notifications. I'm not enthusiastic anymore about championing my patches, knowing I can always maintain a local patchset or submit them to Proton
> circumvention

Please don't accuse me of illegal behavior. I intentionally wrote `Sleep` not `TerminateThread`, which makes it a gray area, not necessarily illegal. The `Sleep` simulates a very inefficient algorithm (that Linux doesn't finish scheduling before heat death) on a busy computer, and I can replace it with a Collatz Conjecture verifier if you want. It's Microsoft's design decision that Office is "run until licensing fails" not "run after licensing succeeds" (which they chose if they cared), and Microsoft's code to change the title proves it's intentional
> patch-set fixing `v8jsi.dll`

That's my !2378 but I heard someone's working on a proper fix
> a private key ... cannot legally redistribute

No company publishes their [private key](https://en.wikipedia.org/w/index.php?title=Private_key)s. If we don't redistribute, we can adopt Switch emulators' key self-dumping requirement, and still be somewhat safe from their lawsuit's argument because Wine isn't mainly used for piracy
> where the license data is stored

I speculate it's in the registry like other licensing data
> first time contributors don't miss them.

Most other first time contributors can't read. It's better to be prepared to accept but fix their code
> licenses are encrypted

I didn't investigate how they are stored or if ciphertext can be directly returned. I don't want to be forced to investigate. My patch took an hour or two, and I'd hate to have to spend a week. This "proper implementation" requirement is going to make implementation cost months. The majority of potential contributors (like me) are only capable of small, incremental fixes

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5522#note_86850