[PATCH 0/1] MR11565: msado15/tests: Fix typos.
From: Brendan Shanks <bshanks@codeweavers.com> --- dlls/msado15/tests/msado15.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msado15/tests/msado15.c b/dlls/msado15/tests/msado15.c index 202be584f78..5d004117934 100644 --- a/dlls/msado15/tests/msado15.c +++ b/dlls/msado15/tests/msado15.c @@ -1513,8 +1513,8 @@ static HRESULT WINAPI view_filter_SetFilter(IViewFilter *iface, HACCESSOR hacces ok(accessor->binding.dwPart == DBPART_VALUE, "accessor->binding.dwPart = %ld\n", accessor->binding.dwPart); ok(rows == 1, "rows = %Id\n", rows); ok(compare[0] == DBCOMPAREOPS_EQ, "compare[0] = %ld\n", compare[0]); - ok(V_VT(v) = VT_I4, "V_VT(criteria) = %d\n", V_VT(v)); - ok(V_I4(v) = 1, "V_I4(criteria) = %ld\n", V_I4(v)); + ok(V_VT(v) == VT_I4, "V_VT(criteria) = %d\n", V_VT(v)); + ok(V_I4(v) == 1, "V_I4(criteria) = %ld\n", V_I4(v)); return S_OK; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/11565
@piotr After fixing this test, it seems to be failing on Windows -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11565#note_147786
Piotr Caban (@piotr) commented about dlls/msado15/tests/msado15.c:
ok(accessor->binding.dwPart == DBPART_VALUE, "accessor->binding.dwPart = %ld\n", accessor->binding.dwPart); ok(rows == 1, "rows = %Id\n", rows); ok(compare[0] == DBCOMPAREOPS_EQ, "compare[0] = %ld\n", compare[0]); - ok(V_VT(v) = VT_I4, "V_VT(criteria) = %d\n", V_VT(v)); - ok(V_I4(v) = 1, "V_I4(criteria) = %ld\n", V_I4(v)); + ok(V_VT(v) == VT_I4, "V_VT(criteria) = %d\n", V_VT(v)); + ok(V_I4(v) == 1, "V_I4(criteria) = %ld\n", V_I4(v));
```suggestion:-1+0 ok(V_VT(v) == VT_BSTR, "V_VT(criteria) = %d\n", V_VT(v)); ok(!wcscmp(V_BSTR(v), L"1"), "V_BSTR(criteria) = %s\n", wine_dbgstr_w(V_BSTR(v))); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11565#note_147788
participants (3)
-
Brendan Shanks -
Brendan Shanks (@bshanks) -
Piotr Caban (@piotr)