[PATCH 0/1] MR10976: server: Do not drop the fd reference for mapping views on removable devices.

[Hieu Le Minh (＠hieu1m)]

Fixes Photoshop CC 2018-2021 installer crashes at 0% when executed from mounted ISOs. The missing file descriptor prevented setting the process image name, causing QueryFullProcessImageNameW to fail on Set-up.exe process and triggering self-termination by the installer. This is reported in https://bugs.winehq.org/show_bug.cgi?id=58913.

[test_program.iso](/uploads/7084b1dc558b5e45069a583bb1fbe421/test_program.iso)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10976

[PATCH 1/1] server: Do not drop the fd reference for mapping views on removable devices.

[Hieu Le Minh]

From: Hieu Le Minh <[e-mail]>

Fixes Photoshop CC 2018-2021 installer crashes at 0% when executed from
mounted ISOs. The missing file descriptor prevented setting the process
image name, causing QueryFullProcessImageNameW to fail on Set-up.exe
process and triggering self-termination by the installer. This is reported
in https://bugs.winehq.org/show_bug.cgi?id=58913.
---
 server/mapping.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/mapping.c b/server/mapping.c
index a53b6b68304..37f60f1a2c6 100644
--- a/server/mapping.c
+++ b/server/mapping.c
@@ -1719,7 +1719,7 @@ DECL_HANDLER(map_view)
         view->start     = req->start;
         view->flags     = mapping->flags;
         view->namelen   = 0;
-        view->fd        = !is_fd_removable( mapping->fd ) ? (struct fd *)grab_object( mapping->fd ) : NULL;
+        view->fd        = (struct fd *)grab_object( mapping->fd );
         view->committed = mapping->committed ? (struct ranges *)grab_object( mapping->committed ) : NULL;
         view->shared    = NULL;
         add_process_view( current, view );
@@ -1756,7 +1756,7 @@ DECL_HANDLER(map_image_view)
         view->flags     = mapping->flags;
         view->start     = 0;
         view->namelen   = 0;
-        view->fd        = !is_fd_removable( mapping->fd ) ? (struct fd *)grab_object( mapping->fd ) : NULL;
+        view->fd        = (struct fd *)grab_object( mapping->fd );
         view->committed = NULL;
         view->shared    = mapping->shared ? (struct shared_map *)grab_object( mapping->shared ) : NULL;
         view->image     = mapping->image;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10976