[PATCH 0/1] MR10066: mciqtz32: Hide video window before resetting parent on close.

[Rémi Bernon]

Avoids unnecessarily hiding then showing the window again, which seems
to often trigger race conditions especially with the Wayland backend.

---

This seems to fix the winmm:mci test with winewayland, where it consistently times out. The reason for the lockup is still unclear, and does not happen with every Wayland compositor (it does with Weston, which is the one used on my testbot runs, but not on GNOME), and can be reproduced with this patch: [0001-winmm-mci-test.patch](/uploads/36728018603793b33fd4653f6255fefb/0001-winmm-mci-test.patch)

The winex11 test failures are more elusive and I'm not able to reproduce them locally. They seem to happen more often at least on win32 configurations, which might indicate some memory exhaustion issue, but they also sometimes happen on wow64 so it's not clear.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10066

[PATCH 1/1] mciqtz32: Hide video window before resetting parent on close.

[Rémi Bernon]

From: Rémi Bernon <[e-mail]>

Avoids unnecessarily hiding then showing the window again, which seems
to often trigger race conditions especially with the Wayland backend.
---
 dlls/mciqtz32/mciqtz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/mciqtz32/mciqtz.c b/dlls/mciqtz32/mciqtz.c
index 6fb9c2f43b4..e86174029cd 100644
--- a/dlls/mciqtz32/mciqtz.c
+++ b/dlls/mciqtz32/mciqtz.c
@@ -381,6 +381,7 @@ static DWORD MCIQTZ_mciClose(UINT wDevID, DWORD dwFlags, LPMCI_GENERIC_PARMS lpP
     if (wma->opened) {
         if (wma->window)
         {
+            IVideoWindow_put_Visible(wma->vidwin, OAFALSE);
             IVideoWindow_put_MessageDrain(wma->vidwin, (OAHWND)NULL);
             IVideoWindow_put_Owner(wma->vidwin, (OAHWND)NULL);
             DestroyWindow(wma->window);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10066