Re: [PATCH v5 0/2] MR11376: wscript: Support UTF-16 LE and UTF-8 encoded script files.
On Tue Jul 14 10:50:30 2026 +0000, Lokesh Poovaragan wrote:
I have confirmed, Windows's `wscript.exe` does not strip the BOM from .js files, so in windows CI, it sees it as `WScript.` this triggers the following popup in GUI, leading to the 120s timeout on CI {width=498 height=272} And using `cscript.exe` it stderrs with `test_utf8bom.js(1, 1) Microsoft JScript runtime error: 'WScript' is undefined` So for this to work on CI, I have dropped the test for UTF-8 BOM (which I think is incorrect, I need a way to test on linux+wine but specifically exclude windows only for UTF-8 BOM, only for this test case) For the rest of the cases, UTF-16 LE and UTF-16 LE + BOM it works correctly and passes on windows + linux boxes I'm not sure what's the recommended way to move forward, as of right now, there is a branch of code that is not tested in the MR pertaining to UTF-8 BOM because windows does not support it, and it doesn't seem trivial to have the test present for linux but not for windows due to the way that tests run parallely as a whole in the gitlab runners
The UTF-16 LE and UTF-16 LE + BOM branches of the code have a test case each and it passes the test and satisfies the criteria for the initial bug reported, the comments on the bug report suggest it would be ideal to cover the UTF-8 BOM case too and the file attached in the initial report passes with the code changes in the MR I am uncertain how to do both without breaking any constraints wrt testing and satisfying the initial bug report conditions -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11376#note_145721
participants (1)
-
Lokesh Poovaragan (＠lokeshpoovaragan)