Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination

[Akihiro Sagawa (＠sgwaki)]

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c:
> +    WCHAR dll_name[MAX_PATH];
> +    int dll_name_len, i;
> +
> +    dll_name[0] = 0;
> +    GetModuleFileNameW(NULL, dll_name, MAX_PATH);
> +    dll_name_len = wcslen(dll_name);
> +    ok(dll_name_len > 0, "can't get path for NULL module\n");
> +    ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n");
> +
> +    memset(dll_name, 0x9, sizeof(dll_name));
> +    GetModuleFileNameW(NULL, dll_name, dll_name_len);
> +    for (i = 0; i < MAX_PATH && dll_name[i]; i++)
> +        ;
> +    ok(i > 0, "can't get path for NULL module with short buffer\n");
> +    ok(i < MAX_PATH, "unterminated path for NULL module with short buffer\n");
> +    if (i < MAX_PATH)
> It would be best to use the `todo_wine` keyword here instead of an `if` statement.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132021