Re: [PATCH v3 0/2] MR10809: comctl32: Fix VARHEIGHT rebar scaling when cyIntegral == 0

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c:
> DestroyWindow(hRebar);
>
> +    /* VARHEIGHT resizing test with cyIntegral == 0 on a horizontal rebar */
> +    hRebar = create_rebar_control(0);
> +    SetWindowLongA(hRebar, GWL_STYLE, GetWindowLongA(hRebar, GWL_STYLE) | RBS_AUTOSIZE);
> +    check_sizes();
> +    rbi.fMask = RBBIM_CHILD | RBBIM_CHILDSIZE | RBBIM_SIZE | RBBIM_STYLE;
> +    rbi.fStyle = RBBS_VARIABLEHEIGHT;
> +    rbi.cxMinChild = 50;

Why do you need three bands? The numbers are all pretty random, so it's not obvious what you are trying to test. Please simplify it more. Focus the test on the bug that you want to fix.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10809#note_141203