[PATCH v2 0/2] MR6439: include: Add UIA_TextAttributeIds constants in uiautomationclient.idl
Required for https://github.com/juce-framework/JUCE/blob/8.0.1/modules/juce_gui_basics/na... -- v2: include: Add UIA_LandmarkTypeIds constants in uiautomationclient.idl include: Add UIA_TextAttributeIds constants in uiautomationclient.idl https://gitlab.winehq.org/wine/wine/-/merge_requests/6439
From: Biswapriyo Nath <nathbappai(a)gmail.com> Required for https://github.com/juce-framework/JUCE/blob/8.0.1/modules/juce_gui_basics/na... --- include/uiautomationclient.idl | 54 ++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/include/uiautomationclient.idl b/include/uiautomationclient.idl index 1026230f1c2..a6faf5a6d45 100644 --- a/include/uiautomationclient.idl +++ b/include/uiautomationclient.idl @@ -346,6 +346,60 @@ library UIAutomationClient { /* } */ + + /* FIXME: Uncomment when properly supported in widl + [dllname("<no entry points>")] + module UIA_TextAttributeIds + { + */ + const long UIA_AnimationStyleAttributeId = 40000; + const long UIA_BackgroundColorAttributeId = 40001; + const long UIA_BulletStyleAttributeId = 40002; + const long UIA_CapStyleAttributeId = 40003; + const long UIA_CultureAttributeId = 40004; + const long UIA_FontNameAttributeId = 40005; + const long UIA_FontSizeAttributeId = 40006; + const long UIA_FontWeightAttributeId = 40007; + const long UIA_ForegroundColorAttributeId = 40008; + const long UIA_HorizontalTextAlignmentAttributeId = 40009; + const long UIA_IndentationFirstLineAttributeId = 40010; + const long UIA_IndentationLeadingAttributeId = 40011; + const long UIA_IndentationTrailingAttributeId = 40012; + const long UIA_IsHiddenAttributeId = 40013; + const long UIA_IsItalicAttributeId = 40014; + const long UIA_IsReadOnlyAttributeId = 40015; + const long UIA_IsSubscriptAttributeId = 40016; + const long UIA_IsSuperscriptAttributeId = 40017; + const long UIA_MarginBottomAttributeId = 40018; + const long UIA_MarginLeadingAttributeId = 40019; + const long UIA_MarginTopAttributeId = 40020; + const long UIA_MarginTrailingAttributeId = 40021; + const long UIA_OutlineStylesAttributeId = 40022; + const long UIA_OverlineColorAttributeId = 40023; + const long UIA_OverlineStyleAttributeId = 40024; + const long UIA_StrikethroughColorAttributeId = 40025; + const long UIA_StrikethroughStyleAttributeId = 40026; + const long UIA_TabsAttributeId = 40027; + const long UIA_TextFlowDirectionsAttributeId = 40028; + const long UIA_UnderlineColorAttributeId = 40029; + const long UIA_UnderlineStyleAttributeId = 40030; + const long UIA_AnnotationTypesAttributeId = 40031; + const long UIA_AnnotationObjectsAttributeId = 40032; + const long UIA_StyleNameAttributeId = 40033; + const long UIA_StyleIdAttributeId = 40034; + const long UIA_LinkAttributeId = 40035; + const long UIA_IsActiveAttributeId = 40036; + const long UIA_SelectionActiveEndAttributeId = 40037; + const long UIA_CaretPositionAttributeId = 40038; + const long UIA_CaretBidiModeAttributeId = 40039; + const long UIA_LineSpacingAttributeId = 40040; + const long UIA_BeforeParagraphSpacingAttributeId = 40041; + const long UIA_AfterParagraphSpacingAttributeId = 40042; + const long UIA_SayAsInterpretAsAttributeId = 40043; + /* + } + */ + /* FIXME: Uncomment when properly supported in widl [dllname("<no entry points>")] module UIA_ControlTypeIds -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6439
From: Biswapriyo Nath <nathbappai(a)gmail.com> Required for https://github.com/mozilla/gecko-dev/commit/1ad35e5b84f5c349ecb2c54d679250d6... --- include/uiautomationclient.idl | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/uiautomationclient.idl b/include/uiautomationclient.idl index a6faf5a6d45..b32aea4b3e6 100644 --- a/include/uiautomationclient.idl +++ b/include/uiautomationclient.idl @@ -450,6 +450,20 @@ library UIAutomationClient { }; */ + /* FIXME: Uncomment when properly supported in widl + [dllname("<no entry points>")] + module UIA_LandmarkTypeIds + { + */ + const long UIA_CustomLandmarkTypeId = 80000; + const long UIA_FormLandmarkTypeId = 80001; + const long UIA_MainLandmarkTypeId = 80002; + const long UIA_NavigationLandmarkTypeId = 80003; + const long UIA_SearchLandmarkTypeId = 80004; + /* + }; + */ + interface IUIAutomationElement; interface IUIAutomationElementArray; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6439
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=148419 Your paranoid android. === debian11b (64 bit WoW report) === user32: input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000001E000EA, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032
Would it be possible to review this merge request please? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6439#note_82671
This looks fine code wise, but I think you should change your commit titles to be: ``` include: Add UI Automation Text Attribute ID definitions. include: Add UI Automation Landmark Type ID definitions. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6439#note_83544
participants (4)
-
Biswapriyo Nath -
Biswapriyo Nath (＠Biswa96)
-
Connor McAdams (＠cmcadams)
-
Marvin