Re: [PATCH v16 0/1] MR11398: wined3d: Support WINE_D3D_CONFIG=no_create_flags=0x800 (bug #50277)

[Stian Low (＠stianlow)]

> I think it may still be useful to keep this MR as a draft, for users who want to apply the patch manually to their own Wine builds as a temporary workaround. It seems this workaround may not be acceptable for merging as-is.

Thanks for feedback.

I agree the more expansive form of this MR that supports overriding all create flags instead of only D3D11_CREATE_DEVICE_VIDEO_SUPPORT may be useful so I will preserve it with a separate MR that will be linked to this one.

However based on consensus so far it seems to favor the more minimized form which only supports overrides D3D11_CREATE_DEVICE_VIDEO_SUPPORT instead of all create flags.

Therefore this MR will be fulfill that favorability in order to expedite a most immediate solution that is most likely to be approved for merge to help users.
> I can help test the MR-11404 patch for a proper implementation, since I have multiple Unity games affected by this issue.

Thanks for the help.

MR-11404 and the one that will be linked to support more expanded overrides will support the same command that users will need to test Unity games so from perspective of your Unity games both patches should appear identical at least for fixing only video specific bugs:

`WINE_D3D_CONFIG=no_create_flags=0x800 wine some_unity_game.exe`
> If that implementation needs more time to complete and test, maybe MR-11404 could expose a similar opt-in config, like renderer=vulkan. That is also an experimental / incomplete feature, but it gives users a way to test it explicitly.

MR-11404 is a less immediate solution which will not require any special overrides such as `WINE_D3D_CONFIG=no_create_flags=0x800` to fix videos.  

MR-11404 has more dependencies that also need to be fixed to be considered more fully fixed like 11398 (at least from user perspective) and may therefore be considered less complete until further progress is made across those other dependencies.
> Personally, I would prefer an opt-in experimental implementation over having an incomplete implementation enabled unconditionally, if it causes many Unity games to crash and requires me to manually revert it for my daily Wine builds.

Experimental/override implementation provided by MR-11398 will be available as a backup if when ready, default MR-11404 is still considered too buggy for one reason or another.  Therefore the best of both worlds should be available to games especially for Unity Engine.  

In the meantime, until MR-11404 is ready/merged, MR-11398 may be the only solution for Unity gamers once merged (presumably before MR-11404).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11398#note_148270