[PATCH 0/1] MR7124: mfmediaengine: Fix maths in scaling check.

[Brendan McGrath (＠redmcg)]

This fixes a bug introduced in commit 7868484f04680c17cf56265c4cc0cb2319959a94.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

[PATCH 1/1] mfmediaengine: Fix maths in scaling check.

[Brendan McGrath]

From: Brendan McGrath <bmcgrath(a)codeweavers.com>

---
 dlls/mfmediaengine/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mfmediaengine/main.c b/dlls/mfmediaengine/main.c
index 1a8f6291342..27249f09fa6 100644
--- a/dlls/mfmediaengine/main.c
+++ b/dlls/mfmediaengine/main.c
@@ -2521,7 +2521,7 @@ static HRESULT media_engine_transfer_d3d11(struct media_engine *engine, ID3D11Te
     src_box.back = 1;
 
     if (dst_rect->left + src_box.right - src_box.left > dst_desc.Width ||
-            dst_rect->top + src_box.top - src_box.bottom > dst_desc.Height)
+            dst_rect->top + src_box.bottom - src_box.top > dst_desc.Height)
     {
         ID3D11Texture2D_Release(src_texture);
         return MF_E_UNEXPECTED;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

[PATCH 1/1] mfmediaengine: Fix maths in scaling check.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150836

Your paranoid android.


=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1574: Test failed: AbortWaitCts hComPortEvent failed
comm.c:1586: Test failed: Unexpected time 1000, expected around 500

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000014000EE, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[PATCH 0/1] MR7124: mfmediaengine: Fix maths in scaling check. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

[Nikolay Sivov (＠nsivov)]

Do we need this intersection check at all?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7124#note_91752