[PATCH v4 0/2] MR4748: Don't test function directly when reporting GetLastError()

[André Zwing]

--
  v4: ntoskrnl/tests: Use RtlNtStatusToDosErrorNoTeb() for stateless conversion
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

[PATCH v4 1/2] mscoree/tests: Don't test function directly when reporting GetLastError()

[André Zwing]

From: André Zwing <nerv(a)dawncrow.de>

---
 dlls/mscoree/tests/mscoree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/mscoree/tests/mscoree.c b/dlls/mscoree/tests/mscoree.c
index bfcbc78db55..7a3dda729d6 100644
--- a/dlls/mscoree/tests/mscoree.c
+++ b/dlls/mscoree/tests/mscoree.c
@@ -633,8 +633,8 @@ static void test_loadpaths_execute(const WCHAR *exe_name, const WCHAR *dll_name,
     DWORD exit_code = 0xdeadbeef;
     BOOL ret;
 
-    ok(create_new_dir(tmpdir, L"loadpaths"),
-       "failed to create a new dir %lu\n", GetLastError());
+    ret = create_new_dir(tmpdir, L"loadpaths");
+    ok(ret, "failed to create a new dir %lu\n", GetLastError());
     end = tmpdir + wcslen(tmpdir);
 
     wcscpy(tmpexe, tmpdir);
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

[PATCH v4 2/2] ntoskrnl/tests: Use RtlNtStatusToDosErrorNoTeb() for stateless conversion

[André Zwing]

From: André Zwing <nerv(a)dawncrow.de>

---
 dlls/ntoskrnl.exe/tests/ntoskrnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index 13258b05291..5a47523cf71 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -672,7 +672,7 @@ static void do_return_status(ULONG ioctl, struct return_status_params *params)
     }
     else
     {
-        ok(GetLastError() == RtlNtStatusToDosError(expect_status), "got error %lu\n", GetLastError());
+        ok(GetLastError() == RtlNtStatusToDosErrorNoTeb(expect_status), "got error %lu\n", GetLastError());
     }
     if (NT_ERROR(expect_status))
         ok(size == 0xdeadf00d, "got size %lu\n", size);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

[PATCH v4 2/2] ntoskrnl/tests: Use RtlNtStatusToDosErrorNoTeb() for stateless conversion

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=141558

Your paranoid android.


=== build (build log) ===

error: patch failed: dlls/mscoree/tests/mscoree.c:633
Task: Patch failed to apply

=== debian11 (build log) ===

error: patch failed: dlls/mscoree/tests/mscoree.c:633
Task: Patch failed to apply

=== debian11b (build log) ===

error: patch failed: dlls/mscoree/tests/mscoree.c:633
Task: Patch failed to apply

[André Zwing]

On Tue Jan  2 04:34:47 2024 +0000, Zebediah Figura wrote:
> Now the commit message is no longer true, though :-/
> right, fixed :)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4748#note_56613