[PATCH v3 0/5] MR4741: d3d9: Update presentation parameters when creating a swap chain.
Fixes regression introduced by 215a32d643af4a8e25d4f28c5bec76f6e69dca22. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56070 -- v3: d3d9: Update presentation parameters when creating a swap chain. https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
From: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/d3d8/tests/device.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index fd06e1bf79d..ef3a429afe0 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -8896,6 +8896,33 @@ static void test_swapchain_parameters(void) IDirect3DDevice8_Release(device); } + memset(&present_parameters, 0, sizeof(present_parameters)); + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + present_parameters.Windowed = TRUE; + present_parameters.BackBufferWidth = 0; + present_parameters.BackBufferHeight = 0; + present_parameters.BackBufferFormat = D3DFMT_X8R8G8B8; + + hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, + window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, + &present_parameters, &device); + + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); + ok(!present_parameters.BackBufferWidth, "Got unexpected BackBufferWidth %u.\n", present_parameters.BackBufferWidth); + ok(!present_parameters.BackBufferHeight, "Got unexpected BackBufferHeight %u,.\n", present_parameters.BackBufferHeight); + ok(present_parameters.BackBufferFormat == D3DFMT_X8R8G8B8, "Got unexpected BackBufferFormat %#x.\n", present_parameters.BackBufferFormat); + ok(present_parameters.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", present_parameters.BackBufferCount); + ok(!present_parameters.MultiSampleType, "Got unexpected MultiSampleType %u.\n", present_parameters.MultiSampleType); + ok(present_parameters.SwapEffect == D3DSWAPEFFECT_DISCARD, "Got unexpected SwapEffect %#x.\n", present_parameters.SwapEffect); + ok(!present_parameters.hDeviceWindow, "Got unexpected hDeviceWindow %p.\n", present_parameters.hDeviceWindow); + ok(present_parameters.Windowed, "Got unexpected Windowed %#x.\n", present_parameters.Windowed); + ok(!present_parameters.EnableAutoDepthStencil, "Got unexpected EnableAutoDepthStencil %#x.\n", present_parameters.EnableAutoDepthStencil); + ok(!present_parameters.AutoDepthStencilFormat, "Got unexpected AutoDepthStencilFormat %#x.\n", present_parameters.AutoDepthStencilFormat); + ok(!present_parameters.Flags, "Got unexpected Flags %#lx.\n", present_parameters.Flags); + ok(!present_parameters.FullScreen_RefreshRateInHz, "Got unexpected FullScreen_RefreshRateInHz %u.\n", present_parameters.FullScreen_RefreshRateInHz); + ok(!present_parameters.FullScreen_PresentationInterval, "Got unexpected FullScreen_PresentationInterval %#x.\n", present_parameters.FullScreen_PresentationInterval); + + IDirect3DDevice8_Release(device); IDirect3D8_Release(d3d); DestroyWindow(window); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
From: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/d3d9/tests/d3d9ex.c | 34 ++++++++++++++++++++++++++++++++++ dlls/d3d9/tests/device.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+) diff --git a/dlls/d3d9/tests/d3d9ex.c b/dlls/d3d9/tests/d3d9ex.c index 77830cae631..44d5edba63c 100644 --- a/dlls/d3d9/tests/d3d9ex.c +++ b/dlls/d3d9/tests/d3d9ex.c @@ -3686,6 +3686,7 @@ static void test_swapchain_parameters(void) { IDirect3DDevice9Ex *device; IDirect3D9Ex *d3d9ex; + RECT client_rect; HWND window; HRESULT hr; unsigned int i; @@ -3837,6 +3838,39 @@ static void test_swapchain_parameters(void) IDirect3DDevice9Ex_Release(device); } + memset(&present_parameters, 0, sizeof(present_parameters)); + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + present_parameters.Windowed = TRUE; + present_parameters.BackBufferWidth = 0; + present_parameters.BackBufferHeight = 0; + present_parameters.BackBufferFormat = D3DFMT_UNKNOWN; + + GetClientRect(window, &client_rect); + + hr = IDirect3D9Ex_CreateDeviceEx(d3d9ex, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, + window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, + &present_parameters, NULL, &device); + + todo_wine ok(present_parameters.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", + present_parameters.BackBufferWidth, client_rect.right); + todo_wine ok(present_parameters.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", + present_parameters.BackBufferHeight, client_rect.bottom); + todo_wine ok(present_parameters.BackBufferFormat != D3DFMT_UNKNOWN, "Got unexpected BackBufferFormat %#x.\n", + present_parameters.BackBufferFormat); + ok(present_parameters.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", present_parameters.BackBufferCount); + ok(!present_parameters.MultiSampleType, "Got unexpected MultiSampleType %u.\n", present_parameters.MultiSampleType); + ok(!present_parameters.MultiSampleQuality, "Got unexpected MultiSampleQuality %lu.\n", present_parameters.MultiSampleQuality); + ok(present_parameters.SwapEffect == D3DSWAPEFFECT_DISCARD, "Got unexpected SwapEffect %#x.\n", present_parameters.SwapEffect); + ok(!present_parameters.hDeviceWindow, "Got unexpected hDeviceWindow %p.\n", present_parameters.hDeviceWindow); + ok(present_parameters.Windowed, "Got unexpected Windowed %#x.\n", present_parameters.Windowed); + ok(!present_parameters.EnableAutoDepthStencil, "Got unexpected EnableAutoDepthStencil %#x.\n", present_parameters.EnableAutoDepthStencil); + ok(!present_parameters.AutoDepthStencilFormat, "Got unexpected AutoDepthStencilFormat %#x.\n", present_parameters.AutoDepthStencilFormat); + ok(!present_parameters.Flags, "Got unexpected Flags %#lx.\n", present_parameters.Flags); + ok(!present_parameters.FullScreen_RefreshRateInHz, "Got unexpected FullScreen_RefreshRateInHz %u.\n", + present_parameters.FullScreen_RefreshRateInHz); + ok(!present_parameters.PresentationInterval, "Got unexpected PresentationInterval %#x.\n", present_parameters.PresentationInterval); + IDirect3DDevice9Ex_Release(device); + IDirect3D9Ex_Release(d3d9ex); DestroyWindow(window); } diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index de0bedba7ca..0af7f179df6 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -12296,6 +12296,7 @@ static void test_swapchain_parameters(void) { IDirect3DDevice9 *device; HRESULT hr, expected_hr; + RECT client_rect; IDirect3D9 *d3d; D3DCAPS9 caps; HWND window; @@ -12493,6 +12494,40 @@ static void test_swapchain_parameters(void) IDirect3DDevice9_Release(device); } + memset(&present_parameters, 0, sizeof(present_parameters)); + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + present_parameters.Windowed = TRUE; + present_parameters.BackBufferWidth = 0; + present_parameters.BackBufferHeight = 0; + present_parameters.BackBufferFormat = D3DFMT_UNKNOWN; + + GetClientRect(window, &client_rect); + + hr = IDirect3D9_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, + window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, + &present_parameters, &device); + + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); + todo_wine ok(present_parameters.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", + present_parameters.BackBufferWidth, client_rect.right); + todo_wine ok(present_parameters.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", + present_parameters.BackBufferHeight, client_rect.bottom); + todo_wine ok(present_parameters.BackBufferFormat != D3DFMT_UNKNOWN, "Got unexpected BackBufferFormat %#x.\n", + present_parameters.BackBufferFormat); + ok(present_parameters.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", present_parameters.BackBufferCount); + ok(!present_parameters.MultiSampleType, "Got unexpected MultiSampleType %u.\n", present_parameters.MultiSampleType); + ok(!present_parameters.MultiSampleQuality, "Got unexpected MultiSampleQuality %lu.\n", present_parameters.MultiSampleQuality); + ok(present_parameters.SwapEffect == D3DSWAPEFFECT_DISCARD, "Got unexpected SwapEffect %#x.\n", present_parameters.SwapEffect); + ok(!present_parameters.hDeviceWindow, "Got unexpected hDeviceWindow %p.\n", present_parameters.hDeviceWindow); + ok(present_parameters.Windowed, "Got unexpected Windowed %#x.\n", present_parameters.Windowed); + ok(!present_parameters.EnableAutoDepthStencil, "Got unexpected EnableAutoDepthStencil %#x.\n", present_parameters.EnableAutoDepthStencil); + ok(!present_parameters.AutoDepthStencilFormat, "Got unexpected AutoDepthStencilFormat %#x.\n", present_parameters.AutoDepthStencilFormat); + ok(!present_parameters.Flags, "Got unexpected Flags %#lx.\n", present_parameters.Flags); + ok(!present_parameters.FullScreen_RefreshRateInHz, "Got unexpected FullScreen_RefreshRateInHz %u.\n", + present_parameters.FullScreen_RefreshRateInHz); + ok(!present_parameters.PresentationInterval, "Got unexpected PresentationInterval %#x.\n", present_parameters.PresentationInterval); + + IDirect3DDevice9_Release(device); IDirect3D9_Release(d3d); DestroyWindow(window); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
From: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/d3d8/tests/device.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index ef3a429afe0..108895e4d02 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -410,7 +410,11 @@ static void test_swapchain(void) d3dpp.BackBufferCount = 0; hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); ok(SUCCEEDED(hr), "Got hr %#lx.\n", hr); - ok(d3dpp.BackBufferCount == 1, "The back buffer count in the presentparams struct is %d\n", d3dpp.BackBufferCount); + ok(!d3dpp.BackBufferWidth, "Got unexpected BackBufferWidth %u.\n", d3dpp.BackBufferWidth); + ok(!d3dpp.BackBufferHeight, "Got unexpected BackBufferHeight %u.\n", d3dpp.BackBufferHeight); + ok(d3dpp.BackBufferFormat == D3DFMT_A8R8G8B8, "Got unexpected BackBufferFormat %#x.\n", d3dpp.BackBufferFormat); + ok(d3dpp.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", d3dpp.BackBufferCount); + ok(!d3dpp.hDeviceWindow, "Got unexpected hDeviceWindow %p.\n", d3dpp.hDeviceWindow); d3dpp.hDeviceWindow = NULL; d3dpp.BackBufferCount = 1; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
From: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/d3d9/tests/device.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 0af7f179df6..5c08d35c93f 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -1263,6 +1263,7 @@ static void test_swapchain(void) IDirect3DSurface9 *backbuffer, *stereo_buffer; D3DPRESENT_PARAMETERS d3dpp; IDirect3DDevice9 *device; + RECT client_rect; IDirect3D9 *d3d; ULONG refcount; HWND window, window2; @@ -1341,11 +1342,23 @@ static void test_swapchain(void) ok(swapchainX == NULL, "Swapchain 1 is %p\n", swapchainX); if(swapchainX) IDirect3DSwapChain9_Release(swapchainX); + memset(&d3dpp, 0, sizeof(d3dpp)); + d3dpp.Windowed = TRUE; + d3dpp.SwapEffect = D3DSWAPEFFECT_DISCARD; + d3dpp.BackBufferFormat = D3DFMT_A8R8G8B8; + GetClientRect(window, &client_rect); + /* Create a bunch of swapchains */ d3dpp.BackBufferCount = 0; hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); ok(SUCCEEDED(hr), "Got hr %#lx.\n", hr); - ok(d3dpp.BackBufferCount == 1, "The back buffer count in the presentparams struct is %d\n", d3dpp.BackBufferCount); + todo_wine ok(d3dpp.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", + d3dpp.BackBufferWidth, client_rect.right); + todo_wine ok(d3dpp.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", + d3dpp.BackBufferHeight, client_rect.bottom); + ok(d3dpp.BackBufferFormat == D3DFMT_A8R8G8B8, "Got unexpected BackBufferFormat %#x.\n", d3dpp.BackBufferFormat); + ok(d3dpp.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", d3dpp.BackBufferCount); + ok(!d3dpp.hDeviceWindow, "Got unexpected hDeviceWindow %p.\n", d3dpp.hDeviceWindow); d3dpp.hDeviceWindow = NULL; d3dpp.BackBufferCount = 1; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
From: Akihiro Sagawa <sagawa.aki(a)gmail.com> Fixes regression introduced by 215a32d643af4a8e25d4f28c5bec76f6e69dca22. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56070 --- dlls/d3d9/swapchain.c | 6 ++++++ dlls/d3d9/tests/d3d9ex.c | 6 +++--- dlls/d3d9/tests/device.c | 10 +++++----- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/dlls/d3d9/swapchain.c b/dlls/d3d9/swapchain.c index 26c47f2c6ec..e87b8627ba3 100644 --- a/dlls/d3d9/swapchain.c +++ b/dlls/d3d9/swapchain.c @@ -370,6 +370,7 @@ static const struct wined3d_swapchain_state_parent_ops d3d9_swapchain_state_pare static HRESULT swapchain_init(struct d3d9_swapchain *swapchain, struct d3d9_device *device, struct wined3d_swapchain_desc *desc, unsigned int swap_interval) { + struct wined3d_swapchain_desc swapchain_desc; HRESULT hr; swapchain->refcount = 1; @@ -384,6 +385,11 @@ static HRESULT swapchain_init(struct d3d9_swapchain *swapchain, struct d3d9_devi return hr; } + wined3d_swapchain_get_desc(swapchain->wined3d_swapchain, &swapchain_desc); + desc->backbuffer_width = swapchain_desc.backbuffer_width; + desc->backbuffer_height = swapchain_desc.backbuffer_height; + desc->backbuffer_format = swapchain_desc.backbuffer_format; + swapchain->parent_device = &device->IDirect3DDevice9Ex_iface; IDirect3DDevice9Ex_AddRef(swapchain->parent_device); diff --git a/dlls/d3d9/tests/d3d9ex.c b/dlls/d3d9/tests/d3d9ex.c index 44d5edba63c..8e7eec13566 100644 --- a/dlls/d3d9/tests/d3d9ex.c +++ b/dlls/d3d9/tests/d3d9ex.c @@ -3851,11 +3851,11 @@ static void test_swapchain_parameters(void) window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, NULL, &device); - todo_wine ok(present_parameters.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", + ok(present_parameters.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", present_parameters.BackBufferWidth, client_rect.right); - todo_wine ok(present_parameters.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", + ok(present_parameters.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", present_parameters.BackBufferHeight, client_rect.bottom); - todo_wine ok(present_parameters.BackBufferFormat != D3DFMT_UNKNOWN, "Got unexpected BackBufferFormat %#x.\n", + ok(present_parameters.BackBufferFormat != D3DFMT_UNKNOWN, "Got unexpected BackBufferFormat %#x.\n", present_parameters.BackBufferFormat); ok(present_parameters.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", present_parameters.BackBufferCount); ok(!present_parameters.MultiSampleType, "Got unexpected MultiSampleType %u.\n", present_parameters.MultiSampleType); diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 5c08d35c93f..9d92b248dd9 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -1352,9 +1352,9 @@ static void test_swapchain(void) d3dpp.BackBufferCount = 0; hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); ok(SUCCEEDED(hr), "Got hr %#lx.\n", hr); - todo_wine ok(d3dpp.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", + ok(d3dpp.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", d3dpp.BackBufferWidth, client_rect.right); - todo_wine ok(d3dpp.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", + ok(d3dpp.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", d3dpp.BackBufferHeight, client_rect.bottom); ok(d3dpp.BackBufferFormat == D3DFMT_A8R8G8B8, "Got unexpected BackBufferFormat %#x.\n", d3dpp.BackBufferFormat); ok(d3dpp.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", d3dpp.BackBufferCount); @@ -12521,11 +12521,11 @@ static void test_swapchain_parameters(void) &present_parameters, &device); ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); - todo_wine ok(present_parameters.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", + ok(present_parameters.BackBufferWidth == client_rect.right, "Got unexpected BackBufferWidth %u, expected %ld.\n", present_parameters.BackBufferWidth, client_rect.right); - todo_wine ok(present_parameters.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", + ok(present_parameters.BackBufferHeight == client_rect.bottom, "Got unexpected BackBufferHeight %u, expected %ld.\n", present_parameters.BackBufferHeight, client_rect.bottom); - todo_wine ok(present_parameters.BackBufferFormat != D3DFMT_UNKNOWN, "Got unexpected BackBufferFormat %#x.\n", + ok(present_parameters.BackBufferFormat != D3DFMT_UNKNOWN, "Got unexpected BackBufferFormat %#x.\n", present_parameters.BackBufferFormat); ok(present_parameters.BackBufferCount == 1, "Got unexpected BackBufferCount %u.\n", present_parameters.BackBufferCount); ok(!present_parameters.MultiSampleType, "Got unexpected MultiSampleType %u.\n", present_parameters.MultiSampleType); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=141652 Your paranoid android. === w10pro64 (32 bit report) === d3d9: device.c:4179: Test failed: Expected message 0x46 for window 0x1, but didn't receive it, i=0. device.c:4223: Test failed: Expected message 0x7e for window 0, but didn't receive it, i=0. device.c:4227: Test failed: The device window is active, i=0. device.c:4232: Test failed: Got unexpected hr 0x88760869. device.c:4236: Test failed: Got unexpected screen size 800x600. device.c:4268: Test failed: Expected message 0x46 for window 0, but didn't receive it, i=0. device.c:4277: Test failed: Got unexpected screen size 800x600. device.c:4294: Test failed: Expected message 0x7e for window 0, but didn't receive it, i=0. device.c:4303: Test failed: Got unexpected width 640. device.c:4304: Test failed: Got unexpected height 480. device.c:4385: Test failed: Expected message 0x7e for window 0x1, but didn't receive it, i=0. device.c:4395: Test failed: Expected IsIconic 1, got 0, i=0. device.c:4399: Test failed: Got unexpected hr 0. device.c:4407: Test failed: Expected message 0x46 for window 0x1, but didn't receive it, i=0. device.c:4445: Test failed: Expected message 0x1c for window 0x1, but didn't receive it, i=0. device.c:4455: Test failed: Got unexpected hr 0. device.c:4513: Test failed: Expected message 0x18 for window 0, but didn't receive it, i=0. device.c:4519: Test failed: Got unexpected WINDOWPOS hwnd=00000000, insertAfter=00000000, x=0, y=0, cx=0, cy=0, flags=0 device.c:4536: Test failed: Expected the device window to be visible, i=0. === debian11b (64 bit WoW report) === comctl32: button.c:801: Test failed: [0] expected uItemState 16, got 80 button.c:801: Test failed: [0] expected uItemState 16, got 80 button.c:810: Test failed: [0] expected uItemState 0, got 64 button.c:810: Test failed: [0] expected uItemState 0, got 64 button.c:819: Test failed: [0] expected uItemState 0, got 64 button.c:819: Test failed: [0] expected uItemState 0, got 64 button.c:834: Test failed: expected state 0, got 0200 button.c:838: Test failed: [0] expected uItemState 1, got 65 button.c:838: Test failed: [0] expected uItemState 1, got 65 button.c:847: Test failed: expected state 0x0004, got 0204 button.c:854: Test failed: [0] expected uItemState 0, got 64 button.c:854: Test failed: [0] expected uItemState 0, got 64 button.c:859: Test failed: BM_SETSTATE/FALSE on a button: the msg sequence is not complete: expected 0000 - actual 0084 button.c:863: Test failed: expected state 0, got 0200 button.c:898: Test failed: [0] expected uItemState 0, got 64 button.c:898: Test failed: [0] expected uItemState 0, got 64 button.c:898: Test failed: [0] expected uItemState 0, got 64 button.c:898: Test failed: [0] expected uItemState 0, got 64
On Mon Jan 8 09:10:46 2024 +0000, Zebediah Figura wrote:
Sorry about that. This seems to have also fixed the d3d9ex tests, so those'll need the todo_wine removed from them. I've updated the patch. I missed that. Thanks for pointing it out.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4741#note_56883
This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4741
participants (4)
-
Akihiro Sagawa -
Akihiro Sagawa (＠sgwaki)
-
Marvin -
Zebediah Figura (＠zfigura)