Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Aidan Khoury (＠ajkhoury)]

On Thu Oct  5 17:32:10 2023 +0000, Jeffrey Smith wrote:
> The three .h files in your tests are --in effect-- huge data blobs,
> which is something that should usually be avoided in source code repositories
> as far as is possible.  I haven't had a chance to look in detail at how
> you are using them,
> but here a couple of things you may want to investigate:
> 1. Can the tests be accomplished with smaller sample files?
> 2. Better yet, can the buffers be --at least partially-- generated
> programmatic at test time?  (as I did with `setup_pe_with_sections` in
> my tests)
> BTW, what was your source for those three buffers?
1. Yes, however not easily. With my sample PE (which is what I used to make the "normalized" buffers), it was not complex enough to emit patch transformations when I used the mspatchc API. I tried for about a dozen hours before giving in and using an existing real world buffer, which I extracted from the adobe installers.
2. Possible, yet extremely complicated as patch transformations appear pretty complex.

The source of the buffers is the adobe acrobat x86_64 installer.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47740