[PATCH 0/1] MR6238: comdlg32: Add `const' qualifier

[Ruslan Garipov (＠ruslangaripov)]

No functional changes intended.

Please, review.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

[PATCH 1/1] comdlg32: Add `const' qualifier

[Ruslan Garipov]

From: Ruslan Garipov <ruslanngaripov(a)gmail.com>

No functional changes intended.

Signed-off-by: Ruslan Garipov <ruslanngaripov(a)gmail.com>
---
 dlls/comdlg32/cdlg.h    | 2 +-
 dlls/comdlg32/filedlg.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/comdlg32/cdlg.h b/dlls/comdlg32/cdlg.h
index 16c3a15ab45..20e960c1d4b 100644
--- a/dlls/comdlg32/cdlg.h
+++ b/dlls/comdlg32/cdlg.h
@@ -177,7 +177,7 @@ HRESULT FileSaveDialog_Constructor(IUnknown *pUnkOuter, REFIID riid, void **ppv)
 void COMDLG32_GetCanonicalPath(PCIDLIST_ABSOLUTE pidlAbsCurrent, LPWSTR lpstrFile, LPWSTR lpstrPathAndFile);
 int FILEDLG95_ValidatePathAction(LPWSTR lpstrPathAndFile, IShellFolder **ppsf,
                                  HWND hwnd, DWORD flags, BOOL isSaveDlg, int defAction);
-int COMDLG32_SplitFileNames(LPWSTR lpstrEdit, UINT nStrLen, LPWSTR *lpstrFileList, UINT *sizeUsed);
+int COMDLG32_SplitFileNames(LPCWSTR lpstrEdit, UINT nStrLen, LPWSTR *lpstrFileList, UINT *sizeUsed);
 void FILEDLG95_OnOpenMessage(HWND hwnd, int idCaption, int idText);
 
 extern BOOL GetFileName31A( OPENFILENAMEA *lpofn, UINT dlgType );
diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c
index 441f203fe7b..038d721d992 100644
--- a/dlls/comdlg32/filedlg.c
+++ b/dlls/comdlg32/filedlg.c
@@ -648,7 +648,7 @@ void COMDLG32_GetCanonicalPath(PCIDLIST_ABSOLUTE pidlAbsCurrent,
  *
  * Creates a delimited list of filenames.
  */
-int COMDLG32_SplitFileNames(LPWSTR lpstrEdit, UINT nStrLen, LPWSTR *lpstrFileList, UINT *sizeUsed)
+int COMDLG32_SplitFileNames(LPCWSTR lpstrEdit, UINT nStrLen, LPWSTR *lpstrFileList, UINT *sizeUsed)
 {
 	UINT nStrCharCount = 0;	/* index in src buffer */
 	UINT nFileIndex = 0;	/* index in dest buffer */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

[PATCH 0/1] MR6238: comdlg32: Add `const' qualifier - approved

[Alfred Agrell (＠Alcaro)]

This merge request was approved by Alfred Agrell.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

[Fabian Maurer (＠DarkShadow44)]

I think there's a bunch of places where things could be made const, is there a specific reason you changed this one?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6238#note_84831

[Ruslan Garipov (＠ruslangaripov)]

On Wed Oct 16 09:38:08 2024 +0000, Fabian Maurer wrote:
> I think there's a bunch of places where things could be made const, is
> there a specific reason you changed this one?
> No.
> I just have a local/specific code which calls the `COMDLG32_SplitFileNames()` function passing address(es) of non-modifiable string(s).
> In other words, I just found this case "accidentally".

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6238#note_85115

[Fabian Maurer (＠DarkShadow44)]

On Wed Oct 16 09:38:08 2024 +0000, Ruslan Garipov wrote:
> No.
> I just have a local/specific code which calls the
> `COMDLG32_SplitFileNames()` function passing address(es) of
> non-modifiable string(s).
> In other words, I just found this case "accidentally".
> Code you want to eventually upstream? I'd consider that a good reason to change it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6238#note_85189