Re: [PATCH v2 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().

March 10, 2026


      Matteo Bruni (@Mystral) commented about dlls/d3dxof/d3dxof.c:
...
if (!pcbSize || !ppvData)
     return DXFILEERR_BADVALUE;
+  if (!This->pdata_user_copy && This->pobj->root->pdata && This->pobj->size > 0)
+  {
+      This->pdata_user_copy = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->pobj->size);
No point in zeroing the memory to then overwrite it immediately.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10278#note_131745

Matteo Bruni (＠Mystral)

tags

participants (1)