Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK

[Sven Baars (＠sbaars)]

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c:
> +    {
> +        ERR("SetIDList failed\n");
> +        return;
> +    }
> +    _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH);
> +    length = wcslen(filename) + wcslen(shortcutW);
> +    if (length > MAX_PATH)
> +    {
> +        ERR("Path maximum length exceeded (%i>%i)\n", length, MAX_PATH);
> +        IShellLinkW_Release(shelllink);
> +        return;
> +    }
> +
> +    SHGetPathFromIDListW(This->pidl, root);
> +
> +    if (!SUCCEEDED(IShellLinkW_QueryInterface(shelllink, &IID_IPersistFile, (LPVOID*)&persistfile)))
> In these failure cases, it's probably possible to write some tests to see what `HRESULT` should be returned.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121808