[PATCH 0/1] MR404: tests: Use the same viewport origin and front-face orientation in the Vulkan and D3D runners.

[Henri Verbeet (＠hverbeet)]

I.e., top-left origin, and clockwise front-facing. These end up cancelling
each other out when drawing full-screen quads, but that's not necessarily true
for other geometry.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/404

[PATCH 1/1] tests: Use the same viewport origin and front-face orientation in the Vulkan and D3D runners.

[Henri Verbeet]

From: Henri Verbeet <hverbeet(a)codeweavers.com>

I.e., top-left origin, and clockwise front-facing. These end up cancelling
each other out when drawing full-screen quads, but that's not necessarily true
for other geometry.
---
 tests/shader_runner_vulkan.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/shader_runner_vulkan.c b/tests/shader_runner_vulkan.c
index ebb15eba9..f89b4d624 100644
--- a/tests/shader_runner_vulkan.c
+++ b/tests/shader_runner_vulkan.c
@@ -599,7 +599,8 @@ static VkPipeline create_graphics_pipeline(const struct vulkan_shader_runner *ru
     VkPipelineVertexInputStateCreateInfo input_desc = {.sType = VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO};
     VkPipelineColorBlendStateCreateInfo blend_desc = {.sType = VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO};
     VkPipelineMultisampleStateCreateInfo ms_desc = {.sType = VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO};
-    static const VkViewport viewport = {.width = RENDER_TARGET_WIDTH, .height = RENDER_TARGET_HEIGHT, .maxDepth = 1};
+    static const VkViewport viewport = {.y = RENDER_TARGET_HEIGHT,
+            .width = RENDER_TARGET_WIDTH, .height = -RENDER_TARGET_HEIGHT, .maxDepth = 1};
     VkPipelineViewportStateCreateInfo vp_desc = {.sType = VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO};
     static const VkRect2D rt_rect = {.extent.width = RENDER_TARGET_WIDTH, .extent.height = RENDER_TARGET_HEIGHT};
     VkGraphicsPipelineCreateInfo pipeline_desc = {.sType = VK_STRUCTURE_TYPE_GRAPHICS_PIPELINE_CREATE_INFO};
@@ -699,6 +700,7 @@ static VkPipeline create_graphics_pipeline(const struct vulkan_shader_runner *ru
     vp_desc.pScissors = &rt_rect;
 
     rs_desc.cullMode = VK_CULL_MODE_NONE;
+    rs_desc.frontFace = VK_FRONT_FACE_CLOCKWISE;
     rs_desc.lineWidth = 1.0f;
 
     ms_desc.rasterizationSamples = VK_SAMPLE_COUNT_1_BIT;
@@ -1190,6 +1192,7 @@ static bool get_graphics_queue_index(const struct vulkan_shader_runner *runner,
 static const char *const required_device_extensions[] =
 {
     VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME,
+    VK_KHR_MAINTENANCE1_EXTENSION_NAME,
 };
 
 static bool has_extension(const VkExtensionProperties *extensions, uint32_t count, const char *extension_name)
-- 
GitLab

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/404

[PATCH 0/1] MR404: tests: Use the same viewport origin and front-face orientation in the Vulkan and D3D runners. - approved

[Giovanni Mascellani (＠giomasce)]

This merge request was approved by Giovanni Mascellani.
-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/404

[PATCH 0/1] MR404: tests: Use the same viewport origin and front-face orientation in the Vulkan and D3D runners. - approved

[Henri Verbeet (＠hverbeet)]

This merge request was approved by Henri Verbeet.
-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/404