Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
May 19, 2026
8:09 a.m.
Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c:
for (k = 0; k < backtrack_count; ++k) { + unsigned int j; offset = GET_BE_WORD(backtrack->Coverage[k]); - if (GSUB_is_glyph_covered((const BYTE *)backtrack + offset, - glyphs[glyph_index + (dirBacktrack * (k + 1))]) == -1) + j = glyph_index + (dirBacktrack * (k + 1));
Could we come up with a better name than `j` (especially as it's in a loop over `k`)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140531
31
Age (days ago)
31
Last active (days ago)
0 comments
1 participants
participants (1)
-
Huw Davies (@huw)