June 2015 - Wine-devel - list.winehq.org

Re: odbccp32: Add a trace message to functions
by Nikolay Sivov 05 Jun '15

05 Jun '15

> @@ -281,7 +281,7 @@ BOOL WINAPI SQLGetAvailableDriversW(LPCWSTR lpszInfFile, LPWSTR lpszBuf, > WORD cbBufMax, WORD *pcbBufOut) > { > clear_errors(); > - FIXME("\n"); > + FIXME("%s %s %d %p\n", debugstr_w(lpszInfFile), debugstr_w(lpszBuf), cbBufMax, pcbBufOut); This is wrong, because lpszBuf is out parameter. > @@ -370,6 +374,9 @@ BOOL WINAPI SQLGetInstalledDrivers(LPSTR lpszBuf, WORD cbBufMax, > int size_wbuf = cbBufMax; > LPWSTR wbuf; > WORD size_used; > + > + TRACE("%s %d %p\n", debugstr_a(lpszBuf), cbBufMax, pcbBufOut); > + Same here. > @@ -397,7 +404,9 @@ int WINAPI SQLGetPrivateProfileStringW(LPCWSTR lpszSection, LPCWSTR lpszEntry, > LPCWSTR lpszFilename) > { > clear_errors(); > - FIXME("\n"); > + FIXME("%s %s %s %p %d %s\n", debugstr_w(lpszSection), debugstr_w(lpszEntry), > + debugstr_w(lpszDefault), RetBuffer, cbRetBuffer, > + debugstr_w(lpszFilename)); > SetLastError(ERROR_CALL_NOT_IMPLEMENTED); And here.

1 0

Wine 64 bit
by Kevin Davies 05 Jun '15

05 Jun '15

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

13 31

Re: [PATCH 2/5] d3d9/tests: Add more tests for point size. (v3)
by Marvin 04 Jun '15

04 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13876 Your paranoid android. === w8 (32 bit visual) === visual.c:10525: Test failed: Got unexpected color 0x00ff0000 (case 5, 3, size 0). visual.c:10525: Test failed: Got unexpected color 0x00ff0000 (case 7, 3, size 0). visual.c:10525: Test failed: Got unexpected color 0x00ff0000 (case 9, 3, size 0).

1 0

CSMT status?
by Forest 04 Jun '15

04 Jun '15

Can anyone offer a status update on D3D command stream multithreading? I've been packaging Stefan Dösinger's CSMT work, with over 500 people using my last release, and several asking when I'll build a new one. I don't know what to tell them, because his github repo hasn't been updated in half a year, and he hasn't responded to the email I sent him last week. It's starting to look like this excellent work has been abandoned. Pherhaps I missed an announcement? Has it already been integrated into mainline wine? Is there some other plan for it?

4 3

Re: inetcpl.cpl: implement default page button
by Andrew Eikum 04 Jun '15

04 Jun '15

Hi Jared, On Wed, Jun 03, 2015 at 08:29:03AM -0500, Jared Smudde wrote: > @@ -186,6 +186,10 @@ static INT_PTR general_on_command(HWND hwnd, WPARAM wparam) > case MAKEWPARAM(IDC_HOME_BLANK, BN_CLICKED): > SetDlgItemTextW(hwnd, IDC_HOME_EDIT, about_blank); > break; > + > + case MAKEWPARAM(IDC_HOME_DEFAULT, BN_CLICKED): This file is indented with spaces. Please don't introduce tabs or use whitespace at the end of a line. Thanks! Andrew

1 0

programs/regsvr32 patches
by Hugh McMaster 04 Jun '15

04 Jun '15

Excuse me, I've looked through patches 111564-111568 and have only found one minor issue. In patch 111565 I forgot to include ctype.h for tolower(). Was there a problem with the input comparison handling, or something else? The changes to the input handling make conversion to unicode much easier and cleaner. I realise that patch 111565 looks complex, but it's just the indenting. -- Hugh McMaster

1 1

Re: [PATCH] riched20: Fix link notification conditions and add tests.
by Nikolay Sivov 04 Jun '15

04 Jun '15

On 04.06.2015 9:34, Alex Henrie wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35949 > --- > dlls/riched20/editor.c | 13 +++- > dlls/riched20/tests/editor.c | 178 +++++++++++++++++++++++++++++++++++++++---- > 2 files changed, 172 insertions(+), 19 deletions(-) > Looks good to me.

1 0

Re: ntdll/tests: Properly mark test failures with todo_wine.
by Alexandre Julliard 04 Jun '15

04 Jun '15

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -353,14 +353,18 @@ static void test_NtQueryDirectoryFile_case(void) > mask.Length = mask.MaximumLength = lstrlenW(testmask) * sizeof(WCHAR); > pNtQueryDirectoryFile(dirh, NULL, NULL, NULL, &io, data, data_size, > FileBothDirectoryInformation, TRUE, &mask, FALSE); > + todo_wine > ok(U(io).Status == STATUS_SUCCESS, "failed to query directory; status %x\n", U(io).Status); > data_len = io.Information; > + todo_wine > ok(data_len >= sizeof(FILE_BOTH_DIRECTORY_INFORMATION), "not enough data in directory\n"); > > name = dir_info->FileName; > name_len = dir_info->FileNameLength / sizeof(WCHAR); > > + todo_wine > ok(name_len == testfile_len, "unexpected filename length %u\n", name_len); > + todo_wine I don't see any failure here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: TestBot job 13726 results: [PATCH 2/2] d3d9/test: implemented tests for UpdateTexture method
by Sergey Isakov 04 Jun '15

04 Jun '15

It may mean that Win8 contains a bug. Use Windows Update. On 01 июня 2015 г., at 3:05, Marvin <testbot(a)winehq.org> wrote: > VM Status Number of test failures > build completed > w2000pro completed 0 > wxppro completed 0 > w2003std completed 0 > wvistau64 completed 0 > w2008s64 completed 0 > w7u completed 0 > w8 completed 3 > wvistau64 completed 0 > w2008s64 completed 0 > > === build (build) === > No build failures found > > === w2000pro (32 bit visual) === > No test failures found > > === wxppro (32 bit visual) === > No test failures found > > === w2003std (32 bit visual) === > No test failures found > > === wvistau64 (32 bit visual) === > No test failures found > > === w2008s64 (32 bit visual) === > No test failures found > > === w7u (32 bit visual) === > No test failures found > > === w8 (32 bit visual) === > > d3d9: > visual.c:18560: Test failed: Unexpected result on update texture, hr 0, should fail, case 0, 8. > visual.c:18560: Test failed: Unexpected result on update texture, hr 0, should fail, case 1, 8. > visual.c:18560: Test failed: Unexpected result on update texture, hr 0, should fail, case 2, 8. > > === wvistau64 (64 bit visual) === > No test failures found > > === w2008s64 (64 bit visual) === > No test failures found<build.log><w2000pro.log><wxppro.log><w2003std.log><wvistau64.log><w2008s64.log><w7u.log><w8.log><wvistau64.log><w2008s64.log>

1 0

Re: wbemprox: Treat \r as whitespace.
by Marvin 03 Jun '15

03 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13841 Your paranoid android. === wvistau64 (64 bit query) === The test timed out

2 1