January 2010 - Wine-commits

Justin Chevrier : user32: EnumDisplayDevicesW, populate DeviceID member.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: 64f2c03457bade771664293285840d57a5466bfc URL: http://source.winehq.org/git/wine.git/?a=commit;h=64f2c03457bade77166429328… Author: Justin Chevrier <jchevrier(a)gmail.com> Date: Sun Jan 24 02:07:09 2010 -0500 user32: EnumDisplayDevicesW, populate DeviceID member. --- dlls/user32/misc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c index ca807f0..d5a23d1 100644 --- a/dlls/user32/misc.c +++ b/dlls/user32/misc.c @@ -277,6 +277,8 @@ DWORD WINAPI SetLogonNotifyWindow(HWINSTA hwinsta,HWND hwnd) static const WCHAR primary_device_name[] = {'\\','\\','.','\\','D','I','S','P','L','A','Y','1',0}; static const WCHAR primary_device_string[] = {'X','1','1',' ','W','i','n','d','o','w','i','n','g',' ', 'S','y','s','t','e','m',0}; +static const WCHAR primary_device_deviceid[] = {'P','C','I','\\','V','E','N','_','0','0','0','0','&', + 'D','E','V','_','0','0','0','0',0}; /*********************************************************************** * EnumDisplayDevicesA (USER32.@) @@ -331,7 +333,7 @@ BOOL WINAPI EnumDisplayDevicesW( LPCWSTR lpDevice, DWORD i, LPDISPLAY_DEVICEW lp DISPLAY_DEVICE_VGA_COMPATIBLE; if(lpDisplayDevice->cb >= offsetof(DISPLAY_DEVICEW, DeviceID) + sizeof(lpDisplayDevice->DeviceID)) - lpDisplayDevice->DeviceID[0] = 0; + memcpy(lpDisplayDevice->DeviceID, primary_device_deviceid, sizeof(primary_device_deviceid)); if(lpDisplayDevice->cb >= offsetof(DISPLAY_DEVICEW, DeviceKey) + sizeof(lpDisplayDevice->DeviceKey)) lpDisplayDevice->DeviceKey[0] = 0;

1 0

André Hentschel : kernel32/tests: Run fiber tests on more platforms.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: ffae80a39c77f190be6e11e8507180ae01c4f741 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ffae80a39c77f190be6e11e85… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jan 24 16:29:30 2010 +0100 kernel32/tests: Run fiber tests on more platforms. --- dlls/kernel32/tests/fiber.c | 36 +++++++++++++++++++++++++----------- 1 files changed, 25 insertions(+), 11 deletions(-) diff --git a/dlls/kernel32/tests/fiber.c b/dlls/kernel32/tests/fiber.c index 34bc0c3..30c4a5e 100644 --- a/dlls/kernel32/tests/fiber.c +++ b/dlls/kernel32/tests/fiber.c @@ -27,39 +27,51 @@ static void (WINAPI *pSwitchToFiber)(LPVOID); static void (WINAPI *pDeleteFiber)(LPVOID); static LPVOID fibers[2]; -static BYTE testparam = 187; +static BYTE testparam = 185; -static BOOL init_funcs(void) +static VOID init_funcs(void) { HMODULE hKernel32 = GetModuleHandle("kernel32"); -#define X(f) if (!(p##f = (void*)GetProcAddress(hKernel32, #f))) return FALSE; +#define X(f) p##f = (void*)GetProcAddress(hKernel32, #f); X(CreateFiber); X(ConvertThreadToFiber); X(ConvertFiberToThread); X(SwitchToFiber); X(DeleteFiber); #undef X - - return TRUE; } static VOID WINAPI FiberMainProc(LPVOID lpFiberParameter) { BYTE *tparam = (BYTE *)lpFiberParameter; - ok(*tparam == 187, "Parameterdata expected not to be changed\n"); + ok(*tparam == 185, "Parameterdata expected not to be changed\n"); pSwitchToFiber(fibers[0]); } static void test_ConvertThreadToFiber(void) { - fibers[0] = pConvertThreadToFiber(&testparam); - ok(fibers[0] != 0, "ConvertThreadToFiber failed with error %d\n", GetLastError()); + if (pConvertThreadToFiber) + { + fibers[0] = pConvertThreadToFiber(&testparam); + ok(fibers[0] != 0, "ConvertThreadToFiber failed with error %d\n", GetLastError()); + } + else + { + win_skip( "ConvertThreadToFiber not present\n" ); + } } static void test_ConvertFiberToThread(void) { - ok(pConvertFiberToThread() , "ConvertThreadToFiber failed with error %d\n", GetLastError()); + if (pConvertFiberToThread) + { + ok(pConvertFiberToThread() , "ConvertFiberToThread failed with error %d\n", GetLastError()); + } + else + { + win_skip( "ConvertFiberToThread not present\n" ); + } } static void test_CreateFiber(void) @@ -73,9 +85,11 @@ static void test_CreateFiber(void) START_TEST(fiber) { - if (!init_funcs()) + init_funcs(); + + if (!pCreateFiber) { - win_skip("Needed functions are not available\n"); + win_skip( "Fibers not supported by win95\n" ); return; }

1 0

André Hentschel : kernel32/tests: Test fiber Ex functions.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: f57dbecda835bfb78bbf82014ec4015f8c8208f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f57dbecda835bfb78bbf82014… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jan 24 16:30:16 2010 +0100 kernel32/tests: Test fiber Ex functions. --- dlls/kernel32/tests/fiber.c | 48 ++++++++++++++++++++++++++++++++++++++---- 1 files changed, 43 insertions(+), 5 deletions(-) diff --git a/dlls/kernel32/tests/fiber.c b/dlls/kernel32/tests/fiber.c index 30c4a5e..85db0b0 100644 --- a/dlls/kernel32/tests/fiber.c +++ b/dlls/kernel32/tests/fiber.c @@ -25,6 +25,8 @@ static LPVOID (WINAPI *pConvertThreadToFiber)(LPVOID); static BOOL (WINAPI *pConvertFiberToThread)(void); static void (WINAPI *pSwitchToFiber)(LPVOID); static void (WINAPI *pDeleteFiber)(LPVOID); +static LPVOID (WINAPI *pConvertThreadToFiberEx)(LPVOID,DWORD); +static LPVOID (WINAPI *pCreateFiberEx)(SIZE_T,SIZE_T,DWORD,LPFIBER_START_ROUTINE,LPVOID); static LPVOID fibers[2]; static BYTE testparam = 185; @@ -39,6 +41,8 @@ static VOID init_funcs(void) X(ConvertFiberToThread); X(SwitchToFiber); X(DeleteFiber); + X(ConvertThreadToFiberEx); + X(CreateFiberEx); #undef X } @@ -62,6 +66,19 @@ static void test_ConvertThreadToFiber(void) } } +static void test_ConvertThreadToFiberEx(void) +{ + if (pConvertThreadToFiberEx) + { + fibers[0] = pConvertThreadToFiberEx(&testparam, 0); + ok(fibers[0] != 0, "ConvertThreadToFiberEx failed with error %d\n", GetLastError()); + } + else + { + win_skip( "ConvertThreadToFiberEx not present\n" ); + } +} + static void test_ConvertFiberToThread(void) { if (pConvertFiberToThread) @@ -74,13 +91,37 @@ static void test_ConvertFiberToThread(void) } } -static void test_CreateFiber(void) +static void test_FiberHandling(void) { + fibers[0] = pCreateFiber(0,FiberMainProc,&testparam); + ok(fibers[0] != 0, "CreateFiber failed with error %d\n", GetLastError()); + pDeleteFiber(fibers[0]); + + test_ConvertThreadToFiber(); + test_ConvertFiberToThread(); + if (pConvertThreadToFiberEx) + test_ConvertThreadToFiberEx(); + else + test_ConvertThreadToFiber(); + + fibers[1] = pCreateFiber(0,FiberMainProc,&testparam); ok(fibers[1] != 0, "CreateFiber failed with error %d\n", GetLastError()); pSwitchToFiber(fibers[1]); pDeleteFiber(fibers[1]); + + if (!pCreateFiberEx) + { + win_skip( "CreateFiberEx not present\n" ); + return; + } + + fibers[1] = pCreateFiberEx(0,0,0,FiberMainProc,&testparam); + ok(fibers[1] != 0, "CreateFiberEx failed with error %d\n", GetLastError()); + + pSwitchToFiber(fibers[1]); + pDeleteFiber(fibers[1]); } START_TEST(fiber) @@ -93,8 +134,5 @@ START_TEST(fiber) return; } - test_ConvertThreadToFiber(); - test_ConvertFiberToThread(); - test_ConvertThreadToFiber(); - test_CreateFiber(); + test_FiberHandling(); }

1 0

André Hentschel : kernel32/tests: Test IsThreadAFiber function.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: e0475a3e11d92f83a52c7509dec54bb848d7d238 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e0475a3e11d92f83a52c7509d… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jan 24 16:30:36 2010 +0100 kernel32/tests: Test IsThreadAFiber function. --- dlls/kernel32/tests/fiber.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/fiber.c b/dlls/kernel32/tests/fiber.c index 85db0b0..20f6ccc 100644 --- a/dlls/kernel32/tests/fiber.c +++ b/dlls/kernel32/tests/fiber.c @@ -27,6 +27,7 @@ static void (WINAPI *pSwitchToFiber)(LPVOID); static void (WINAPI *pDeleteFiber)(LPVOID); static LPVOID (WINAPI *pConvertThreadToFiberEx)(LPVOID,DWORD); static LPVOID (WINAPI *pCreateFiberEx)(SIZE_T,SIZE_T,DWORD,LPFIBER_START_ROUTINE,LPVOID); +static BOOL (WINAPI *pIsThreadAFiber)(void); static LPVOID fibers[2]; static BYTE testparam = 185; @@ -43,6 +44,7 @@ static VOID init_funcs(void) X(DeleteFiber); X(ConvertThreadToFiberEx); X(CreateFiberEx); + X(IsThreadAFiber); #undef X } @@ -122,6 +124,16 @@ static void test_FiberHandling(void) pSwitchToFiber(fibers[1]); pDeleteFiber(fibers[1]); + + if (!pIsThreadAFiber) + { + skip( "IsThreadAFiber not present\n" ); + return; + } + + ok(pIsThreadAFiber(), "IsThreadAFiber reported FALSE\n"); + test_ConvertFiberToThread(); + ok(!pIsThreadAFiber(), "IsThreadAFiber reported TRUE\n"); } START_TEST(fiber)

1 0

André Hentschel : kernel32/tests: Test Fiber Local Storage functions.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: 30deb6b896231b214eb1a8e06da1e80ef2a70b75 URL: http://source.winehq.org/git/wine.git/?a=commit;h=30deb6b896231b214eb1a8e06… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jan 24 16:30:49 2010 +0100 kernel32/tests: Test Fiber Local Storage functions. --- dlls/kernel32/tests/fiber.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/fiber.c b/dlls/kernel32/tests/fiber.c index 20f6ccc..9a26e4d 100644 --- a/dlls/kernel32/tests/fiber.c +++ b/dlls/kernel32/tests/fiber.c @@ -28,6 +28,10 @@ static void (WINAPI *pDeleteFiber)(LPVOID); static LPVOID (WINAPI *pConvertThreadToFiberEx)(LPVOID,DWORD); static LPVOID (WINAPI *pCreateFiberEx)(SIZE_T,SIZE_T,DWORD,LPFIBER_START_ROUTINE,LPVOID); static BOOL (WINAPI *pIsThreadAFiber)(void); +static DWORD (WINAPI *pFlsAlloc)(PFLS_CALLBACK_FUNCTION); +static BOOL (WINAPI *pFlsFree)(DWORD); +static PVOID (WINAPI *pFlsGetValue)(DWORD); +static BOOL (WINAPI *pFlsSetValue)(DWORD,PVOID); static LPVOID fibers[2]; static BYTE testparam = 185; @@ -45,9 +49,18 @@ static VOID init_funcs(void) X(ConvertThreadToFiberEx); X(CreateFiberEx); X(IsThreadAFiber); + X(FlsAlloc); + X(FlsFree); + X(FlsGetValue); + X(FlsSetValue); #undef X } +static VOID WINAPI FiberLocalStorageProc(PVOID lpFlsData) +{ + ok(lpFlsData == (PVOID) 1587, "FlsData expected not to be changed\n"); +} + static VOID WINAPI FiberMainProc(LPVOID lpFiberParameter) { BYTE *tparam = (BYTE *)lpFiberParameter; @@ -136,6 +149,29 @@ static void test_FiberHandling(void) ok(!pIsThreadAFiber(), "IsThreadAFiber reported TRUE\n"); } +static void test_FiberLocalStorage(PFLS_CALLBACK_FUNCTION cbfunc) +{ + DWORD fls; + BOOL ret; + PVOID val = (PVOID) 1587; + + if (!pFlsAlloc) + { + win_skip( "Fiber Local Storage not supported\n" ); + return; + } + + fls = pFlsAlloc(cbfunc); + ok(fls != FLS_OUT_OF_INDEXES, "FlsAlloc failed with error %d\n", GetLastError()); + + ret = pFlsSetValue(fls, val); + ok(ret, "FlsSetValue failed\n"); + ok(val == pFlsGetValue(fls), "FlsGetValue failed\n"); + + ret = pFlsFree(fls); + ok(ret, "FlsFree failed\n"); +} + START_TEST(fiber) { init_funcs(); @@ -147,4 +183,6 @@ START_TEST(fiber) } test_FiberHandling(); + test_FiberLocalStorage(NULL); + test_FiberLocalStorage(FiberLocalStorageProc); }

1 0

André Hentschel : kernel32/tests: Test Fiber callback count.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: a9353a1caf8a783ff69881dbac4a3887ca58966f URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9353a1caf8a783ff69881dba… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jan 24 16:31:02 2010 +0100 kernel32/tests: Test Fiber callback count. --- dlls/kernel32/tests/fiber.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/fiber.c b/dlls/kernel32/tests/fiber.c index 9a26e4d..7009a03 100644 --- a/dlls/kernel32/tests/fiber.c +++ b/dlls/kernel32/tests/fiber.c @@ -35,6 +35,7 @@ static BOOL (WINAPI *pFlsSetValue)(DWORD,PVOID); static LPVOID fibers[2]; static BYTE testparam = 185; +static WORD cbCount; static VOID init_funcs(void) { @@ -58,12 +59,14 @@ static VOID init_funcs(void) static VOID WINAPI FiberLocalStorageProc(PVOID lpFlsData) { + cbCount++; ok(lpFlsData == (PVOID) 1587, "FlsData expected not to be changed\n"); } static VOID WINAPI FiberMainProc(LPVOID lpFiberParameter) { BYTE *tparam = (BYTE *)lpFiberParameter; + cbCount++; ok(*tparam == 185, "Parameterdata expected not to be changed\n"); pSwitchToFiber(fibers[0]); } @@ -108,6 +111,7 @@ static void test_ConvertFiberToThread(void) static void test_FiberHandling(void) { + cbCount = 0; fibers[0] = pCreateFiber(0,FiberMainProc,&testparam); ok(fibers[0] != 0, "CreateFiber failed with error %d\n", GetLastError()); pDeleteFiber(fibers[0]); @@ -124,6 +128,7 @@ static void test_FiberHandling(void) ok(fibers[1] != 0, "CreateFiber failed with error %d\n", GetLastError()); pSwitchToFiber(fibers[1]); + ok(cbCount == 1, "Wrong callback count: %d\n", cbCount); pDeleteFiber(fibers[1]); if (!pCreateFiberEx) @@ -136,6 +141,7 @@ static void test_FiberHandling(void) ok(fibers[1] != 0, "CreateFiberEx failed with error %d\n", GetLastError()); pSwitchToFiber(fibers[1]); + ok(cbCount == 2, "Wrong callback count: %d\n", cbCount); pDeleteFiber(fibers[1]); if (!pIsThreadAFiber) @@ -160,6 +166,7 @@ static void test_FiberLocalStorage(PFLS_CALLBACK_FUNCTION cbfunc) win_skip( "Fiber Local Storage not supported\n" ); return; } + cbCount = 0; fls = pFlsAlloc(cbfunc); ok(fls != FLS_OUT_OF_INDEXES, "FlsAlloc failed with error %d\n", GetLastError()); @@ -170,6 +177,8 @@ static void test_FiberLocalStorage(PFLS_CALLBACK_FUNCTION cbfunc) ret = pFlsFree(fls); ok(ret, "FlsFree failed\n"); + if (cbfunc) + todo_wine ok(cbCount == 1, "Wrong callback count: %d\n", cbCount); } START_TEST(fiber)

1 0

André Hentschel : kernel32: Implement IsThreadAFiber function.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: c008984a01e43401159cfd08bea32851a8130212 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c008984a01e43401159cfd08b… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jan 24 16:31:19 2010 +0100 kernel32: Implement IsThreadAFiber function. --- dlls/kernel32/fiber.c | 8 ++++++++ dlls/kernel32/kernel32.spec | 1 + dlls/kernel32/tests/fiber.c | 2 +- 3 files changed, 10 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/fiber.c b/dlls/kernel32/fiber.c index f828cdc..c866661 100644 --- a/dlls/kernel32/fiber.c +++ b/dlls/kernel32/fiber.c @@ -304,3 +304,11 @@ BOOL WINAPI FlsSetValue( DWORD index, PVOID data ) NtCurrentTeb()->FlsSlots[index] = data; return TRUE; } + +/*********************************************************************** + * IsThreadAFiber (KERNEL32.@) + */ +BOOL WINAPI IsThreadAFiber(void) +{ + return NtCurrentTeb()->Tib.u.FiberData != NULL; +} diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 3b772ba..db9713f 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -749,6 +749,7 @@ @ stdcall IsProcessorFeaturePresent(long) @ stub -i386 IsSLCallback @ stdcall IsSystemResumeAutomatic() +@ stdcall IsThreadAFiber() @ stdcall IsValidCodePage(long) @ stdcall IsValidLanguageGroup(long long) @ stdcall IsValidLocale(long long) diff --git a/dlls/kernel32/tests/fiber.c b/dlls/kernel32/tests/fiber.c index 7009a03..dac9d6a 100644 --- a/dlls/kernel32/tests/fiber.c +++ b/dlls/kernel32/tests/fiber.c @@ -146,7 +146,7 @@ static void test_FiberHandling(void) if (!pIsThreadAFiber) { - skip( "IsThreadAFiber not present\n" ); + win_skip( "IsThreadAFiber not present\n" ); return; }

1 0

Vincent Povirk : gdiplus: Add traces to unimplemented functions in imageattributes.c.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: 30574dd6be85f1384f45e5c86d5715045e779768 URL: http://source.winehq.org/git/wine.git/?a=commit;h=30574dd6be85f1384f45e5c86… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Dec 18 16:19:34 2009 -0600 gdiplus: Add traces to unimplemented functions in imageattributes.c. --- dlls/gdiplus/imageattributes.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/imageattributes.c b/dlls/gdiplus/imageattributes.c index f74b6db..56e5ab2 100644 --- a/dlls/gdiplus/imageattributes.c +++ b/dlls/gdiplus/imageattributes.c @@ -122,6 +122,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesWrapMode(GpImageAttributes *imageAttr, { static int calls; + TRACE("(%p,%u,%08x,%i)\n", imageAttr, wrap, argb, clamp); + if(!imageAttr) return InvalidParameter; @@ -136,6 +138,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesCachedBackground(GpImageAttributes *im { static int calls; + TRACE("(%p,%i)\n", imageAttr, enableFlag); + if(!(calls++)) FIXME("not implemented\n"); @@ -147,6 +151,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesGamma(GpImageAttributes *imageAttr, { static int calls; + TRACE("(%p,%u,%i,%0.2f)\n", imageAttr, type, enableFlag, gamma); + if(!(calls++)) FIXME("not implemented\n"); @@ -158,6 +164,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesNoOp(GpImageAttributes *imageAttr, { static int calls; + TRACE("(%p,%u,%i)\n", imageAttr, type, enableFlag); + if(!(calls++)) FIXME("not implemented\n"); @@ -169,6 +177,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesOutputChannel(GpImageAttributes *image { static int calls; + TRACE("(%p,%u,%i,%x)\n", imageAttr, type, enableFlag, channelFlags); + if(!(calls++)) FIXME("not implemented\n"); @@ -181,6 +191,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesOutputChannelColorProfile(GpImageAttri { static int calls; + TRACE("(%p,%u,%i,%s)\n", imageAttr, type, enableFlag, debugstr_w(colorProfileFilename)); + if(!(calls++)) FIXME("not implemented\n"); @@ -193,6 +205,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesRemapTable(GpImageAttributes *imageAtt { static int calls; + TRACE("(%p,%u,%i,%u,%p)\n", imageAttr, type, enableFlag, mapSize, map); + if(!(calls++)) FIXME("not implemented\n"); @@ -204,6 +218,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesThreshold(GpImageAttributes *imageAttr { static int calls; + TRACE("(%p,%u,%i,%0.2f)\n", imageAttr, type, enableFlag, threshold); + if(!(calls++)) FIXME("not implemented\n"); @@ -215,6 +231,8 @@ GpStatus WINGDIPAPI GdipSetImageAttributesToIdentity(GpImageAttributes *imageAtt { static int calls; + TRACE("(%p,%u)\n", imageAttr, type); + if(!(calls++)) FIXME("not implemented\n");

1 0

Eric Pouech : dbghelp: For PE modules, when no debug info is present, also try to load symbols out of COFF symbol table.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: 520fcae5d25bda06c275103624387174f78b54a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=520fcae5d25bda06c27510362… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sat Jan 23 22:13:25 2010 +0100 dbghelp: For PE modules, when no debug info is present, also try to load symbols out of COFF symbol table. --- dlls/dbghelp/pe_module.c | 70 +++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 66 insertions(+), 4 deletions(-) diff --git a/dlls/dbghelp/pe_module.c b/dlls/dbghelp/pe_module.c index 80ad561..76d81ee 100644 --- a/dlls/dbghelp/pe_module.c +++ b/dlls/dbghelp/pe_module.c @@ -36,14 +36,14 @@ WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); /****************************************************************** - * pe_load_symbol_table + * pe_locate_with_coff_symbol_table * * Use the COFF symbol table (if any) from the IMAGE_FILE_HEADER to set the absolute address * of global symbols. * Mingw32 requires this for stabs debug information as address for global variables isn't filled in * (this is similar to what is done in elf_module.c when using the .symtab ELF section) */ -static BOOL pe_load_symbol_table(struct module* module, IMAGE_NT_HEADERS* nth, void* mapping) +static BOOL pe_locate_with_coff_symbol_table(struct module* module, IMAGE_NT_HEADERS* nth, void* mapping) { const IMAGE_SYMBOL* isym; int i, numsym, naux; @@ -98,6 +98,67 @@ static BOOL pe_load_symbol_table(struct module* module, IMAGE_NT_HEADERS* nth, v return TRUE; } +/****************************************************************** + * pe_load_coff_symbol_table + * + * Load public symbols out of the COFF symbol table (if any). + */ +static BOOL pe_load_coff_symbol_table(struct module* module, IMAGE_NT_HEADERS* nth, void* mapping) +{ + const IMAGE_SYMBOL* isym; + int i, numsym, naux; + const char* strtable; + char tmp[9]; + const char* name; + const char* lastfilename = NULL; + struct symt_compiland* compiland = NULL; + const IMAGE_SECTION_HEADER* sect; + + numsym = nth->FileHeader.NumberOfSymbols; + if (!nth->FileHeader.PointerToSymbolTable || !numsym) + return TRUE; + isym = (const IMAGE_SYMBOL*)((char*)mapping + nth->FileHeader.PointerToSymbolTable); + /* FIXME: no way to get strtable size */ + strtable = (const char*)&isym[numsym]; + sect = IMAGE_FIRST_SECTION(nth); + + for (i = 0; i < numsym; i+= naux, isym += naux) + { + if (isym->StorageClass == IMAGE_SYM_CLASS_FILE) + { + lastfilename = (const char*)(isym + 1); + compiland = NULL; + } + if (isym->StorageClass == IMAGE_SYM_CLASS_EXTERNAL && + isym->SectionNumber > 0 && isym->SectionNumber <= nth->FileHeader.NumberOfSections) + { + if (isym->N.Name.Short) + { + name = memcpy(tmp, isym->N.ShortName, 8); + tmp[8] = '\0'; + } + else name = strtable + isym->N.Name.Long; + if (name[0] == '_') name++; + + if (!compiland && lastfilename) + compiland = symt_new_compiland(module, 0, + source_new(module, NULL, lastfilename)); + symt_new_public(module, compiland, name, + module->module.BaseOfImage + sect[isym->SectionNumber - 1].VirtualAddress + isym->Value, + 1); + } + naux = isym->NumberOfAuxSymbols + 1; + } + module->module.SymType = SymCoff; + module->module.LineNumbers = FALSE; + module->module.GlobalSymbols = FALSE; + module->module.TypeInfo = FALSE; + module->module.SourceIndexed = FALSE; + module->module.Publics = TRUE; + + return TRUE; +} + static inline void* pe_get_sect(IMAGE_NT_HEADERS* nth, void* mapping, IMAGE_SECTION_HEADER* sect) { @@ -138,7 +199,7 @@ static BOOL pe_load_stabs(const struct process* pcs, struct module* module, pe_get_sect(nth, mapping, sect_stabs), pe_get_sect_size(sect_stabs), pe_get_sect(nth, mapping, sect_stabstr), pe_get_sect_size(sect_stabstr), NULL, NULL); - if (ret) pe_load_symbol_table(module, nth, mapping); + if (ret) pe_locate_with_coff_symbol_table(module, nth, mapping); } TRACE("%s the STABS debug info\n", ret ? "successfully loaded" : "failed to load"); @@ -402,7 +463,8 @@ BOOL pe_load_debug_info(const struct process* pcs, struct module* module) { ret = pe_load_stabs(pcs, module, mapping, nth) || pe_load_dwarf(pcs, module, mapping, nth) || - pe_load_msc_debug_info(pcs, module, mapping, nth); + pe_load_msc_debug_info(pcs, module, mapping, nth) || + pe_load_coff_symbol_table(module, nth, mapping); /* if we still have no debug info (we could only get SymExport at this * point), then do the SymExport except if we have an ELF container, * in which case we'll rely on the export's on the ELF side

1 0

Jacek Caban : jscript: Make RegExp contructor implementation more generic.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Module: wine Branch: master Commit: 7749951d35a2ea752ec7b15d23efb2ca027089ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=7749951d35a2ea752ec7b15d2… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sat Jan 23 23:56:48 2010 +0100 jscript: Make RegExp contructor implementation more generic. --- dlls/jscript/jscript.h | 1 + dlls/jscript/regexp.c | 73 ++++++++++++++++++++++------------------------- 2 files changed, 35 insertions(+), 39 deletions(-) diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index 4dd340e..a839067 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -226,6 +226,7 @@ HRESULT create_object(script_ctx_t*,DispatchEx*,DispatchEx**); HRESULT create_math(script_ctx_t*,DispatchEx**); HRESULT create_array(script_ctx_t*,DWORD,DispatchEx**); HRESULT create_regexp(script_ctx_t*,const WCHAR *,int,DWORD,DispatchEx**); +HRESULT create_regexp_var(script_ctx_t*,VARIANT*,VARIANT*,DispatchEx**); HRESULT create_string(script_ctx_t*,const WCHAR*,DWORD,DispatchEx**); HRESULT create_bool(script_ctx_t*,VARIANT_BOOL,DispatchEx**); HRESULT create_number(script_ctx_t*,VARIANT*,DispatchEx**); diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c index 1034cd0..751fe41 100644 --- a/dlls/jscript/regexp.c +++ b/dlls/jscript/regexp.c @@ -3833,74 +3833,50 @@ HRESULT create_regexp(script_ctx_t *ctx, const WCHAR *exp, int len, DWORD flags, return S_OK; } -static HRESULT regexp_constructor(script_ctx_t *ctx, DISPPARAMS *dp, VARIANT *retv) +HRESULT create_regexp_var(script_ctx_t *ctx, VARIANT *src_arg, VARIANT *flags_arg, DispatchEx **ret) { const WCHAR *opt = emptyW, *src; - DispatchEx *ret; - VARIANT *arg; DWORD flags; HRESULT hres; - if(!arg_cnt(dp)) { - FIXME("no args\n"); - return E_NOTIMPL; - } - - arg = get_arg(dp,0); - if(V_VT(arg) == VT_DISPATCH) { + if(V_VT(src_arg) == VT_DISPATCH) { DispatchEx *obj; - obj = iface_to_jsdisp((IUnknown*)V_DISPATCH(arg)); + obj = iface_to_jsdisp((IUnknown*)V_DISPATCH(src_arg)); if(obj) { if(is_class(obj, JSCLASS_REGEXP)) { RegExpInstance *regexp = (RegExpInstance*)obj; - hres = create_regexp(ctx, regexp->str, -1, regexp->jsregexp->flags, &ret); + hres = create_regexp(ctx, regexp->str, -1, regexp->jsregexp->flags, ret); jsdisp_release(obj); - if(FAILED(hres)) - return hres; - - V_VT(retv) = VT_DISPATCH; - V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(ret); - return S_OK; + return hres; } jsdisp_release(obj); } } - if(V_VT(arg) != VT_BSTR) { - FIXME("vt arg0 = %d\n", V_VT(arg)); + if(V_VT(src_arg) != VT_BSTR) { + FIXME("flags_arg = %s\n", debugstr_variant(flags_arg)); return E_NOTIMPL; } - src = V_BSTR(arg); + src = V_BSTR(src_arg); - if(arg_cnt(dp) >= 2) { - arg = get_arg(dp,1); - if(V_VT(arg) != VT_BSTR) { - FIXME("unimplemented for vt %d\n", V_VT(arg)); + if(flags_arg) { + if(V_VT(flags_arg) != VT_BSTR) { + FIXME("unimplemented for vt %d\n", V_VT(flags_arg)); return E_NOTIMPL; } - opt = V_BSTR(arg); + opt = V_BSTR(flags_arg); } hres = parse_regexp_flags(opt, strlenW(opt), &flags); if(FAILED(hres)) return hres; - hres = create_regexp(ctx, src, -1, flags, &ret); - if(FAILED(hres)) - return hres; - - if(retv) { - V_VT(retv) = VT_DISPATCH; - V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(ret); - }else { - jsdisp_release(ret); - } - return S_OK; + return create_regexp(ctx, src, -1, flags, ret); } static HRESULT RegExpConstr_value(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, DISPPARAMS *dp, @@ -3934,8 +3910,27 @@ static HRESULT RegExpConstr_value(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags } } /* fall through */ - case DISPATCH_CONSTRUCT: - return regexp_constructor(ctx, dp, retv); + case DISPATCH_CONSTRUCT: { + DispatchEx *ret; + HRESULT hres; + + if(!arg_cnt(dp)) { + FIXME("no args\n"); + return E_NOTIMPL; + } + + hres = create_regexp_var(ctx, get_arg(dp,0), arg_cnt(dp) > 1 ? get_arg(dp,1) : NULL, &ret); + if(FAILED(hres)) + return hres; + + if(retv) { + V_VT(retv) = VT_DISPATCH; + V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(ret); + }else { + jsdisp_release(ret); + } + return S_OK; + } default: FIXME("unimplemented flags: %x\n", flags); return E_NOTIMPL;

1 0