March 2016 - Wine-commits - list.winehq.org

Sebastian Lackner : services: Get rid of unnecessary locks.
by Alexandre Julliard 02 Mar '16

02 Mar '16

Module: wine Branch: master Commit: 4931f5fbe9b46de86aa9a0c2709b60659fc622fb URL: http://source.winehq.org/git/wine.git/?a=commit;h=4931f5fbe9b46de86aa9a0c27… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Mar 2 07:21:51 2016 +0100 services: Get rid of unnecessary locks. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/services/rpc.c | 6 ------ programs/services/services.c | 2 -- 2 files changed, 8 deletions(-) diff --git a/programs/services/rpc.c b/programs/services/rpc.c index d9379c4..aad3b22 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -274,7 +274,6 @@ DWORD __cdecl svcctl_GetServiceDisplayNameW( { LPCWSTR name; int len; - service_lock(entry); name = get_display_name(entry); len = strlenW(name); if (len <= *cchBufSize) @@ -285,7 +284,6 @@ DWORD __cdecl svcctl_GetServiceDisplayNameW( else err = ERROR_INSUFFICIENT_BUFFER; *cchBufSize = len; - service_unlock(entry); } else err = ERROR_SERVICE_DOES_NOT_EXIST; @@ -319,7 +317,6 @@ DWORD __cdecl svcctl_GetServiceKeyNameW( if (entry != NULL) { int len; - service_lock(entry); len = strlenW(entry->name); if (len <= *cchBufSize) { @@ -329,7 +326,6 @@ DWORD __cdecl svcctl_GetServiceKeyNameW( else err = ERROR_INSUFFICIENT_BUFFER; *cchBufSize = len; - service_unlock(entry); } else err = ERROR_SERVICE_DOES_NOT_EXIST; @@ -539,9 +535,7 @@ static DWORD create_serviceW( if ((found = scmdatabase_find_service(manager->db, lpServiceName))) { - service_lock(found); err = is_marked_for_delete(found) ? ERROR_SERVICE_MARKED_FOR_DELETE : ERROR_SERVICE_EXISTS; - service_unlock(found); scmdatabase_unlock(manager->db); free_service_entry(entry); return err; diff --git a/programs/services/services.c b/programs/services/services.c index 1972cce..c45aed3 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -435,9 +435,7 @@ void release_service(struct service_entry *service) if (InterlockedDecrement(&service->ref_count) == 0 && is_marked_for_delete(service)) { scmdatabase_lock(service->db); - service_lock(service); scmdatabase_remove_service(service->db, service); - service_unlock(service); scmdatabase_unlock(service->db); free_service_entry(service); }

1 0

Sebastian Lackner : services: Fix calculation of service timeout.
by Alexandre Julliard 02 Mar '16

02 Mar '16

Module: wine Branch: master Commit: 6780c20342d3c332947594fdb4c26c2fa867be6c URL: http://source.winehq.org/git/wine.git/?a=commit;h=6780c20342d3c332947594fdb… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Mar 2 07:24:22 2016 +0100 services: Fix calculation of service timeout. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/services/rpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/services/rpc.c b/programs/services/rpc.c index aad3b22..6951fb8 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -121,7 +121,7 @@ static void run_after_timeout(void (*func)(struct service_entry*), struct servic GetSystemTimeAsFileTime(&elem->time); time.u.LowPart = elem->time.dwLowDateTime; time.u.HighPart = elem->time.dwHighDateTime; - time.QuadPart += timeout*10000000; + time.QuadPart += (ULONGLONG)timeout * 10000; elem->time.dwLowDateTime = time.u.LowPart; elem->time.dwHighDateTime = time.u.HighPart;

1 0

Józef Kucia : d3d10core/tests: Introduce check_texture_color().
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 3ab957d19c2208c001c26e8b18d53c1bcdfe9264 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3ab957d19c2208c001c26e8b1… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Feb 29 18:35:51 2016 +0100 d3d10core/tests: Introduce check_texture_color(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 71 ++++++++++++++++++++++--------------------- 1 file changed, 37 insertions(+), 34 deletions(-) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index 8a3fbc7..11f9c73 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -89,6 +89,7 @@ struct texture_readback { ID3D10Texture2D *texture; D3D10_MAPPED_TEXTURE2D mapped_texture; + unsigned int width, height; }; static void get_texture_readback(ID3D10Texture2D *texture, struct texture_readback *rb) @@ -113,6 +114,9 @@ static void get_texture_readback(ID3D10Texture2D *texture, struct texture_readba return; } + rb->width = texture_desc.Width; + rb->height = texture_desc.Height; + ID3D10Device_CopyResource(device, (ID3D10Resource *)rb->texture, (ID3D10Resource *)texture); if (FAILED(hr = ID3D10Texture2D_Map(rb->texture, 0, D3D10_MAP_READ, 0, &rb->mapped_texture))) { @@ -151,6 +155,35 @@ static DWORD get_texture_color(ID3D10Texture2D *texture, unsigned int x, unsigne return color; } +#define check_texture_color(t, c, d) check_texture_color_(__LINE__, t, c, d) +static void check_texture_color_(unsigned int line, ID3D10Texture2D *texture, + DWORD expected_color, BYTE max_diff) +{ + struct texture_readback rb; + unsigned int x = 0, y = 0; + BOOL all_match = TRUE; + DWORD color = 0; + + get_texture_readback(texture, &rb); + for (y = 0; y < rb.height; ++y) + { + for (x = 0; x < rb.width; ++x) + { + color = get_readback_color(&rb, x, y); + if (!compare_color(color, expected_color, max_diff)) + { + all_match = FALSE; + break; + } + } + if (!all_match) + break; + } + release_texture_readback(&rb); + ok_(__FILE__, line)(all_match, + "Got unexpected color 0x%08x at (%u, %u).\n", color, x, y); +} + static ID3D10Device *create_device(void) { ID3D10Device *device; @@ -2103,8 +2136,7 @@ static void test_scissor(void) ID3D10Device_OMSetRenderTargets(device, 1, &rtv, NULL); ID3D10Device_ClearRenderTargetView(device, rtv, red); - color = get_texture_color(backbuffer, 320, 240); - ok(compare_color(color, 0xff0000ff, 1), "Got unexpected color 0x%08x.\n", color); + check_texture_color(backbuffer, 0xff0000ff, 1); ID3D10Device_Draw(device, 4, 0); color = get_texture_color(backbuffer, 320, 60); @@ -4743,19 +4775,10 @@ static void test_update_subresource(void) ID3D10Device_RSSetViewports(device, 1, &vp); ID3D10Device_ClearRenderTargetView(device, backbuffer_rtv, red); + check_texture_color(backbuffer, 0x7f0000ff, 1); ID3D10Device_Draw(device, 4, 0); - get_texture_readback(backbuffer, &rb); - for (i = 0; i < 4; ++i) - { - for (j = 0; j < 4; ++j) - { - color = get_readback_color(&rb, 80 + j * 160, 60 + i * 120); - ok(compare_color(color, 0x00000000, 0), - "Got unexpected color 0x%08x at (%u, %u).\n", color, j, i); - } - } - release_texture_readback(&rb); + check_texture_color(backbuffer, 0x00000000, 0); set_box(&box, 1, 1, 0, 3, 3, 1); ID3D10Device_UpdateSubresource(device, (ID3D10Resource *)texture, 0, &box, @@ -5090,11 +5113,7 @@ static void test_multisample_init(void) ID3D10Texture2D *backbuffer, *multi; ID3D10Device *device; ULONG refcount; - DWORD color; HRESULT hr; - unsigned int x, y; - struct texture_readback rb; - BOOL all_zero = TRUE; UINT count = 0; HWND window; IDXGISwapChain *swapchain; @@ -5141,23 +5160,7 @@ static void test_multisample_init(void) ID3D10Device_ResolveSubresource(device, (ID3D10Resource *)backbuffer, 0, (ID3D10Resource *)multi, 0, DXGI_FORMAT_R8G8B8A8_UNORM); - get_texture_readback(backbuffer, &rb); - for (y = 0; y < 480; ++y) - { - for (x = 0; x < 640; ++x) - { - color = get_readback_color(&rb, x, y); - if (!compare_color(color, 0x00000000, 0)) - { - all_zero = FALSE; - break; - } - } - if (!all_zero) - break; - } - release_texture_readback(&rb); - todo_wine ok(all_zero, "Got unexpected color 0x%08x, position %ux%u.\n", color, x, y); + todo_wine check_texture_color(backbuffer, 0x00000000, 0); ID3D10RenderTargetView_Release(rtview); ID3D10Texture2D_Release(backbuffer);

1 0

Hugh McMaster : advapi32/tests: Fix typos.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 80383dcf3905925a5f1d66a73c3272432c2ef035 URL: http://source.winehq.org/git/wine.git/?a=commit;h=80383dcf3905925a5f1d66a73… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Mar 1 22:23:46 2016 +1100 advapi32/tests: Fix typos. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/tests/registry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 4b3b4e9..5bc129c 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -2205,7 +2205,7 @@ static void test_reg_delete_tree(void) "subkey2 was not deleted\n"); size = MAX_PATH; ok(!RegQueryValueA(subkey, NULL, buffer, &size), - "Default value of subkey not longer present\n"); + "Default value of subkey no longer present\n"); ret = RegCreateKeyA(subkey, "subkey2", &subkey2); ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); @@ -2216,7 +2216,7 @@ static void test_reg_delete_tree(void) ok(RegOpenKeyA(subkey, "subkey2", &subkey2), "subkey2 was not deleted\n"); ok(!RegQueryValueA(subkey, NULL, buffer, &size), - "Default value of subkey not longer present\n"); + "Default value of subkey no longer present\n"); ret = RegCreateKeyA(subkey, "subkey2", &subkey2); ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret);

1 0

Hugh McMaster : advapi32/tests: Add tests for deleting the default value.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 50c5a2ce2e5122d8d00759e0d7926829571a4395 URL: http://source.winehq.org/git/wine.git/?a=commit;h=50c5a2ce2e5122d8d00759e0d… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Mar 1 22:23:47 2016 +1100 advapi32/tests: Add tests for deleting the default value. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/tests/registry.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 5bc129c..d37042f 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -3326,6 +3326,19 @@ static void test_delete_value(void) res = RegDeleteValueA( hkey_main, longname ); ok(res == ERROR_FILE_NOT_FOUND || broken(res == ERROR_MORE_DATA), /* nt4, win2k */ "expect ERROR_FILE_NOT_FOUND, got %i\n", res); + + /* Default registry value */ + res = RegSetValueExA(hkey_main, "", 0, REG_SZ, (const BYTE *)"value", 6); + ok(res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", res); + + res = RegQueryValueExA(hkey_main, "", NULL, NULL, NULL, NULL); + ok(res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", res); + + res = RegDeleteValueA(hkey_main, "" ); + ok(res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", res); + + res = RegQueryValueExA(hkey_main, "", NULL, NULL, NULL, NULL); + ok(res == ERROR_FILE_NOT_FOUND, "expected ERROR_FILE_NOT_FOUND, got %d\n", res); } static void test_delete_key_value(void) @@ -3374,6 +3387,19 @@ static void test_delete_key_value(void) ret = RegQueryValueExA(subkey, "test", NULL, NULL, NULL, NULL); ok(ret == ERROR_FILE_NOT_FOUND, "got %d\n", ret); + /* Default registry value */ + ret = RegSetValueExA(subkey, "", 0, REG_SZ, (const BYTE *)"value", 6); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + ret = RegQueryValueExA(subkey, "", NULL, NULL, NULL, NULL); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + ret = pRegDeleteKeyValueA(hkey_main, "Subkey1", "" ); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + ret = RegQueryValueExA(subkey, "", NULL, NULL, NULL, NULL); + ok(ret == ERROR_FILE_NOT_FOUND, "expected ERROR_FILE_NOT_FOUND, got %d\n", ret); + RegDeleteKeyA(subkey, ""); RegCloseKey(subkey); }

1 0

Jacek Caban : mshtml: Always return false in IHTMLDOMAttribute2:: get_expando for detached attributes.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 4e9324c43e639b50edfe614fbec0697c86f7b8f1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4e9324c43e639b50edfe614fb… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 1 14:28:52 2016 +0100 mshtml: Always return false in IHTMLDOMAttribute2::get_expando for detached attributes. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlattr.c | 2 +- dlls/mshtml/tests/dom.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c index 446cb6f..885b2aa 100644 --- a/dlls/mshtml/htmlattr.c +++ b/dlls/mshtml/htmlattr.c @@ -335,7 +335,7 @@ static HRESULT WINAPI HTMLDOMAttribute2_get_expando(IHTMLDOMAttribute2 *iface, V TRACE("(%p)->(%p)\n", This, p); - *p = get_dispid_type(This->dispid) == DISPEXPROP_BUILTIN ? VARIANT_FALSE : VARIANT_TRUE; + *p = !This->elem || get_dispid_type(This->dispid) == DISPEXPROP_BUILTIN ? VARIANT_FALSE : VARIANT_TRUE; return S_OK; } diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index e27339a..11e9d27 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -8919,6 +8919,7 @@ static void test_create_elems(IHTMLDocument2 *doc) test_no_iface((IUnknown*)attr, &IID_IHTMLDOMNode); test_attr_node_name(attr, "Test"); + test_attr_expando(attr, VARIANT_FALSE); IHTMLDOMAttribute_Release(attr); }

1 0

Jacek Caban : mshtml: Added support for IHTMLDOMAttribute:: nodeValue property on detached attributes.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 6c637ab9c6a65d5601f98545b05f413f777c444e URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c637ab9c6a65d5601f98545b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 1 14:31:25 2016 +0100 mshtml: Added support for IHTMLDOMAttribute::nodeValue property on detached attributes. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlattr.c | 13 +++++-------- dlls/mshtml/mshtml_private.h | 2 ++ dlls/mshtml/tests/dom.c | 16 ++++++++++++++++ 3 files changed, 23 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c index 885b2aa..97a4ce2 100644 --- a/dlls/mshtml/htmlattr.c +++ b/dlls/mshtml/htmlattr.c @@ -83,6 +83,7 @@ static ULONG WINAPI HTMLDOMAttribute_Release(IHTMLDOMAttribute *iface) if(!ref) { assert(!This->elem); release_dispex(&This->dispex); + VariantClear(&This->value); heap_free(This->name); heap_free(This); } @@ -150,10 +151,8 @@ static HRESULT WINAPI HTMLDOMAttribute_put_nodeValue(IHTMLDOMAttribute *iface, V TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); - if(!This->elem) { - FIXME("NULL This->elem\n"); - return E_UNEXPECTED; - } + if(!This->elem) + return VariantCopy(&This->value, &v); memset(&ei, 0, sizeof(ei)); @@ -167,10 +166,8 @@ static HRESULT WINAPI HTMLDOMAttribute_get_nodeValue(IHTMLDOMAttribute *iface, V TRACE("(%p)->(%p)\n", This, p); - if(!This->elem) { - FIXME("NULL This->elem\n"); - return E_UNEXPECTED; - } + if(!This->elem) + return VariantCopy(p, &This->value); return get_elem_attr_value_by_dispid(This->elem, This->dispid, 0, p); } diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index f4e6668..36c95ce 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -943,7 +943,9 @@ typedef struct { LONG ref; + /* name and value are valid only for detached attributes (when elem == NULL). */ WCHAR *name; + VARIANT value; HTMLElement *elem; DISPID dispid; diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 11e9d27..15a3027 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -4790,6 +4790,7 @@ static void _get_attr_node_value(unsigned line, IHTMLDOMAttribute *attr, VARIANT { HRESULT hres; + V_VT(v) = VT_EMPTY; hres = IHTMLDOMAttribute_get_nodeValue(attr, v); ok_(__FILE__,line) (hres == S_OK, "get_nodeValue failed: %08x\n", hres); ok_(__FILE__,line) (V_VT(v) == vt, "vt=%d, expected %d\n", V_VT(v), vt); @@ -8914,6 +8915,8 @@ static void test_create_elems(IHTMLDocument2 *doc) ok(hres == S_OK, "createAttribute dailed: %08x\n", hres); SysFreeString(str); if(SUCCEEDED(hres)) { + VARIANT v; + test_disp((IUnknown*)attr, &DIID_DispHTMLDOMAttribute, "[object]"); test_ifaces((IUnknown*)attr, attr_iids); test_no_iface((IUnknown*)attr, &IID_IHTMLDOMNode); @@ -8921,6 +8924,19 @@ static void test_create_elems(IHTMLDocument2 *doc) test_attr_node_name(attr, "Test"); test_attr_expando(attr, VARIANT_FALSE); + get_attr_node_value(attr, &v, VT_EMPTY); + + V_VT(&v) = VT_I4; + V_I4(&v) = 1; + put_attr_node_value(attr, v); + + get_attr_node_value(attr, &v, VT_I4); + ok(V_I4(&v) == 1, "nodeValue = %d\n", V_I4(&v)); + + V_VT(&v) = VT_EMPTY; + put_attr_node_value(attr, v); + get_attr_node_value(attr, &v, VT_EMPTY); + IHTMLDOMAttribute_Release(attr); }

1 0

Alexandre Julliard : configure: Support setting the corresponding enable variable directly from the WINE_NOTICE_WITH macros.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 850df9d5a5bedbcd50f7dbbcb2c36fdec6b65a13 URL: http://source.winehq.org/git/wine.git/?a=commit;h=850df9d5a5bedbcd50f7dbbcb… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 1 14:48:04 2016 +0900 configure: Support setting the corresponding enable variable directly from the WINE_NOTICE_WITH macros. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- aclocal.m4 | 14 ++++++++----- configure | 67 ++++++++++++++++++++++++++++++++++++++++++++++++------------ configure.ac | 40 +++++++++++++++++------------------- 3 files changed, 82 insertions(+), 39 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=850df9d5a5bedbcd50f7d…

1 0

Alexandre Julliard : makedep: Make the filename hashing more efficient.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: bf6db74f85d4a6bbf2ef3f2ce90162382c4fc71f URL: http://source.winehq.org/git/wine.git/?a=commit;h=bf6db74f85d4a6bbf2ef3f2ce… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 1 17:20:33 2016 +0900 makedep: Make the filename hashing more efficient. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/makedep.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/makedep.c b/tools/makedep.c index adb8a40..298ec04 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -109,7 +109,7 @@ static const struct { FLAG_IDL_HEADER, ".h" } }; -#define HASH_SIZE 137 +#define HASH_SIZE 997 static struct list files[HASH_SIZE]; @@ -728,8 +728,9 @@ static char *get_line( FILE *file ) */ static unsigned int hash_filename( const char *name ) { - unsigned int ret = 0; - while (*name) ret = (ret << 7) + (ret << 3) + *name++; + /* FNV-1 hash */ + unsigned int ret = 2166136261; + while (*name) ret = (ret * 16777619) ^ *name++; return ret % HASH_SIZE; } @@ -742,7 +743,6 @@ static struct file *add_file( const char *name ) struct file *file = xmalloc( sizeof(*file) ); memset( file, 0, sizeof(*file) ); file->name = xstrdup( name ); - list_add_tail( &files[hash_filename( name )], &file->entry ); return file; } @@ -1198,6 +1198,7 @@ static struct file *load_file( const char *name ) if (!(f = fopen( name, "r" ))) return NULL; file = add_file( name ); + list_add_tail( &files[hash], &file->entry ); input_file_name = file->name; input_line = 0;

1 0

Thomas Faber : ntdll/tests: Test NtOpenKey with zero access.
by Alexandre Julliard 01 Mar '16

01 Mar '16

Module: wine Branch: master Commit: 5441f8352c329866f95b087c17cf7e39c75d3a71 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5441f8352c329866f95b087c1… Author: Thomas Faber <thomas.faber(a)reactos.org> Date: Mon Feb 29 17:09:48 2016 +0100 ntdll/tests: Test NtOpenKey with zero access. Signed-off-by: Thomas Faber <thomas.faber(a)reactos.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/reg.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index d00a496..3738301 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -362,6 +362,13 @@ static void test_NtOpenKey(void) status = pNtOpenKey(&key, am, &attr); ok(status == STATUS_INVALID_PARAMETER, "Expected STATUS_INVALID_PARAMETER, got: 0x%08x\n", status); + /* Zero accessmask */ + attr.Length = sizeof(attr); + status = pNtOpenKey(&key, 0, &attr); +todo_wine + ok(status == STATUS_ACCESS_DENIED, "Expected STATUS_ACCESS_DENIED, got: 0x%08x\n", status); + if (status == STATUS_SUCCESS) NtClose(key); + /* Calling without parent key requres full registry path. */ pRtlCreateUnicodeStringFromAsciiz( &str, "Machine" ); InitializeObjectAttributes(&attr, &str, 0, 0, 0);

1 0