November 2021 - Wine-commits

Zebediah Figura : qedit/tests: Test receiving EC_COMPLETE when not connected.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 59376f124bf4ddbbda73a7814bfa2c160325124e URL: https://source.winehq.org/git/wine.git/?a=commit;h=59376f124bf4ddbbda73a781… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Oct 31 19:04:07 2021 -0500 qedit/tests: Test receiving EC_COMPLETE when not connected. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qedit/tests/nullrenderer.c | 104 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 104 insertions(+) diff --git a/dlls/qedit/tests/nullrenderer.c b/dlls/qedit/tests/nullrenderer.c index 1800f4dad4c..b4003f43cf4 100644 --- a/dlls/qedit/tests/nullrenderer.c +++ b/dlls/qedit/tests/nullrenderer.c @@ -32,6 +32,15 @@ static IBaseFilter *create_null_renderer(void) return filter; } +static IFilterGraph2 *create_graph(void) +{ + IFilterGraph2 *ret; + HRESULT hr; + hr = CoCreateInstance(&CLSID_FilterGraph, NULL, CLSCTX_INPROC_SERVER, &IID_IFilterGraph2, (void **)&ret); + ok(hr == S_OK, "Failed to create FilterGraph: %#x\n", hr); + return ret; +} + static ULONG get_refcount(void *iface) { IUnknown *unknown = iface; @@ -791,6 +800,34 @@ static void test_flushing(IPin *pin, IMemInputPin *input, IFilterGraph2 *graph) IMediaControl_Release(control); } +static unsigned int check_event_code(IMediaEvent *eventsrc, DWORD timeout, LONG expected_code, LONG_PTR expected1, LONG_PTR expected2) +{ + LONG_PTR param1, param2; + unsigned int ret = 0; + HRESULT hr; + LONG code; + + while ((hr = IMediaEvent_GetEvent(eventsrc, &code, &param1, &param2, timeout)) == S_OK) + { + if (code == expected_code) + { + ok(param1 == expected1, "Got param1 %#lx.\n", param1); + ok(param2 == expected2, "Got param2 %#lx.\n", param2); + ret++; + } + IMediaEvent_FreeEventParams(eventsrc, code, param1, param2); + timeout = 0; + } + ok(hr == E_ABORT, "Got hr %#x.\n", hr); + + return ret; +} + +static unsigned int check_ec_complete(IMediaEvent *eventsrc, DWORD timeout) +{ + return check_event_code(eventsrc, timeout, EC_COMPLETE, S_OK, 0); +} + static void test_connect_pin(void) { static const AM_MEDIA_TYPE req_mt = @@ -900,6 +937,72 @@ static void test_connect_pin(void) ok(!ref, "Got outstanding refcount %d.\n", ref); } +static void test_unconnected_eos(void) +{ + IBaseFilter *filter = create_null_renderer(); + IFilterGraph2 *graph = create_graph(); + IMediaControl *control; + IMediaEvent *eventsrc; + unsigned int ret; + HRESULT hr; + ULONG ref; + + hr = IFilterGraph2_AddFilter(graph, filter, L"renderer"); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IFilterGraph2_QueryInterface(graph, &IID_IMediaControl, (void **)&control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IFilterGraph2_QueryInterface(graph, &IID_IMediaEvent, (void **)&eventsrc); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + ok(!ret, "Got %u EC_COMPLETE events.\n", ret); + + hr = IMediaControl_Pause(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + ok(!ret, "Got %u EC_COMPLETE events.\n", ret); + + hr = IMediaControl_Run(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + + hr = IMediaControl_Pause(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + ok(!ret, "Got %u EC_COMPLETE events.\n", ret); + + hr = IMediaControl_Run(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + + hr = IMediaControl_Stop(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + ok(!ret, "Got %u EC_COMPLETE events.\n", ret); + + hr = IMediaControl_Run(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + ret = check_ec_complete(eventsrc, 0); + todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + + IMediaControl_Release(control); + IMediaEvent_Release(eventsrc); + ref = IFilterGraph2_Release(graph); + ok(!ref, "Got outstanding refcount %d.\n", ref); + ref = IBaseFilter_Release(filter); + ok(!ref, "Got outstanding refcount %d.\n", ref); +} + START_TEST(nullrenderer) { IBaseFilter *filter; @@ -924,6 +1027,7 @@ START_TEST(nullrenderer) test_media_types(); test_enum_media_types(); test_connect_pin(); + test_unconnected_eos(); CoUninitialize(); }

1 0

Andrew Eikum : strmbase: Send EC_COMPLETE in IBaseFilter::Run() for unconnected renderers.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 6e11378df2f1cdbff984b7b8072e46a7738e74a2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6e11378df2f1cdbff984b7b8… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Sun Oct 31 19:04:08 2021 -0500 strmbase: Send EC_COMPLETE in IBaseFilter::Run() for unconnected renderers. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/evr/tests/evr.c | 6 +++--- dlls/qedit/tests/nullrenderer.c | 6 +++--- dlls/quartz/tests/videorenderer.c | 6 +++--- dlls/quartz/tests/vmr7.c | 6 +++--- dlls/quartz/tests/vmr9.c | 6 +++--- dlls/strmbase/renderer.c | 2 +- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dlls/evr/tests/evr.c b/dlls/evr/tests/evr.c index 8bfeb987352..48115388993 100644 --- a/dlls/evr/tests/evr.c +++ b/dlls/evr/tests/evr.c @@ -508,7 +508,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Pause(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -520,7 +520,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -532,7 +532,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); IMediaControl_Release(control); IMediaEvent_Release(eventsrc); diff --git a/dlls/qedit/tests/nullrenderer.c b/dlls/qedit/tests/nullrenderer.c index b4003f43cf4..cfbf1d37c2f 100644 --- a/dlls/qedit/tests/nullrenderer.c +++ b/dlls/qedit/tests/nullrenderer.c @@ -969,7 +969,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Pause(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -981,7 +981,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -993,7 +993,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); IMediaControl_Release(control); IMediaEvent_Release(eventsrc); diff --git a/dlls/quartz/tests/videorenderer.c b/dlls/quartz/tests/videorenderer.c index 0ce24884200..5625971426b 100644 --- a/dlls/quartz/tests/videorenderer.c +++ b/dlls/quartz/tests/videorenderer.c @@ -2897,7 +2897,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Pause(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -2909,7 +2909,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -2921,7 +2921,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); IMediaControl_Release(control); IMediaEvent_Release(eventsrc); diff --git a/dlls/quartz/tests/vmr7.c b/dlls/quartz/tests/vmr7.c index 1214d5dcbb7..efc876a845c 100644 --- a/dlls/quartz/tests/vmr7.c +++ b/dlls/quartz/tests/vmr7.c @@ -3101,7 +3101,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Pause(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -3113,7 +3113,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -3125,7 +3125,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); IMediaControl_Release(control); IMediaEvent_Release(eventsrc); diff --git a/dlls/quartz/tests/vmr9.c b/dlls/quartz/tests/vmr9.c index 618669595cb..a0ccb4898a9 100644 --- a/dlls/quartz/tests/vmr9.c +++ b/dlls/quartz/tests/vmr9.c @@ -4202,7 +4202,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Pause(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -4214,7 +4214,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -4226,7 +4226,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); IMediaControl_Release(control); IMediaEvent_Release(eventsrc); diff --git a/dlls/strmbase/renderer.c b/dlls/strmbase/renderer.c index a879917b169..da257555a19 100644 --- a/dlls/strmbase/renderer.c +++ b/dlls/strmbase/renderer.c @@ -252,7 +252,7 @@ static HRESULT renderer_start_stream(struct strmbase_filter *iface, REFERENCE_TI if (filter->sink.pin.peer && filter->ops->renderer_start_stream) filter->ops->renderer_start_stream(filter); - if (filter->eos && graph + if ((filter->eos || !filter->sink.pin.peer) && graph && SUCCEEDED(IFilterGraph_QueryInterface(graph, &IID_IMediaEventSink, (void **)&event_sink))) {

1 0

Zebediah Figura : quartz/dsoundrender: Send EC_COMPLETE in IBaseFilter::Run() when not connected.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 0b79e2caa6f224fc0da672886c07f4f32dda4682 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0b79e2caa6f224fc0da67288… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Oct 31 19:04:09 2021 -0500 quartz/dsoundrender: Send EC_COMPLETE in IBaseFilter::Run() when not connected. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/dsoundrender.c | 2 +- dlls/quartz/tests/dsoundrender.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index 51a66ac5d30..df40d1254ee 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -608,7 +608,7 @@ static HRESULT dsound_render_start_stream(struct strmbase_filter *iface, REFEREN if (filter->sink.pin.peer) IDirectSoundBuffer_Play(filter->dsbuffer, 0, 0, DSBPLAY_LOOPING); - if (filter->eos && graph + if ((filter->eos || !filter->sink.pin.peer) && graph && SUCCEEDED(IFilterGraph_QueryInterface(graph, &IID_IMediaEventSink, (void **)&event_sink))) { diff --git a/dlls/quartz/tests/dsoundrender.c b/dlls/quartz/tests/dsoundrender.c index 9107828b9df..03e6b8413d5 100644 --- a/dlls/quartz/tests/dsoundrender.c +++ b/dlls/quartz/tests/dsoundrender.c @@ -1355,7 +1355,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Pause(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -1367,7 +1367,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); hr = IMediaControl_Stop(control); ok(hr == S_OK, "Got hr %#x.\n", hr); @@ -1379,7 +1379,7 @@ static void test_unconnected_eos(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ret = check_ec_complete(eventsrc, 0); - todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); + ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret); IMediaControl_Release(control); IMediaEvent_Release(eventsrc);

1 0

Alexandre Julliard : crypt32: Split the import_cert_store function to move memory allocations to the PE side.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: f18ccfef7bffeae9e28aa2311fec07b1680e1d7c URL: https://source.winehq.org/git/wine.git/?a=commit;h=f18ccfef7bffeae9e28aa231… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Oct 31 17:08:59 2021 +0100 crypt32: Split the import_cert_store function to move memory allocations to the PE side. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/crypt32_private.h | 10 +++- dlls/crypt32/pfx.c | 49 ++++++++++------- dlls/crypt32/unixlib.c | 120 +++++++++++++++++++++++++---------------- 3 files changed, 112 insertions(+), 67 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=f18ccfef7bffeae9e28a…

1 0

Alexandre Julliard : crypt32: Convert the Unix library to the __wine_unix_call interface.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 41663e6ea58742933f9b9935e77b32bab7520a0c URL: https://source.winehq.org/git/wine.git/?a=commit;h=41663e6ea58742933f9b9935… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Oct 31 17:09:05 2021 +0100 crypt32: Convert the Unix library to the __wine_unix_call interface. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/Makefile.in | 1 + dlls/crypt32/crypt32_private.h | 55 +++++++++++++++--- dlls/crypt32/main.c | 9 ++- dlls/crypt32/pfx.c | 30 +++++----- dlls/crypt32/rootstore.c | 22 +++---- dlls/crypt32/unixlib.c | 129 ++++++++++++++++++++--------------------- 6 files changed, 144 insertions(+), 102 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=41663e6ea58742933f9b…

1 0

Alistair Leslie-Hughes : include: Add more DB_* defines.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 9bdcf444393d19eb0fd6a91dbb920660c4748edf URL: https://source.winehq.org/git/wine.git/?a=commit;h=9bdcf444393d19eb0fd6a91d… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Oct 31 19:51:14 2021 +1100 include: Add more DB_* defines. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/oledberr.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/oledberr.h b/include/oledberr.h index c0eccba1e97..1ca5446d06e 100644 --- a/include/oledberr.h +++ b/include/oledberr.h @@ -30,7 +30,17 @@ #define DB_E_BADCHAPTER 0x80040e06 #define DB_E_CANTCONVERTVALUE 0x80040e07 #define DB_E_BADBINDINFO 0x80040e08 - +#define DB_SEC_E_PERMISSIONDENIED 0x80040e09 +#define DB_E_NOTAREFERENCECOLUMN 0x80040e0a +#define DB_E_LIMITREJECTED 0x80040e0b +#define DB_E_NOCOMMAND 0x80040e0c +#define DB_E_COSTLIMIT 0x80040e0d +#define DB_E_BADBOOKMARK 0x80040e0e +#define DB_E_BADLOCKMODE 0x80040e0f +#define DB_E_PARAMNOTOPTIONAL 0x80040e10 +#define DB_E_BADCOLUMNID 0x80040e11 +#define DB_E_BADRATIO 0x80040e12 +#define DB_E_BADVALUES 0x80040e13 #define DB_E_ERRORSINCOMMAND 0x80040e14 #define DB_E_CANTCANCEL 0x80040e15 #define DB_E_DIALECTNOTSUPPORTED 0x80040e16 @@ -86,6 +96,7 @@ #define DB_S_BOOKMARKSKIPPED 0x00040ec3 #define DB_S_NONEXTROWSET 0x00040ec5 #define DB_S_ENDOFROWSET 0x00040ec6 +#define DB_S_DIALECTIGNORED 0x00040ecd #define DB_S_ERRORSOCCURRED 0x00040eda #endif /* __WINE_OLEDBERR_H */

1 0

Alistair Leslie-Hughes : msdasql: Add ICommandPrepare interface for ICommandText.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 22689f6f8a0865622465c8ea72e42c3a607356b5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=22689f6f8a0865622465c8ea… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Oct 31 19:51:15 2021 +1100 msdasql: Add ICommandPrepare interface for ICommandText. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msdasql/session.c | 52 +++++++++++++++++++++++++++++++++++++++++++ dlls/msdasql/tests/provider.c | 5 ++--- 2 files changed, 54 insertions(+), 3 deletions(-) diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c index 3ee4b72a1d1..da148fd7ca6 100644 --- a/dlls/msdasql/session.c +++ b/dlls/msdasql/session.c @@ -281,6 +281,7 @@ struct command ICommandProperties ICommandProperties_iface; IColumnsInfo IColumnsInfo_iface; IConvertType IConvertType_iface; + ICommandPrepare ICommandPrepare_iface; LONG refs; }; @@ -304,6 +305,11 @@ static inline struct command *impl_from_IConvertType( IConvertType *iface ) return CONTAINING_RECORD( iface, struct command, IConvertType_iface ); } +static inline struct command *impl_from_ICommandPrepare( ICommandPrepare *iface ) +{ + return CONTAINING_RECORD( iface, struct command, ICommandPrepare_iface ); +} + static HRESULT WINAPI command_QueryInterface(ICommandText *iface, REFIID riid, void **ppv) { struct command *command = impl_from_ICommandText( iface ); @@ -329,6 +335,10 @@ static HRESULT WINAPI command_QueryInterface(ICommandText *iface, REFIID riid, v { *ppv = &command->IConvertType_iface; } + else if(IsEqualGUID(&IID_ICommandPrepare, riid)) + { + *ppv = &command->ICommandPrepare_iface; + } if(*ppv) { @@ -553,6 +563,47 @@ static struct IConvertTypeVtbl converttypeVtbl = converttype_CanConvert }; +static HRESULT WINAPI commandprepare_QueryInterface(ICommandPrepare *iface, REFIID riid, void **out) +{ + struct command *command = impl_from_ICommandPrepare( iface ); + return ICommandText_QueryInterface(&command->ICommandText_iface, riid, out); +} + +static ULONG WINAPI commandprepare_AddRef(ICommandPrepare *iface) +{ + struct command *command = impl_from_ICommandPrepare( iface ); + return ICommandText_AddRef(&command->ICommandText_iface); +} + +static ULONG WINAPI commandprepare_Release(ICommandPrepare *iface) +{ + struct command *command = impl_from_ICommandPrepare( iface ); + return ICommandText_Release(&command->ICommandText_iface); +} + +static HRESULT WINAPI commandprepare_Prepare(ICommandPrepare *iface, ULONG runs) +{ + struct command *command = impl_from_ICommandPrepare( iface ); + FIXME("%p, %u\n", command, runs); + return E_NOTIMPL; +} + +static HRESULT WINAPI commandprepare_Unprepare(ICommandPrepare *iface) +{ + struct command *command = impl_from_ICommandPrepare( iface ); + FIXME("%p\n", command); + return E_NOTIMPL; +} + +struct ICommandPrepareVtbl commandprepareVtbl = +{ + commandprepare_QueryInterface, + commandprepare_AddRef, + commandprepare_Release, + commandprepare_Prepare, + commandprepare_Unprepare +}; + static HRESULT WINAPI createcommand_CreateCommand(IDBCreateCommand *iface, IUnknown *outer, REFIID riid, IUnknown **out) { @@ -573,6 +624,7 @@ static HRESULT WINAPI createcommand_CreateCommand(IDBCreateCommand *iface, IUnkn command->ICommandProperties_iface.lpVtbl = &commonpropsVtbl; command->IColumnsInfo_iface.lpVtbl = &columninfoVtbl; command->IConvertType_iface.lpVtbl = &converttypeVtbl; + command->ICommandPrepare_iface.lpVtbl = &commandprepareVtbl; command->refs = 1; hr = ICommandText_QueryInterface(&command->ICommandText_iface, riid, (void**)out); diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index 7d14928e50b..bb624bd9848 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -134,9 +134,8 @@ static void test_command_interfaces(IUnknown *cmd) IConvertType_Release(convertype); hr = IUnknown_QueryInterface(cmd, &IID_ICommandPrepare, (void**)&commandprepare); - todo_wine ok(hr == S_OK, "got 0x%08x\n", hr); - if (hr == S_OK) - ICommandPrepare_Release(commandprepare); + ok(hr == S_OK, "got 0x%08x\n", hr); + ICommandPrepare_Release(commandprepare); hr = IUnknown_QueryInterface(cmd, &IID_IColumnsInfo, (void**)&colinfo); ok(hr == S_OK, "got 0x%08x\n", hr);

1 0

Alistair Leslie-Hughes : msdasql: Implement ICommandText Get/Set CommandText.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: 3dd785def70d3b525528e1660b5eaafba274e4e2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3dd785def70d3b525528e166… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Oct 31 19:51:16 2021 +1100 msdasql: Implement ICommandText Get/Set CommandText. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msdasql/msdasql_main.c | 2 ++ dlls/msdasql/session.c | 35 +++++++++++++++++++++++++++--- dlls/msdasql/tests/provider.c | 50 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 84 insertions(+), 3 deletions(-) diff --git a/dlls/msdasql/msdasql_main.c b/dlls/msdasql/msdasql_main.c index 79feacb83aa..a2d40e14b96 100644 --- a/dlls/msdasql/msdasql_main.c +++ b/dlls/msdasql/msdasql_main.c @@ -36,6 +36,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(msdasql); DEFINE_GUID(DBPROPSET_DBINIT, 0xc8b522bc, 0x5cf3, 0x11ce, 0xad, 0xe5, 0x00, 0xaa, 0x00, 0x44, 0x77, 0x3d); +DEFINE_GUID(DBGUID_DEFAULT, 0xc8b521fb, 0x5cf3, 0x11ce, 0xad, 0xe5, 0x00, 0xaa, 0x00, 0x44, 0x77, 0x3d); + static HRESULT WINAPI ClassFactory_QueryInterface(IClassFactory *iface, REFIID riid, void **ppv) { *ppv = NULL; diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c index da148fd7ca6..c0deb32d8ad 100644 --- a/dlls/msdasql/session.c +++ b/dlls/msdasql/session.c @@ -29,6 +29,7 @@ #include "wine/debug.h" #include "msdasql.h" +#include "oledberr.h" #include "msdasql_private.h" @@ -283,6 +284,7 @@ struct command IConvertType IConvertType_iface; ICommandPrepare ICommandPrepare_iface; LONG refs; + WCHAR *query; }; static inline struct command *impl_from_ICommandText( ICommandText *iface ) @@ -391,6 +393,7 @@ static ULONG WINAPI command_Release(ICommandText *iface) if (!refs) { TRACE( "destroying %p\n", command ); + heap_free( command->query ); heap_free( command ); } return refs; @@ -421,14 +424,40 @@ static HRESULT WINAPI command_GetDBSession(ICommandText *iface, REFIID riid, IUn static HRESULT WINAPI command_GetCommandText(ICommandText *iface, GUID *dialect, LPOLESTR *commandstr) { struct command *command = impl_from_ICommandText( iface ); - FIXME("%p, %p, %p\n", command, dialect, commandstr); - return E_NOTIMPL; + HRESULT hr = S_OK; + TRACE("%p, %p, %p\n", command, dialect, commandstr); + + if (!command->query) + return DB_E_NOCOMMAND; + + if (IsEqualGUID(&DBGUID_DEFAULT, dialect)) + hr = DB_S_DIALECTIGNORED; + + *commandstr = heap_alloc((lstrlenW(command->query)+1)*sizeof(WCHAR)); + wcscpy(*commandstr, command->query); + return hr; } static HRESULT WINAPI command_SetCommandText(ICommandText *iface, REFGUID dialect, LPCOLESTR commandstr) { struct command *command = impl_from_ICommandText( iface ); - FIXME("%p, %s, %s\n", command, debugstr_guid(dialect), debugstr_w(commandstr)); + TRACE("%p, %s, %s\n", command, debugstr_guid(dialect), debugstr_w(commandstr)); + + if (IsEqualGUID(&DBGUID_DEFAULT, dialect)) + FIXME("Currently non Default Dialect isn't supported\n"); + + heap_free(command->query); + + if (commandstr) + { + command->query = heap_alloc((lstrlenW(commandstr)+1)*sizeof(WCHAR)); + if (!command->query) + return E_OUTOFMEMORY; + + wcscpy(command->query, commandstr); + } + else + command->query = NULL; return S_OK; } diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index bb624bd9848..09a4b69c31d 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -27,12 +27,15 @@ #include "initguid.h" #include "msdasql.h" +#include "oledberr.h" #include "wine/test.h" DEFINE_GUID(DBPROPSET_DBINITALL, 0xc8b522ca, 0x5cf3, 0x11ce, 0xad, 0xe5, 0x00, 0xaa, 0x00, 0x44, 0x77, 0x3d); DEFINE_GUID(DBPROPSET_DBINIT, 0xc8b522bc, 0x5cf3, 0x11ce, 0xad, 0xe5, 0x00, 0xaa, 0x00, 0x44, 0x77, 0x3d); +DEFINE_GUID(DBGUID_DEFAULT, 0xc8b521fb, 0x5cf3, 0x11ce, 0xad, 0xe5, 0x00, 0xaa, 0x00, 0x44, 0x77, 0x3d); + static BOOL db_created; static char mdbpath[MAX_PATH]; @@ -157,6 +160,52 @@ static void test_command_interfaces(IUnknown *cmd) ok(hr == E_NOINTERFACE, "got 0x%08x\n", hr); } +static void test_command_text(IUnknown *cmd) +{ + ICommandText *comand_text; + HRESULT hr; + OLECHAR *str; + GUID dialect; + + hr = IUnknown_QueryInterface(cmd, &IID_ICommandText, (void**)&comand_text); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ICommandText_GetCommandText(comand_text, &dialect, &str); + ok(hr == DB_E_NOCOMMAND, "got 0x%08x\n", hr); + +if (0) +{ + /* Crashes under windows */ + hr = ICommandText_SetCommandText(comand_text, NULL, L"select * from testing"); + ok(hr == S_OK, "got 0x%08x\n", hr); +} + + hr = ICommandText_SetCommandText(comand_text, &DBGUID_DEFAULT, NULL); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ICommandText_GetCommandText(comand_text, &dialect, &str); + ok(hr == DB_E_NOCOMMAND, "got 0x%08x\n", hr); + + hr = ICommandText_SetCommandText(comand_text, &DBGUID_DEFAULT, L"select * from testing"); + ok(hr == S_OK, "got 0x%08x\n", hr); + + /* dialect empty value */ + hr = ICommandText_GetCommandText(comand_text, &dialect, &str); + ok(hr == DB_S_DIALECTIGNORED, "got 0x%08x\n", hr); + ok(IsEqualGUID(&DBGUID_DEFAULT, &dialect), "got %s\n", debugstr_guid(&dialect)); + ok (!lstrcmpW(L"select * from testing", str), "got %s\n", debugstr_w(str)); + HeapFree(GetProcessHeap(), 0, str); + + dialect = DBGUID_DEFAULT; + hr = ICommandText_GetCommandText(comand_text, &dialect, &str); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(IsEqualGUID(&DBGUID_DEFAULT, &dialect), "got %s\n", debugstr_guid(&dialect)); + ok (!lstrcmpW(L"select * from testing", str), "got %s\n", debugstr_w(str)); + HeapFree(GetProcessHeap(), 0, str); + + ICommandText_Release(comand_text); +} + static void test_sessions(void) { IDBProperties *props; @@ -231,6 +280,7 @@ static void test_sessions(void) if (hr == S_OK) { test_command_interfaces(cmd); + test_command_text(cmd); IUnknown_Release(cmd); }

1 0

Alistair Leslie-Hughes : msdasql: Implement ICommandText GetDBSession.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: dd279bd0150549dbd4703aa5e84e25177ec24398 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dd279bd0150549dbd4703aa5… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Oct 31 19:51:17 2021 +1100 msdasql: Implement ICommandText GetDBSession. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msdasql/session.c | 19 +++++++++++++++++-- dlls/msdasql/tests/provider.c | 17 +++++++++++++++++ 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c index c0deb32d8ad..4949d6d47e5 100644 --- a/dlls/msdasql/session.c +++ b/dlls/msdasql/session.c @@ -285,6 +285,7 @@ struct command ICommandPrepare ICommandPrepare_iface; LONG refs; WCHAR *query; + IUnknown *session; }; static inline struct command *impl_from_ICommandText( ICommandText *iface ) @@ -393,6 +394,8 @@ static ULONG WINAPI command_Release(ICommandText *iface) if (!refs) { TRACE( "destroying %p\n", command ); + if (command->session) + IUnknown_Release(command->session); heap_free( command->query ); heap_free( command ); } @@ -417,8 +420,18 @@ static HRESULT WINAPI command_Execute(ICommandText *iface, IUnknown *outer, REFI static HRESULT WINAPI command_GetDBSession(ICommandText *iface, REFIID riid, IUnknown **session) { struct command *command = impl_from_ICommandText( iface ); - FIXME("%p, %s, %p\n", command, debugstr_guid(riid), session); - return E_NOTIMPL; + + TRACE("%p, %s, %p\n", command, debugstr_guid(riid), session); + + if (!session) + return E_INVALIDARG; + + *session = NULL; + + if (!command->session) + return S_FALSE; + + return IUnknown_QueryInterface(command->session, riid, (void**)session); } static HRESULT WINAPI command_GetCommandText(ICommandText *iface, GUID *dialect, LPOLESTR *commandstr) @@ -656,6 +669,8 @@ static HRESULT WINAPI createcommand_CreateCommand(IDBCreateCommand *iface, IUnkn command->ICommandPrepare_iface.lpVtbl = &commandprepareVtbl; command->refs = 1; + IUnknown_QueryInterface(&session->session_iface, &IID_IUnknown, (void**)&command->session); + hr = ICommandText_QueryInterface(&command->ICommandText_iface, riid, (void**)out); ICommandText_Release(&command->ICommandText_iface); return hr; diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index 09a4b69c31d..35dfeb10d3d 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -206,6 +206,22 @@ if (0) ICommandText_Release(comand_text); } +static void test_command_dbsession(IUnknown *cmd, IUnknown *session) +{ + ICommandText *comand_text; + HRESULT hr; + IUnknown *sess; + + hr = IUnknown_QueryInterface(cmd, &IID_ICommandText, (void**)&comand_text); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ICommandText_GetDBSession(comand_text, &IID_IUnknown, &sess); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(session == sess, "different session pointers\n"); + + ICommandText_Release(comand_text); +} + static void test_sessions(void) { IDBProperties *props; @@ -281,6 +297,7 @@ static void test_sessions(void) { test_command_interfaces(cmd); test_command_text(cmd); + test_command_dbsession(cmd, session); IUnknown_Release(cmd); }

1 0

Alistair Leslie-Hughes : msdasql: Return valid object from ICommandText Execute.
by Alexandre Julliard 01 Nov '21

01 Nov '21

Module: wine Branch: master Commit: c0cf153751bbeab83da3e8e7ee9701cc473222b9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c0cf153751bbeab83da3e8e7… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Oct 31 19:51:18 2021 +1100 msdasql: Return valid object from ICommandText Execute. Until we query ODBC, we aren't able workout if we need a recordset or not. As a start, always return an interface, this way we can add the required interface for a rowset. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msdasql/session.c | 127 +++++++++++++++++++++++++++++++++++++++++- dlls/msdasql/tests/provider.c | 41 ++++++++++++++ 2 files changed, 166 insertions(+), 2 deletions(-) diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c index 4949d6d47e5..6a1e6bb8e0d 100644 --- a/dlls/msdasql/session.c +++ b/dlls/msdasql/session.c @@ -409,12 +409,135 @@ static HRESULT WINAPI command_Cancel(ICommandText *iface) return E_NOTIMPL; } +struct msdasql_rowset +{ + IRowset IRowset_iface; + LONG refs; +}; + +static inline struct msdasql_rowset *impl_from_IRowset( IRowset *iface ) +{ + return CONTAINING_RECORD( iface, struct msdasql_rowset, IRowset_iface ); +} + +static HRESULT WINAPI msdasql_rowset_QueryInterface(IRowset *iface, REFIID riid, void **ppv) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + + TRACE( "%p, %s, %p\n", rowset, debugstr_guid(riid), ppv ); + + *ppv = NULL; + if(IsEqualGUID(&IID_IUnknown, riid) || + IsEqualGUID(&IID_IRowset, riid)) + { + *ppv = &rowset->IRowset_iface; + } + + if(*ppv) + { + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; + } + + FIXME("(%p)->(%s %p)\n", iface, debugstr_guid(riid), ppv); + return E_NOINTERFACE; +} + +static ULONG WINAPI msdasql_rowset_AddRef(IRowset *iface) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + LONG refs = InterlockedIncrement( &rowset->refs ); + TRACE( "%p new refcount %d\n", rowset, refs ); + return refs; +} + +static ULONG WINAPI msdasql_rowset_Release(IRowset *iface) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + LONG refs = InterlockedDecrement( &rowset->refs ); + TRACE( "%p new refcount %d\n", rowset, refs ); + if (!refs) + { + TRACE( "destroying %p\n", rowset ); + heap_free( rowset ); + } + return refs; +} + +static HRESULT WINAPI msdasql_rowset_AddRefRows(IRowset *iface, DBCOUNTITEM count, + const HROW rows[], DBREFCOUNT ref_counts[], DBROWSTATUS status[]) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + FIXME("%p, %ld, %p, %p, %p\n", rowset, count, rows, ref_counts, status); + return E_NOTIMPL; +} + +static HRESULT WINAPI msdasql_rowset_GetData(IRowset *iface, HROW row, HACCESSOR accessor, void *data) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + FIXME("%p, %ld, %ld, %p\n", rowset, row, accessor, data); + return E_NOTIMPL; +} + +static HRESULT WINAPI msdasql_rowset_GetNextRows(IRowset *iface, HCHAPTER reserved, DBROWOFFSET offset, + DBROWCOUNT count, DBCOUNTITEM *obtained, HROW **rows) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + FIXME("%p, %ld, %ld, %ld, %p, %p\n", rowset, reserved, offset, count, obtained, rows); + return E_NOTIMPL; +} + +static HRESULT WINAPI msdasql_rowset_ReleaseRows(IRowset *iface, DBCOUNTITEM count, + const HROW rows[], DBROWOPTIONS options[], DBREFCOUNT ref_counts[], DBROWSTATUS status[]) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + + FIXME("%p, %ld, %p, %p, %p, %p\n", rowset, count, rows, options, ref_counts, status); + return E_NOTIMPL; +} + +static HRESULT WINAPI msdasql_rowset_RestartPosition(IRowset *iface, HCHAPTER reserved) +{ + struct msdasql_rowset *rowset = impl_from_IRowset( iface ); + FIXME("%p, %ld\n", rowset, reserved); + return E_NOTIMPL; +} + +static const struct IRowsetVtbl msdasql_rowset_vtbl = +{ + msdasql_rowset_QueryInterface, + msdasql_rowset_AddRef, + msdasql_rowset_Release, + msdasql_rowset_AddRefRows, + msdasql_rowset_GetData, + msdasql_rowset_GetNextRows, + msdasql_rowset_ReleaseRows, + msdasql_rowset_RestartPosition +}; + static HRESULT WINAPI command_Execute(ICommandText *iface, IUnknown *outer, REFIID riid, DBPARAMS *params, DBROWCOUNT *affected, IUnknown **rowset) { struct command *command = impl_from_ICommandText( iface ); - FIXME("%p, %p, %s, %p %p %p\n", command, outer, debugstr_guid(riid), params, affected, rowset); - return E_NOTIMPL; + struct msdasql_rowset *msrowset; + HRESULT hr; + + FIXME("%p, %p, %s, %p %p %p Semi Stub\n", command, outer, debugstr_guid(riid), params, affected, rowset); + + msrowset = heap_alloc(sizeof(*msrowset)); + if (!msrowset) + return E_OUTOFMEMORY; + + msrowset->IRowset_iface.lpVtbl = &msdasql_rowset_vtbl; + msrowset->refs = 1; + + if (affected) + *affected = 0; /* FIXME */ + + hr = IRowset_QueryInterface(&msrowset->IRowset_iface, riid, (void**)rowset); + IRowset_Release(&msrowset->IRowset_iface); + + return hr; } static HRESULT WINAPI command_GetDBSession(ICommandText *iface, REFIID riid, IUnknown **session) diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index 35dfeb10d3d..df642a6a637 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -222,6 +222,46 @@ static void test_command_dbsession(IUnknown *cmd, IUnknown *session) ICommandText_Release(comand_text); } +static void test_command_rowset(IUnknown *cmd) +{ + ICommandText *comand_text; + HRESULT hr; + IUnknown *unk = NULL; + IRowset *rowset; + DBROWCOUNT affected; + + hr = IUnknown_QueryInterface(cmd, &IID_ICommandText, (void**)&comand_text); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ICommandText_SetCommandText(comand_text, &DBGUID_DEFAULT, L"CREATE TABLE testing (col1 INT, col2 SHORT)"); + ok(hr == S_OK, "got 0x%08x\n", hr); + + affected = 9999; + hr = ICommandText_Execute(comand_text, NULL, &IID_IRowset, NULL, &affected, &unk); + ok(hr == S_OK, "got 0x%08x\n", hr); + todo_wine ok(unk == NULL, "Unexepcted value\n"); + todo_wine ok(affected == -1, "got %ld\n", affected); + if (unk) + IUnknown_Release(unk); + + affected = 9999; + hr = ICommandText_SetCommandText(comand_text, &DBGUID_DEFAULT, L"select * from testing"); + ok(hr == S_OK, "got 0x%08x\n", hr); + if (hr == S_OK && unk) + { + ok(affected == 0, "wrong affected value\n"); + + hr = IUnknown_QueryInterface(unk, &IID_IRowset, (void**)&rowset); + ok(hr == S_OK, "got 0x%08x\n", hr); + + IRowset_Release(rowset); + IUnknown_Release(unk); + } + + ICommandText_Release(comand_text); +} + + static void test_sessions(void) { IDBProperties *props; @@ -298,6 +338,7 @@ static void test_sessions(void) test_command_interfaces(cmd); test_command_text(cmd); test_command_dbsession(cmd, session); + test_command_rowset(cmd); IUnknown_Release(cmd); }

1 0