September 2021 - Wine-commits

Nikolay Sivov : msi: Fixup Installer\\Patches\\<...> key path (Coverity).
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: 856e8ea298eebf0eaedd5f352476e6e986b1bd67 URL: https://source.winehq.org/git/wine.git/?a=commit;h=856e8ea298eebf0eaedd5f35… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Sep 14 22:44:50 2021 +0300 msi: Fixup Installer\\Patches\\<...> key path (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/registry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msi/registry.c b/dlls/msi/registry.c index 623bc1866d3..5dc3c0a81c3 100644 --- a/dlls/msi/registry.c +++ b/dlls/msi/registry.c @@ -773,8 +773,8 @@ UINT MSIREG_OpenPatchesKey(LPCWSTR szPatch, HKEY *key, BOOL create) if (!squash_guid( szPatch, squashed_pc )) return ERROR_FUNCTION_FAILED; TRACE("%s squashed %s\n", debugstr_w(szPatch), debugstr_w(squashed_pc)); - swprintf( keypath, ARRAY_SIZE(keypath), L"Software\\Microsoft\\Windows\\CurrentVersion\\Installer\\Patches", - squashed_pc ); + lstrcpyW( keypath, L"Software\\Microsoft\\Windows\\CurrentVersion\\Installer\\Patches\\" ); + lstrcatW( keypath, squashed_pc ); if (create) return RegCreateKeyExW(HKEY_LOCAL_MACHINE, keypath, 0, NULL, 0, access, NULL, key, NULL); return RegOpenKeyExW(HKEY_LOCAL_MACHINE, keypath, 0, access, key);

1 0

Jacek Caban : gdi32: Introduce get_gdi_object_type.
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: a222f974c3144d98d690c1235d5a53c3c39d7334 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a222f974c3144d98d690c123… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Sep 14 21:51:51 2021 +0200 gdi32: Introduce get_gdi_object_type. And use it instead of GetObjectType in ntgdi functions. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/bitblt.c | 2 +- dlls/gdi32/bitmap.c | 4 ++-- dlls/gdi32/dc.c | 6 +++--- dlls/gdi32/dib.c | 4 ++-- dlls/gdi32/gdiobj.c | 5 +++++ dlls/gdi32/ntgdi_private.h | 1 + dlls/gdi32/palette.c | 2 +- dlls/gdi32/path.c | 14 ++++++++------ 8 files changed, 23 insertions(+), 15 deletions(-) diff --git a/dlls/gdi32/bitblt.c b/dlls/gdi32/bitblt.c index cff84bc1dce..0de7932aa95 100644 --- a/dlls/gdi32/bitblt.c +++ b/dlls/gdi32/bitblt.c @@ -866,7 +866,7 @@ BOOL WINAPI NtGdiTransparentBlt( HDC hdcDest, int xDest, int yDest, int widthDes if(oldStretchMode == BLACKONWHITE || oldStretchMode == WHITEONBLACK) SetStretchBltMode(hdcSrc, COLORONCOLOR); hdcWork = NtGdiCreateCompatibleDC( hdcDest ); - if ((GetObjectType( hdcDest ) != OBJ_MEMDC || + if ((get_gdi_object_type( hdcDest ) != NTGDI_OBJ_MEMDC || NtGdiExtGetObjectW( NtGdiGetDCObject( hdcDest, NTGDI_OBJ_SURF ), sizeof(dib), &dib ) == sizeof(BITMAP)) && NtGdiGetDeviceCaps( hdcDest, BITSPIXEL ) == 32) diff --git a/dlls/gdi32/bitmap.c b/dlls/gdi32/bitmap.c index ad04603bf69..4a8b899dd52 100644 --- a/dlls/gdi32/bitmap.c +++ b/dlls/gdi32/bitmap.c @@ -58,7 +58,7 @@ HBITMAP WINAPI NtGdiCreateCompatibleBitmap( HDC hdc, INT width, INT height ) if (!width || !height) return 0; - if (GetObjectType( hdc ) != OBJ_MEMDC) + if (get_gdi_object_type( hdc ) != NTGDI_OBJ_MEMDC) return NtGdiCreateBitmap( width, height, NtGdiGetDeviceCaps( hdc, PLANES ), NtGdiGetDeviceCaps( hdc, BITSPIXEL ), NULL ); @@ -373,7 +373,7 @@ HGDIOBJ WINAPI NtGdiSelectBitmap( HDC hdc, HGDIOBJ handle ) if (!(dc = get_dc_ptr( hdc ))) return 0; - if (GetObjectType( hdc ) != OBJ_MEMDC) + if (get_gdi_object_type( hdc ) != NTGDI_OBJ_MEMDC) { ret = 0; goto done; diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c index f7b56b06f6f..3c84d2024fe 100644 --- a/dlls/gdi32/dc.c +++ b/dlls/gdi32/dc.c @@ -375,7 +375,7 @@ void DC_UpdateXforms( DC *dc ) /* Reselect the font and pen back into the dc so that the size gets updated. */ if (linear_xform_cmp( &oldworld2vport, &dc->xformWorld2Vport ) && - GetObjectType( dc->hSelf ) != OBJ_METADC) + get_gdi_object_type( dc->hSelf ) != NTGDI_OBJ_METADC) { NtGdiSelectFont(dc->hSelf, dc->hFont); NtGdiSelectPen(dc->hSelf, dc->hPen); @@ -1012,7 +1012,7 @@ BOOL WINAPI NtGdiGetDeviceGammaRamp( HDC hdc, void *ptr ) TRACE("%p, %p\n", hdc, ptr); if( dc ) { - if (GetObjectType( hdc ) != OBJ_MEMDC) + if (get_gdi_object_type( hdc ) != NTGDI_OBJ_MEMDC) { PHYSDEV physdev = GET_DC_PHYSDEV( dc, pGetDeviceGammaRamp ); ret = physdev->funcs->pGetDeviceGammaRamp( physdev, ptr ); @@ -1112,7 +1112,7 @@ BOOL WINAPI NtGdiSetDeviceGammaRamp( HDC hdc, void *ptr ) TRACE( "%p, %p\n", hdc, ptr ); if( dc ) { - if (GetObjectType( hdc ) != OBJ_MEMDC) + if (get_gdi_object_type( hdc ) != NTGDI_OBJ_MEMDC) { PHYSDEV physdev = GET_DC_PHYSDEV( dc, pSetDeviceGammaRamp ); diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c index f539df6d41e..9f10f479c2f 100644 --- a/dlls/gdi32/dib.c +++ b/dlls/gdi32/dib.c @@ -1689,8 +1689,8 @@ NTSTATUS WINAPI NtGdiDdDDIDestroyDCFromMemory( const D3DKMT_DESTROYDCFROMMEMORY TRACE("dc %p, bitmap %p.\n", desc->hDc, desc->hBitmap); - if (GetObjectType( desc->hDc ) != OBJ_MEMDC || - GetObjectType( desc->hBitmap ) != OBJ_BITMAP) return STATUS_INVALID_PARAMETER; + if (get_gdi_object_type( desc->hDc ) != NTGDI_OBJ_MEMDC || + get_gdi_object_type( desc->hBitmap ) != NTGDI_OBJ_BITMAP) return STATUS_INVALID_PARAMETER; NtGdiDeleteObjectApp( desc->hBitmap ); NtGdiDeleteObjectApp( desc->hDc ); diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c index 5787231d087..917d1c91f01 100644 --- a/dlls/gdi32/gdiobj.c +++ b/dlls/gdi32/gdiobj.c @@ -816,6 +816,11 @@ void *free_gdi_handle( HGDIOBJ handle ) return object; } +DWORD get_gdi_object_type( HGDIOBJ obj ) +{ + GDI_HANDLE_ENTRY *entry = handle_entry( obj ); + return entry ? entry->ExtType << NTGDI_HANDLE_TYPE_SHIFT : 0; +} /*********************************************************************** * get_any_obj_ptr diff --git a/dlls/gdi32/ntgdi_private.h b/dlls/gdi32/ntgdi_private.h index 7f21608b244..8e122dec6a0 100644 --- a/dlls/gdi32/ntgdi_private.h +++ b/dlls/gdi32/ntgdi_private.h @@ -383,6 +383,7 @@ extern BOOL GDI_dec_ref_count( HGDIOBJ handle ) DECLSPEC_HIDDEN; extern DWORD get_dpi(void) DECLSPEC_HIDDEN; extern DWORD get_system_dpi(void) DECLSPEC_HIDDEN; extern HGDIOBJ get_stock_object( INT obj ) DECLSPEC_HIDDEN; +extern DWORD get_gdi_object_type( HGDIOBJ obj ) DECLSPEC_HIDDEN; /* mapping.c */ extern BOOL dp_to_lp( DC *dc, POINT *points, INT count ) DECLSPEC_HIDDEN; diff --git a/dlls/gdi32/palette.c b/dlls/gdi32/palette.c index e48d4501c6d..c8cd98f6778 100644 --- a/dlls/gdi32/palette.c +++ b/dlls/gdi32/palette.c @@ -518,7 +518,7 @@ HPALETTE WINAPI GDISelectPalette( HDC hdc, HPALETTE hpal, WORD wBkg) TRACE("%p %p\n", hdc, hpal ); - if (GetObjectType(hpal) != OBJ_PAL) + if (get_gdi_object_type(hpal) != NTGDI_OBJ_PAL) { WARN("invalid selected palette %p\n",hpal); return 0; diff --git a/dlls/gdi32/path.c b/dlls/gdi32/path.c index 94c69302d06..cc6c6c714c2 100644 --- a/dlls/gdi32/path.c +++ b/dlls/gdi32/path.c @@ -1627,14 +1627,16 @@ static struct gdi_path *PATH_WidenPath(DC *dc) elp = HeapAlloc( GetProcessHeap(), 0, size ); GetObjectW( dc->hPen, size, elp ); - obj_type = GetObjectType(dc->hPen); - if(obj_type == OBJ_PEN) { + obj_type = get_gdi_object_type(dc->hPen); + switch (obj_type) + { + case NTGDI_OBJ_PEN: penStyle = ((LOGPEN*)elp)->lopnStyle; - } - else if(obj_type == OBJ_EXTPEN) { + break; + case NTGDI_OBJ_EXTPEN: penStyle = elp->elpPenStyle; - } - else { + break; + default: SetLastError(ERROR_CAN_NOT_COMPLETE); HeapFree( GetProcessHeap(), 0, elp ); return NULL;

1 0

Jacek Caban : gdi32: Direcly use ntgdi functions in dib driver.
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: c165a83478a41fab731473828dcc8a2c7db6f7e2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c165a83478a41fab73147382… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Sep 14 21:52:08 2021 +0200 gdi32: Direcly use ntgdi functions in dib driver. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/dibdrv/dc.c | 4 +--- dlls/gdi32/dibdrv/graphics.c | 10 ++++++---- dlls/gdi32/dibdrv/objects.c | 19 ++++++++++++------- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/dlls/gdi32/dibdrv/dc.c b/dlls/gdi32/dibdrv/dc.c index c4474cbb63e..8b2eb6a7480 100644 --- a/dlls/gdi32/dibdrv/dc.c +++ b/dlls/gdi32/dibdrv/dc.c @@ -30,8 +30,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(dib); -extern BOOL WINAPI GdiSetPixelFormat( HDC hdc, INT fmt, const PIXELFORMATDESCRIPTOR *pfd ); - static const struct osmesa_funcs *osmesa_funcs; static const DWORD bit_fields_888[3] = {0xff0000, 0x00ff00, 0x0000ff}; @@ -564,7 +562,7 @@ static BOOL WINAPI dibdrv_wglMakeCurrent( HDC hdc, struct wgl_context *context ) static BOOL WINAPI dibdrv_wglSetPixelFormat( HDC hdc, int fmt, const PIXELFORMATDESCRIPTOR *descr ) { if (fmt <= 0 || fmt > ARRAY_SIZE( pixel_formats )) return FALSE; - return GdiSetPixelFormat( hdc, fmt, descr ); + return NtGdiSetPixelFormat( hdc, fmt ); } /*********************************************************************** diff --git a/dlls/gdi32/dibdrv/graphics.c b/dlls/gdi32/dibdrv/graphics.c index 9bd6dc557a5..9ebcaf7e4a3 100644 --- a/dlls/gdi32/dibdrv/graphics.c +++ b/dlls/gdi32/dibdrv/graphics.c @@ -558,7 +558,7 @@ static struct cached_font *add_cached_font( DC *dc, HFONT hfont, UINT aa_flags ) struct cached_font font, *ptr, *last_unused = NULL; UINT i = 0, j, k; - GetObjectW( hfont, sizeof(font.lf), &font.lf ); + NtGdiExtGetObjectW( hfont, sizeof(font.lf), &font.lf ); font.xform = dc->xformWorld2Vport; font.xform.eDx = font.xform.eDy = 0; /* unused, would break hashing */ if (dc->attr->graphics_mode == GM_COMPATIBLE) @@ -761,7 +761,8 @@ static struct cached_glyph *cache_glyph_bitmap( DC *dc, struct cached_font *font for (i = 0; i < ARRAY_SIZE( indices ); i++) { index = indices[i]; - ret = GetGlyphOutlineW( dc->hSelf, index, ggo_flags, &metrics, 0, NULL, &identity ); + ret = NtGdiGetGlyphOutline( dc->hSelf, index, ggo_flags, &metrics, 0, NULL, + &identity, FALSE ); if (ret != GDI_ERROR) break; } if (ret == GDI_ERROR) return NULL; @@ -776,7 +777,8 @@ static struct cached_glyph *cache_glyph_bitmap( DC *dc, struct cached_font *font if (bit_count == 8) pad = padding[ metrics.gmBlackBoxX % 4 ]; - ret = GetGlyphOutlineW( dc->hSelf, index, ggo_flags, &metrics, size, glyph->bits, &identity ); + ret = NtGdiGetGlyphOutline( dc->hSelf, index, ggo_flags, &metrics, size, glyph->bits, + &identity, FALSE ); if (ret == GDI_ERROR) { HeapFree( GetProcessHeap(), 0, glyph ); @@ -1421,7 +1423,7 @@ BOOL CDECL dibdrv_Rectangle( PHYSDEV dev, INT left, INT top, INT right, INT bott { if (pdev->brush.style != BS_NULL) { - HRGN interior = CreateRectRgnIndirect( &rect ); + HRGN interior = NtGdiCreateRectRgn( rect.left, rect.top, rect.right, rect.bottom ); NtGdiCombineRgn( interior, interior, outline, RGN_DIFF ); brush_region( pdev, interior ); diff --git a/dlls/gdi32/dibdrv/objects.c b/dlls/gdi32/dibdrv/objects.c index e7eff6fdd03..a61ae3e226f 100644 --- a/dlls/gdi32/dibdrv/objects.c +++ b/dlls/gdi32/dibdrv/objects.c @@ -1272,6 +1272,11 @@ static void add_cap( dibdrv_physdev *pdev, HRGN region, HRGN round_cap, const PO #define round( f ) (((f) > 0) ? (f) + 0.5 : (f) - 0.5) +static HRGN create_polygon_region( const POINT *points, INT count, INT mode ) +{ + return create_polypolygon_region( points, &count, 1, mode, NULL ); +} + /******************************************************************************* * create_miter_region * @@ -1326,7 +1331,7 @@ static HRGN create_miter_region( dibdrv_physdev *pdev, const POINT *pt, pts[3] = face_2->end; pts[4] = face_1->end; - return CreatePolygonRgn( pts, 5, ALTERNATE ); + return create_polygon_region( pts, 5, ALTERNATE ); } static void add_join( dibdrv_physdev *pdev, HRGN region, HRGN round_cap, const POINT *pt, @@ -1360,7 +1365,7 @@ static void add_join( dibdrv_physdev *pdev, HRGN region, HRGN round_cap, const P pts[1] = face_2->end; pts[2] = face_1->end; pts[3] = face_2->start; - join = CreatePolygonRgn( pts, 4, ALTERNATE ); + join = create_polygon_region( pts, 4, ALTERNATE ); break; } @@ -1497,7 +1502,7 @@ static BOOL wide_line_segment( dibdrv_physdev *pdev, HRGN total, set_rect( &clip_rect, seg_pts[2].x, seg_pts[3].y, seg_pts[0].x, seg_pts[1].y ); if (clip_rect_to_dib( &pdev->dib, &clip_rect )) { - segment = CreatePolygonRgn( seg_pts, 4, ALTERNATE ); + segment = create_polygon_region( seg_pts, 4, ALTERNATE ); NtGdiCombineRgn( total, total, segment, RGN_OR ); NtGdiDeleteObjectApp( segment ); } @@ -2134,7 +2139,7 @@ HBRUSH CDECL dibdrv_SelectBrush( PHYSDEV dev, HBRUSH hbrush, const struct brush_ TRACE("(%p, %p)\n", dev, hbrush); - GetObjectW( hbrush, sizeof(logbrush), &logbrush ); + NtGdiExtGetObjectW( hbrush, sizeof(logbrush), &logbrush ); if (hbrush == get_stock_object( DC_BRUSH )) logbrush.lbColor = dc->attr->brush_color; @@ -2157,16 +2162,16 @@ HPEN CDECL dibdrv_SelectPen( PHYSDEV dev, HPEN hpen, const struct brush_pattern TRACE("(%p, %p)\n", dev, hpen); - if (!GetObjectW( hpen, sizeof(logpen), &logpen )) + if (!NtGdiExtGetObjectW( hpen, sizeof(logpen), &logpen )) { /* must be an extended pen */ - INT size = GetObjectW( hpen, 0, NULL ); + INT size = NtGdiExtGetObjectW( hpen, 0, NULL ); if (!size) return 0; elp = HeapAlloc( GetProcessHeap(), 0, size ); - GetObjectW( hpen, size, elp ); + NtGdiExtGetObjectW( hpen, size, elp ); logpen.lopnStyle = elp->elpPenStyle; logpen.lopnWidth.x = elp->elpWidth; /* cosmetic ext pens are always 1-pixel wide */

1 0

Jacek Caban : win32u: Use NtGdiSetBrushOrg in NtGdiMaskBlt.
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: ad4f9396e00f473f695e237ded01f461268d201f URL: https://source.winehq.org/git/wine.git/?a=commit;h=ad4f9396e00f473f695e237d… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Sep 14 21:52:23 2021 +0200 win32u: Use NtGdiSetBrushOrg in NtGdiMaskBlt. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/bitblt.c | 2 +- dlls/gdi32/dc.c | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/dlls/gdi32/bitblt.c b/dlls/gdi32/bitblt.c index 0de7932aa95..83ef949ec3f 100644 --- a/dlls/gdi32/bitblt.c +++ b/dlls/gdi32/bitblt.c @@ -810,7 +810,7 @@ BOOL WINAPI NtGdiMaskBlt( HDC hdcDest, INT nXDest, INT nYDest, INT nWidth, INT n /* combine both using the mask as a pattern brush */ NtGdiSelectBrush(hDC2, hbrMask); - SetBrushOrgEx(hDC2, -xMask, -yMask, NULL); + NtGdiSetBrushOrg( hDC2, -xMask, -yMask, NULL ); /* (D & P) | (S & ~P) */ NtGdiBitBlt(hDC2, 0, 0, nWidth, nHeight, hDC1, 0, 0, 0xac0744, 0, 0 ); NtGdiSelectBrush(hDC2, hbrTmp); diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c index 3c84d2024fe..21ca88bab30 100644 --- a/dlls/gdi32/dc.c +++ b/dlls/gdi32/dc.c @@ -884,6 +884,22 @@ BOOL WINAPI NtGdiGetAndSetDCDword( HDC hdc, UINT method, DWORD value, DWORD *pre } +/*********************************************************************** + * NtGdiSetBrushOrg (win32u.@) + */ +BOOL WINAPI NtGdiSetBrushOrg( HDC hdc, INT x, INT y, POINT *oldorg ) +{ + DC *dc; + + if (!(dc = get_dc_ptr( hdc ))) return FALSE; + if (oldorg) *oldorg = dc->attr->brush_org; + dc->attr->brush_org.x = x; + dc->attr->brush_org.y = y; + release_dc_ptr( dc ); + return TRUE; +} + + /*********************************************************************** * NtGdiGetTransform (win32u.@) *

1 0

Jacek Caban : win32u: Directly use NtGdiGetDeviceCaps in ntgdi functions.
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: d3d6b832a3ac1347aa444b87547b81b041631fbf URL: https://source.winehq.org/git/wine.git/?a=commit;h=d3d6b832a3ac1347aa444b87… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Sep 14 21:52:46 2021 +0200 win32u: Directly use NtGdiGetDeviceCaps in ntgdi functions. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/bitmap.c | 2 +- dlls/gdi32/clipping.c | 4 ++-- dlls/gdi32/dc.c | 8 ++++---- dlls/gdi32/driver.c | 30 +++++++++++++++--------------- dlls/gdi32/mapping.c | 12 ++++++------ dlls/gdi32/palette.c | 7 +++---- 6 files changed, 31 insertions(+), 32 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=d3d6b832a3ac1347aa44…

1 0

Jacek Caban : gdi32: Directly use ntgdi functions in painting.c.
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: 9f88685f5460da2bf6e39f24191a6b65be7baec8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9f88685f5460da2bf6e39f24… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Sep 14 21:52:55 2021 +0200 gdi32: Directly use ntgdi functions in painting.c. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/painting.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c index a7f06ea7df3..dba91daf788 100644 --- a/dlls/gdi32/painting.c +++ b/dlls/gdi32/painting.c @@ -40,13 +40,17 @@ WINE_DEFAULT_DEBUG_CHANNEL(gdi); BOOL CDECL nulldrv_AngleArc( PHYSDEV dev, INT x, INT y, DWORD radius, FLOAT start, FLOAT sweep ) { + DC *dc = get_physdev_dc( dev ); INT x1 = GDI_ROUND( x + cos( start * M_PI / 180 ) * radius ); INT y1 = GDI_ROUND( y - sin( start * M_PI / 180 ) * radius ); INT x2 = GDI_ROUND( x + cos( (start + sweep) * M_PI / 180) * radius ); INT y2 = GDI_ROUND( y - sin( (start + sweep) * M_PI / 180) * radius ); - INT arcdir = SetArcDirection( dev->hdc, sweep >= 0 ? AD_COUNTERCLOCKWISE : AD_CLOCKWISE ); - BOOL ret = ArcTo( dev->hdc, x - radius, y - radius, x + radius, y + radius, x1, y1, x2, y2 ); - SetArcDirection( dev->hdc, arcdir ); + INT arcdir = dc->attr->arc_direction; + BOOL ret; + dc->attr->arc_direction = sweep >= 0 ? AD_COUNTERCLOCKWISE : AD_CLOCKWISE; + ret = NtGdiArcInternal( NtGdiArcTo, dev->hdc, x - radius, y - radius, x + radius, y + radius, + x1, y1, x2, y2 ); + dc->attr->arc_direction = arcdir; return ret; } @@ -64,9 +68,10 @@ BOOL CDECL nulldrv_ArcTo( PHYSDEV dev, INT left, INT top, INT right, INT bottom, if (!height || !width) return FALSE; /* draw a line from the current position to the starting point of the arc, then draw the arc */ angle = atan2( (ystart - ycenter) / height, (xstart - xcenter) / width ); - LineTo( dev->hdc, GDI_ROUND( xcenter + cos(angle) * xradius ), - GDI_ROUND( ycenter + sin(angle) * yradius )); - return Arc( dev->hdc, left, top, right, bottom, xstart, ystart, xend, yend ); + NtGdiLineTo( dev->hdc, GDI_ROUND( xcenter + cos(angle) * xradius ), + GDI_ROUND( ycenter + sin(angle) * yradius )); + return NtGdiArcInternal( NtGdiArc, dev->hdc, left, top, right, bottom, + xstart, ystart, xend, yend ); } BOOL CDECL nulldrv_FillRgn( PHYSDEV dev, HRGN rgn, HBRUSH brush ) @@ -99,9 +104,12 @@ BOOL CDECL nulldrv_FrameRgn( PHYSDEV dev, HRGN rgn, HBRUSH brush, INT width, INT BOOL CDECL nulldrv_InvertRgn( PHYSDEV dev, HRGN rgn ) { - INT prev_rop = SetROP2( dev->hdc, R2_NOT ); - BOOL ret = NtGdiFillRgn( dev->hdc, rgn, get_stock_object(BLACK_BRUSH) ); - SetROP2( dev->hdc, prev_rop ); + DC *dc = get_physdev_dc( dev ); + INT prev_rop = dc->attr->rop_mode; + BOOL ret; + dc->attr->rop_mode = R2_NOT; + ret = NtGdiFillRgn( dev->hdc, rgn, get_stock_object(BLACK_BRUSH) ); + dc->attr->rop_mode = prev_rop; return ret; }

1 0

Nikolay Sivov : inetcpl: Fix incorrect expression (Coverity).
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: fec56bb4570ce50d3c4746fa3fc30511973fc12c URL: https://source.winehq.org/git/wine.git/?a=commit;h=fec56bb4570ce50d3c4746fa… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 15 13:25:06 2021 +0300 inetcpl: Fix incorrect expression (Coverity). This is a regression from a65616cf1fcf404090199b82e6d01e0f08e0d4ea, search-replace gone wrong because global literal constant had the same name as the helper argument. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/inetcpl.cpl/connections.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/inetcpl.cpl/connections.c b/dlls/inetcpl.cpl/connections.c index 4327c33b420..d33c0bf3a19 100644 --- a/dlls/inetcpl.cpl/connections.c +++ b/dlls/inetcpl.cpl/connections.c @@ -62,7 +62,7 @@ static DWORD create_connection_settings(BOOL manual_proxy, const WCHAR *proxy_se DWORD pac_url_len; size += sizeof(DWORD); - if(L"ProxyServer") + if(proxy_server) { proxy_server_len = WideCharToMultiByte(CP_UTF8, 0, proxy_server, -1, NULL, 0, NULL, NULL);

1 0

Nikolay Sivov : gdi32: Fix a typo in failure path (Coverity).
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: 2b99a4ebb9ceeb3e4d9ac6a6cdabb7817ffc6ef4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2b99a4ebb9ceeb3e4d9ac6a6… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 15 15:16:26 2021 +0300 gdi32: Fix a typo in failure path (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c index 1c304f008a7..ec1699533c7 100644 --- a/dlls/gdi32/dc.c +++ b/dlls/gdi32/dc.c @@ -125,7 +125,7 @@ DC *alloc_dc_ptr( DWORD magic ) if (!(dc = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*dc) ))) return NULL; if (!(dc->attr = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*dc->attr)))) { - HeapFree( GetProcessHeap(), 0, dc->attr ); + HeapFree( GetProcessHeap(), 0, dc ); return NULL; }

1 0

Nikolay Sivov : msvcrt: Use free() on msvcrt_wstrdupa() results (Coverity).
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: 0eaa43f6afa4e4c407b6c036c153e01719bc018b URL: https://source.winehq.org/git/wine.git/?a=commit;h=0eaa43f6afa4e4c407b6c036… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Sep 14 23:11:48 2021 +0300 msvcrt: Use free() on msvcrt_wstrdupa() results (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/process.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/process.c b/dlls/msvcrt/process.c index cf1dcd3d279..a5f8f0bca3d 100644 --- a/dlls/msvcrt/process.c +++ b/dlls/msvcrt/process.c @@ -1165,14 +1165,14 @@ FILE* CDECL _popen(const char* command, const char* mode) if (!(cmdW = msvcrt_wstrdupa(command))) return NULL; if (!(modeW = msvcrt_wstrdupa(mode))) { - HeapFree(GetProcessHeap(), 0, cmdW); + free(cmdW); return NULL; } ret = _wpopen(cmdW, modeW); - HeapFree(GetProcessHeap(), 0, cmdW); - HeapFree(GetProcessHeap(), 0, modeW); + free(cmdW); + free(modeW); return ret; } @@ -1274,7 +1274,7 @@ int CDECL system(const char* cmd) if ((cmdW = msvcrt_wstrdupa(cmd))) { res = _wsystem(cmdW); - HeapFree(GetProcessHeap(), 0, cmdW); + free(cmdW); } return res; }

1 0

Nikolay Sivov : secur32: Fix allocation size (Coverity).
by Alexandre Julliard 15 Sep '21

15 Sep '21

Module: wine Branch: master Commit: 37bc7518b8402706537b7854516a409a435bebac URL: https://source.winehq.org/git/wine.git/?a=commit;h=37bc7518b8402706537b7854… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 15 13:31:03 2021 +0300 secur32: Fix allocation size (Coverity). Fixes copy-paste issue from fbd30fff038645bf2f7967ff63d4178309a14138. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/secur32/secur32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/secur32/secur32.c b/dlls/secur32/secur32.c index 08bac24686a..a20469a3ff3 100644 --- a/dlls/secur32/secur32.c +++ b/dlls/secur32/secur32.c @@ -365,7 +365,7 @@ SecureProvider *SECUR32_addProvider(const SecurityFunctionTableA *fnTableA, if (!providerTable) { - if (!(providerTable = malloc(sizeof(*ret)))) + if (!(providerTable = malloc(sizeof(*providerTable)))) { LeaveCriticalSection(&cs); return NULL;

1 0