January 2005 - Wine-devel - list.winehq.org

Re: Minor wine-devel DCOM corrections
by Dan Kegel 11 Jan '05

11 Jan '05

Rob Shearman wrote: > We have a number of marshaling tests in our test framework at the moment > (in wine/dlls/ole32/tests/marshal.c). It is hard to do anything > cross-process (or cross-machine!) because of the way the test framework > is done. Mike did suggest using environment variables to hack around > those limitations, but so far that hasn't turned into any code from > either of us. Hey, that's not a bad idea. You could set an environment variable, then rerun the same program with the same arguments, and your test could sense the environment variable and run the 2nd process's test role. Is there a generic win32 way to run yourself again with the same arguments? If not, it'd probably only take a little tweaking of include/wine/test.h to set one up... - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Re: Correction to COINIT_MULTITHREADED test
by Paul Vriens 11 Jan '05

11 Jan '05

On Mon, 2005-01-10 at 21:20, Bill Medland wrote: > Bill Medland (billmedland(a)mercuryspeed.com) > Correct testing for multithreaded > (as spotted by Paul Vriens; fix suggested by Robert Shearman) > Hi Bill, it wasn't the check that was way over my head. The thing is, that with this code change we walk a new path in COM_CreateApartment. I don't know what the result is but in CoInitializeEx we do: 545 if (!(apt = COM_CurrentInfo()->apt)) 546 { 547 apt = COM_CreateApartment(dwCoInit); 548 if (!apt) return E_OUTOFMEMORY; 549 } and apparently that leaves us with a E_OUTOFMEMORY all the time. Which means that we will not come to the part: 559 COM_CurrentInfo()->inits++; and that leads to errors as: trace:ole:CoInitializeEx ((nil), 4) trace:ole:COM_CreateApartment thread 0xd is entering the multithreaded apartment trace:ole:CoInitializeEx ((nil), 2) err:ole:CoInitializeEx Attempt to change threading model of this apartment from 0x0 to 0x2 which also shows that the check is wrong. When CoInitializeEx is called with COINIT_DISABLE_OLE1DDE it shouldn't go in. What MSDN also says is: Any combination of values from the COINIT enumeration can be used, except that the COINIT_APARTMENTTHREADED and COINIT_MULTITHREADED flags cannot both be set. So should that be accounted for as well? Cheers, Paul.

1 0

comctl32.dll and commctrl.dll
by Dripple 11 Jan '05

11 Jan '05

Hi all, I'm a newbie in wine using and wine developpement. I just need information about comctl32.dll and commctrl.dll. I'm trying to have this app (http://appdb.winehq.org/appview.php?appId=1485&versionId=2451) working. In fact, it works. But only using native comctl32.dll, which requires native commctrl.dll. Can anybody explain me what's missing in buitlin comctl32.dll and/or commctrl.dll ? Is it planned to fix commctrl.dll, to avoid piracy ? Thanks. Dripple

5 7

Re: advpack: add two missing stubs
by Robert Reif 11 Jan '05

11 Jan '05

Rob Shearman wrote: > > I think you forgot to include the tests. > > Rob > Past my bed time. diff -u -N wine.cvs/dlls/advpack/tests/advpack.c wine/dlls/advpack/tests/advpack.c --- wine.cvs/dlls/advpack/tests/advpack.c 1969-12-31 19:00:00.000000000 -0500 +++ wine/dlls/advpack/tests/advpack.c 2005-01-10 22:54:50.000000000 -0500 @@ -0,0 +1,66 @@ +/* + * Unit tests for advpack.dll + * + * Copyright (c) 2005 Robert Reif + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#define NONAMELESSSTRUCT +#define NONAMELESSUNION +#include <windows.h> + +#include "wine/test.h" +#include "advpub.h" + +static void version_test() +{ + HRESULT hr; + DWORD major, minor; + + major = minor = 0; + hr = GetVersionFromFile("kernel32.dll", &major, &minor, FALSE); + ok (hr == S_OK, "GetVersionFromFileEx(kernel32.dll) failed, returned " + "0x%08lx\n", hr); + + trace("kernel32.dll Language ID: 0x%08lx, Codepage ID: 0x%08lx\n", + major, minor); + + major = minor = 0; + hr = GetVersionFromFile("kernel32.dll", &major, &minor, TRUE); + ok (hr == S_OK, "GetVersionFromFileEx(kernel32.dll) failed, returned " + "0x%08lx\n", hr); + + trace("kernel32.dll version: %d.%d.%d.%d\n", HIWORD(major), LOWORD(major), + HIWORD(minor), LOWORD(minor)); +} + +static void admin_test() +{ + BOOL res; + DWORD reserved; + + res = IsNTAdmin(0, &reserved); + ok (res == TRUE || res == FALSE, "IsNTAdmin returned: 0x%08x\n", res); + + trace("IsNTAdmin = %s\n", res == TRUE ? "TRUE" : res == FALSE ? "FALSE" : + "???"); +} + +START_TEST(advpack) +{ + version_test(); + admin_test(); +} diff -u -N wine.cvs/dlls/advpack/tests/.cvsignore wine/dlls/advpack/tests/.cvsignore --- wine.cvs/dlls/advpack/tests/.cvsignore 1969-12-31 19:00:00.000000000 -0500 +++ wine/dlls/advpack/tests/.cvsignore 2005-01-10 21:17:35.000000000 -0500 @@ -0,0 +1,3 @@ +Makefile +advpack.ok +testlist.c diff -u -N wine.cvs/dlls/advpack/tests/Makefile.in wine/dlls/advpack/tests/Makefile.in --- wine.cvs/dlls/advpack/tests/Makefile.in 1969-12-31 19:00:00.000000000 -0500 +++ wine/dlls/advpack/tests/Makefile.in 2005-01-10 21:07:22.000000000 -0500 @@ -0,0 +1,13 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +TESTDLL = advpack.dll +IMPORTS = advpack user32 kernel32 version + +CTESTS = \ + advpack.c + +(a)MAKE_TEST_RULES@ + +### Dependencies:

1 0

Re: [LOSTWAGES] Add regedit janitorial project
by Michael Stefaniuc 10 Jan '05

10 Jan '05

Mike McCormack wrote: > > ChangeLog: > * Add regedit janitorial project > > ------------------------------------------------------------------------ > > > Janitorial Projects > > Any self respecting project has a Janitorial project (e.g. Kernel > Janitor's List <http://janitor.kernelnewbies.org>), and it's high time > that we have one too. What is there to clean up? Well, lots of things! :) > > > Regedit fixes > > Regedit lacks a few features. We need to improve regedit to: > > * Allow display and editting of binary (REG_BINARY) values. > * Allow display and editting of multi-string (REG_SZ_MULTI) values. > * Import registry files regerated by Windows 2000 regedit Are you sure this is a janitorial project? It sounds to me more like a normal development work and not janitorial. It would better fit into "tasks" or the "todo" lists. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

4 4

Fwd: Foobar2000 audio player Regression
by Nick Hornback 10 Jan '05

10 Jan '05

I originally posted this to the -users list, but I was contacted by Robbert Xerox, who had the exact same issue, and thus far nobody has replyed in the users list, so maybe it will get more attention here. > Foobar2000 worked virtually perfectly in the 20041019 > release (aside from some comctrl32 repainting issues > -- which native comctrl32.dll fixed), but in 20041201 > it is completely unuseable. Two major problems: > 1) The toolbars are completely gone. They are sort-of > displayed when they get activity via mouse-press or > whatever, but they do not repaint correctly at all. > See this screenshot for details: > http://img20.exs.cx/my.php?loc=img20&image=w1ifoobar.gif > 2) It takes 100% cpu. In the 20041021 release, it > hovered around 5% cpu (on my athlon 64 3200+), which > was excellent because that beat most native linux > audio players. > The console log is as follows (no errors or warnings): > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,2)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002a,-4,0)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002c,-4,0)-stub! > fixme:win:SetWindowTextA cannot set text "" of other > process window (nil) > Does anyone know what is going on here? I have since found out that if you use a the builtin comctrl32.dll, none of the window repaints at all. In previous wine releases, using the builtin comctrl32.dll would just create minor glitches (ex. the status bar wouldn't update). __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

4 6

RtlQueryRegistryValues implementation, probably not prefect but makes safedisc happy
by Ivan Leo Puoti 10 Jan '05

10 Jan '05

I've attempted to implement RtlQueryRegistryValues() This code is probably buggy, as I haven't tested it much, but it makes safedisc happy. If it's OK I'll send a patch to add it to ntdll, ntoskrnl will then forward calls. comments/corrections/thoughts welcome. Ivan.

1 0

Warnings left when compiling on GNU/Linux
by Gerald Pfeifer 10 Jan '05

10 Jan '05

When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS: metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one: fd.c:572: warning: right shift count >= width of type fd.c:574: warning: right shift count >= width of type Any chance we could get rid of these? :-) Gerald

5 5

ole32 : wrong check in compobj.c
by Paul Vriens 10 Jan '05

10 Jan '05

Hi, while looking through the code I saw: if (model & COINIT_MULTITHREADED) this will never work as COINIT_MULTITHREADED = 0. The attached patch fixes the 3 occurrences of a check against COINIT_*. This patch however makes the COM_CreateApartment in compobj.c: 545 if (!(apt = COM_CurrentInfo()->apt)) 546 { 547 apt = COM_CreateApartment(dwCoInit); 548 if (!apt) return E_OUTOFMEMORY; 549 } return E_OUTOFMEMORY, always (?). And that makes sure that we have a mismatch between CoInitialize and CoUninitialize. So there's definitely something else wrong as well. Any idea ? Cheers, Paul.

3 4

Re: Minor wine-devel DCOM corrections
by Mike Hearn 10 Jan '05

10 Jan '05

On Mon, 10 Jan 2005 10:56:30 -0800, Bill Medland wrote: > Bill Medland (billmedland(a)mercuryspeed.com) > Minor typo correction and term expansion changes Bill, if that document was helpful I'll write some more docs for you.

3 3