January 2005 - Wine-devel - list.winehq.org

Use Interlocked* functions
by Joris Huizer 10 Jan '05

10 Jan '05

To see how far we are, I tried grepping to get This->refs stuff grep -r -n -e 'TRACE(.*This->ref)' * grep -r -n "++(This->ref)" * grep -r -n -- "--(This->ref)" * I hope there are a lot of false positives there :-/ regards, Joris

5 7

Re: ntdll / kernel32 : #52 (take #2)
by Alexandre Julliard 10 Jan '05

10 Jan '05

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > +/****************************************************************** > + * NtAddAtom (NTDLL.@) > + */ > +NTSTATUS WINAPI NtAddAtom( const WCHAR* name, ULONG name_len, ATOM* atom ) > +{ > + return RtlAddAtomToAtomTable( get_global_table(), name, atom ); > +} You can't do that, if the name is a counted string you cannot ignore the length and assume it is null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Give a more informative error when a DLL fails to initialize
by Mike Hearn 10 Jan '05

10 Jan '05

Hi Alexandre, This patch was missed, does it no longer apply? Also is it OK to just put the changelog as the first line of the email like that? thanks -mike On Wed, 22 Dec 2004 18:19:47 +0000, Mike Hearn wrote: > Give a more informative error when a DLL fails to initialize > --- dlls/ntdll/loader.c (revision 3) > +++ dlls/ntdll/loader.c (local) > @@ -893,9 +893,14 @@ static NTSTATUS process_attach( WINE_MOD > WINE_MODREF *prev = current_modref; > current_modref = wm; > if (MODULE_InitDLL( wm, DLL_PROCESS_ATTACH, lpReserved )) > + { > wm->ldr.Flags |= LDR_PROCESS_ATTACHED; > + } > else > + { > + ERR("Initialization of %s failed\n", debugstr_w(wm->ldr.BaseDllName.Buffer)); > status = STATUS_DLL_INIT_FAILED; > + } > current_modref = prev; > }

3 4

Re: WININET: implement InternetTime{From,To}SystemTime{A,W} (#2)
by Dmitry Timoshkov 10 Jan '05

10 Jan '05

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > Changelog: > Implement and test InternetTime{From,To}SystemTime{A,W}. If you could also make the attached tests pass (applied over your tests) that would be great. The tests show that strings should be parsed a bit smarter and comparisons should be case insensitive. -- Dmitry.

1 0

Re: Janitorial : Use Compiler Warnings ( -Wmissing-declarations ) ( #1 )
by Alexandre Julliard 10 Jan '05

10 Jan '05

Rémi Assailly <remi.assailly(a)free.fr> writes: > --- include/wine/library.h 2005-01-07 19:41:26.000000000 +0100 > +++ include/wine/library.h 2005-01-07 19:49:41.389057824 +0100 > @@ -42,6 +42,7 @@ > extern void *wine_dlopen( const char *filename, int flag, char *error, int errorsize ); > extern void *wine_dlsym( void *handle, const char *symbol, char *error, int errorsize ); > extern int wine_dlclose( void *handle, char *error, int errorsize ); > +extern void __wine_dll_register( const IMAGE_NT_HEADERS *header, const char *filename ); Functions starting with '__wine' are internal only and must not be declared in the public headers if it can be avoided. -- Alexandre Julliard julliard(a)winehq.org

2 2

Switching to winecfg
by Crestez Leonard 10 Jan '05

10 Jan '05

As winecfg gets better and better I think it's time to consider making it actually change the config file. I made a patch for it, but it's a work in progress, and not ready for general use. I don't expect you to commit it, so I sent it here for discussion. I don't think that this needs a complex migration process, all we need to do is save the wine config registry to $WINEPREFIX/config. If people want their config file back, wine can skip saving the configuration if it wasn't modified. This will allow comments to persist in the config file. Anyway, regedit is better than editing a config file. In writing this patch I came across some strange stuff in server/registry.c. What's the point of all the save level stuff? current_level is only set once to 1, on initialization, and save_level depends on whether registry branches should be saved only when modified (can anyone think of a reason to disable that feature?). Can't the KEY_DIRTY bit be used instead of this level stuff? Also update_level seems to be dead code, not called from anywhere. Please tell me what you think about the patch. -- Crestez Leonard <cleonard(a)go.ro>

2 1

Re: WININET: implement InternetTime{From,To}SystemTime{A,W} (#2)
by Alexandre Julliard 10 Jan '05

10 Jan '05

Hans Leidekker <hans(a)it.vu.nl> writes: > +/*********************************************************************** > + * InternetTimeFromSystemTimeW (WININET.@) > + * > + * NOTES > + * This is not an illegal W->A crosscall since internet dates are ASCII strings. It would still be much cleaner to have the A function call the W one. -- Alexandre Julliard julliard(a)winehq.org

1 0

typelib2.c problems
by Gerald Pfeifer 10 Jan '05

10 Jan '05

The following change to dlls/oleaut32/typelib2.c revision 1.32 date: 2005/01/09 17:32:17; author: julliard; state: Exp; lines: +14 -14 Paul Vriens <Paul.Vriens(a)xs4all.nl> - use Interlocked* functions in AddRef and Release. - store the result of the Interlocked functions and use only this. causes the following warnings on SUSE LINUX 9.2 and FreeBSD: typelib2.c:3012: warning: passing arg 1 of `InterlockedIncrement' from incompatible pointer type typelib2.c:3027: warning: passing arg 1 of `InterlockedDecrement' from incompatible pointer type Would you mind fixing this? Gerald

1 0

dcom95.exe removed from sf.net
by Jeremy Newman 10 Jan '05

10 Jan '05

Somebody removed dcom95.exe from sf.net. Was there a reason for that? We really need to keep that file mirrored. It's an essential file for many programs to run under wine. I've re-added the file as a hidden file for the moment. It won't show up in the download list, but we can still link to it.

8 18

Re: German language files
by Mike McCormack 10 Jan '05

10 Jan '05

Thanks for the translations, however please read: http://www.winehq.org/site/sending_patches You should send patches, not zip files. Diff against the current WineHQ CVS, not ReactOS. Diff new files against /dev/null. eg. diff /dev/null dlls/shell32/shell32_De.rc Your changes are unlikely to be accepted as they are. There's only one person processing WineHQ patches. If you keep the submissions uniform it reduces his workload. Mike Klemens Friedl wrote:> > Please add the files to the wine directory. Thanks! > > > Klemens Friedl <frik85>

1 0