July 2005 - Wine-devel - list.winehq.org

Re: opengl32: fix lots of missings-declarations warnings (reworked)
by Alexandre Julliard 24 Jul '05

24 Jul '05

Stefan Huehner <stefan(a)huehner.org> writes: > [old message] > this patch adds prototypes for the functions in opengl_norm.c which are > prefixed with 'wine_'. As this file is generated from the make_opengl > script this was also modified to emit this additional lines as it > already did for opengl_ext.c. This patch fixes 374 missing-declarations > warnings. At the cost of adding 374 useless prototypes... We really don't want to do that, it's perfectly legitimate in that case that the functions don't have a declaration, that's why the warning is not turned on by default. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [WineD3D] prepare VBO
by Oliver Stieber 23 Jul '05

23 Jul '05

--- Raphael <fenix(a)club-internet.fr> wrote: > Hi, > > Changelog: > - add a new settings for vbo support > - use a struct to handle wined3d settings > - prepare VBO using some abstraction APIs > Just a couple of queries.. Why are you passing the offset to GetMemory? I can't see there ever being a need for it IWineD3DVertexBufferImpl_GetMemory(foo) + offset should be fine > }; > + > +BYTE* WINAPI IWineD3DVertexBufferImpl_GetMemory(IWineD3DVertexBuffer* iface, DWORD iOffset) { > + IWineD3DVertexBufferImpl *This = (IWineD3DVertexBufferImpl *)iface; > + > + return This->resource.allocatedMemory + iOffset; > +} > + > +HRESULT WINAPI IWineD3DVertexBufferImpl_ReleaseMemory(IWineD3DVertexBuffer* iface) { > + return D3D_OK; > +} ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

1 0

Re: [WineD3D] prepare VBO
by Oliver Stieber 23 Jul '05

23 Jul '05

--- Raphael <fenix(a)club-internet.fr> wrote: > Hi, > > Changelog: > - add a new settings for vbo support > - use a struct to handle wined3d settings > - prepare VBO using some abstraction APIs I should have added, this patch is good to go in though.... > > Regards, > Raphael > > ? wined3d.spec.def > Index: directx.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/directx.c,v > retrieving revision 1.41 > diff -u -r1.41 directx.c > --- directx.c 13 Jul 2005 19:38:40 -0000 1.41 > +++ directx.c 22 Jul 2005 19:52:14 -0000 > @@ -1455,7 +1455,7 @@ > *pCaps->MaxStreams = MAX_STREAMS; > *pCaps->MaxStreamStride = 1024; > > - if (((vs_mode == VS_HW) && GL_SUPPORT(ARB_VERTEX_PROGRAM)) || (vs_mode == VS_SW) || > (DeviceType == D3DDEVTYPE_REF)) { > + if (((wined3d_settings.vs_mode == VS_HW) && GL_SUPPORT(ARB_VERTEX_PROGRAM)) || > (wined3d_settings.vs_mode == VS_SW) || (DeviceType == D3DDEVTYPE_REF)) { > *pCaps->VertexShaderVersion = D3DVS_VERSION(1,1); > > if (This->gl_info.gl_vendor == VENDOR_MESA || > @@ -1469,7 +1469,7 @@ > *pCaps->MaxVertexShaderConst = 0; > } > > - if ((ps_mode == PS_HW) && GL_SUPPORT(ARB_FRAGMENT_PROGRAM) && (DeviceType != > D3DDEVTYPE_REF)) { > + if ((wined3d_settings.ps_mode == PS_HW) && GL_SUPPORT(ARB_FRAGMENT_PROGRAM) && (DeviceType > != D3DDEVTYPE_REF)) { > *pCaps->PixelShaderVersion = D3DPS_VERSION(1,4); > *pCaps->PixelShader1xMaxValue = 1.0; > } else { > Index: drawprim.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/drawprim.c,v > retrieving revision 1.20 > diff -u -r1.20 drawprim.c > --- drawprim.c 22 Jul 2005 18:27:04 -0000 1.20 > +++ drawprim.c 22 Jul 2005 19:52:19 -0000 > @@ -365,8 +365,8 @@ > TRACE("Stream is up %d, %p\n", element->Stream, > This->stateBlock->streamSource[element->Stream]); > data = (BYTE *)This->stateBlock->streamSource[element->Stream]; > } else { > - TRACE("Stream isn't up %d, %p\n", element->Stream, > This->stateBlock->streamSource[element->Stream]); > - data = ((IWineD3DVertexBufferImpl > *)This->stateBlock->streamSource[element->Stream])->resource.allocatedMemory; > + TRACE("Stream isn't up %d, %p\n", element->Stream, > This->stateBlock->streamSource[element->Stream]); > + data = > IWineD3DVertexBufferImpl_GetMemory(This->stateBlock->streamSource[element->Stream], 0); > } > stride = This->stateBlock->streamStride[element->Stream]; > data += (BaseVertexIndex * stride); > @@ -571,12 +571,12 @@ > if (This->stateBlock->streamIsUP) { > data = (BYTE *)This->stateBlock->streamSource[nStream]; > } else { > - data = ((IWineD3DVertexBufferImpl > *)This->stateBlock->streamSource[nStream])->resource.allocatedMemory; > + data = > IWineD3DVertexBufferImpl_GetMemory(This->stateBlock->streamSource[nStream], 0); > } > } else { > #if 0 /* TODO: Vertex shader support */ > thisFVF = This->stateBlock->vertexShaderDecl->fvf[nStream]; > - data = ((IDirect3DVertexBuffer8Impl > *)This->stateBlock->streamSource[nStream])->allocatedMemory; > + data = > IWineD3DVertexBufferImpl_GetMemory(This->stateBlock->streamSource[nStream], 0); > #endif > } > VTRACE(("FVF for stream %d is %lx\n", nStream, thisFVF)); > Index: vertexbuffer.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/vertexbuffer.c,v > retrieving revision 1.13 > diff -u -r1.13 vertexbuffer.c > --- vertexbuffer.c 13 Jul 2005 14:15:54 -0000 1.13 > +++ vertexbuffer.c 22 Jul 2005 19:52:19 -0000 > @@ -1,8 +1,8 @@ > /* > * IWineD3DVertexBuffer Implementation > * > - * Copyright 2002-2004 Jason Edmeades > - * Copyright 2003-2004 Raphael Junqueira > + * Copyright 2002-2005 Jason Edmeades > + * Raphael Junqueira > * Copyright 2004 Christian Costa > * > * This library is free software; you can redistribute it and/or > @@ -149,3 +149,13 @@ > IWineD3DVertexBufferImpl_Unlock, > IWineD3DVertexBufferImpl_GetDesc > }; > + > +BYTE* WINAPI IWineD3DVertexBufferImpl_GetMemory(IWineD3DVertexBuffer* iface, DWORD iOffset) { > + IWineD3DVertexBufferImpl *This = (IWineD3DVertexBufferImpl *)iface; > + > + return This->resource.allocatedMemory + iOffset; > +} > + > +HRESULT WINAPI IWineD3DVertexBufferImpl_ReleaseMemory(IWineD3DVertexBuffer* iface) { > + return D3D_OK; > +} > Index: wined3d_main.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/wined3d_main.c,v > retrieving revision 1.11 > diff -u -r1.11 wined3d_main.c > --- wined3d_main.c 22 Jul 2005 18:26:05 -0000 1.11 > +++ wined3d_main.c 22 Jul 2005 19:52:19 -0000 > @@ -30,8 +30,14 @@ > int num_lock = 0; > void (*wine_tsx11_lock_ptr)(void) = NULL; > void (*wine_tsx11_unlock_ptr)(void) = NULL; > -int vs_mode = VS_HW; /* Hardware by default */ > -int ps_mode = PS_NONE; /* Disabled by default */ > + > + > +wined3d_settings_t wined3d_settings = > +{ > + VS_HW, /* Hardware by default */ > + PS_NONE, /* Disabled by default */ > + VBO_HW /* Hardware by default */ > +}; > > WineD3DGlobalStatistics *wineD3DGlobalStatistics = NULL; > CRITICAL_SECTION resourceStoreCriticalSection; > @@ -128,12 +134,12 @@ > if (!strcmp(buffer,"none")) > { > TRACE("Disable vertex shaders\n"); > - vs_mode = VS_NONE; > + wined3d_settings.vs_mode = VS_NONE; > } > else if (!strcmp(buffer,"emulation")) > { > TRACE("Force SW vertex shaders\n"); > - vs_mode = VS_SW; > + wined3d_settings.vs_mode = VS_SW; > } > } > if ( !get_config_key( hkey, appkey, "PixelShaderMode", buffer, size) ) > @@ -141,14 +147,34 @@ > if (!strcmp(buffer,"enabled")) > { > TRACE("Allow pixel shaders\n"); > - ps_mode = PS_HW; > + wined3d_settings.ps_mode = PS_HW; > + } > + if (!strcmp(buffer,"disabled")) > + { > + TRACE("Disable pixel shaders\n"); > + wined3d_settings.ps_mode = PS_NONE; > + } > + } > + if ( !get_config_key( hkey, appkey, "VertexBufferMode", buffer, size) ) > + { > + if (!strcmp(buffer,"none")) > + { > + TRACE("Disable Vertex Buffer Hardware support\n"); > + wined3d_settings.vbo_mode = VS_NONE; > + } > + else if (!strcmp(buffer,"hardware")) > + { > + TRACE("Allow Vertex Buffer Hardware support\n"); > + wined3d_settings.vbo_mode = VS_HW; > } > } > } > - if (vs_mode == VS_HW) > + if (wined3d_settings.vs_mode == VS_HW) > TRACE("Allow HW vertex shaders\n"); > - if (ps_mode == PS_NONE) > + if (wined3d_settings.ps_mode == PS_NONE) > TRACE("Disable pixel shaders\n"); > + if (wined3d_settings.vbo_mode == VBO_NONE) > + TRACE("Disable Vertex Buffer Hardware support\n"); > > if (appkey) RegCloseKey( appkey ); > if (hkey) RegCloseKey( hkey ); > Index: wined3d_private.h > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/wined3d_private.h,v > retrieving revision 1.42 > diff -u -r1.42 wined3d_private.h > --- wined3d_private.h 22 Jul 2005 09:06:03 -0000 1.42 > +++ wined3d_private.h 22 Jul 2005 19:52:20 -0000 > @@ -69,16 +69,28 @@ > extern const DWORD SavedVertexStates_T[NUM_SAVEDVERTEXSTATES_T]; > extern const DWORD SavedVertexStates_S[NUM_SAVEDVERTEXSTATES_S]; > > -/* vertex and pixel shader modes */ > -extern int vs_mode; > +/** > + * Settings > + */ > #define VS_NONE 0 > #define VS_HW 1 > #define VS_SW 2 > > -extern int ps_mode; > #define PS_NONE 0 > #define PS_HW 1 > > +#define VBO_NONE 0 > +#define VBO_HW 1 > + > +typedef struct wined3d_settings_s { > +/* vertex and pixel shader modes */ > + int vs_mode; > + int ps_mode; > + int vbo_mode; > +} wined3d_settings_t; > + > +extern wined3d_settings_t wined3d_settings; > + > /* X11 locking */ > > extern void (*wine_tsx11_lock_ptr)(void); > @@ -979,6 +991,9 @@ > extern void WINAPI IWineD3DBaseTextureImpl_GenerateMipSubLevels(IWineD3DBaseTexture > *iface); > extern BOOL WINAPI IWineD3DBaseTextureImpl_SetDirty(IWineD3DBaseTexture *iface, BOOL); > extern BOOL WINAPI IWineD3DBaseTextureImpl_GetDirty(IWineD3DBaseTexture *iface); > + > + extern BYTE* WINAPI IWineD3DVertexBufferImpl_GetMemory(IWineD3DVertexBuffer* iface, DWORD > iOffset); > + extern HRESULT WINAPI IWineD3DVertexBufferImpl_ReleaseMemory(IWineD3DVertexBuffer* iface); > extern HRESULT WINAPI IWineD3DBaseTextureImpl_BindTexture(IWineD3DBaseTexture *iface); > extern HRESULT WINAPI IWineD3DBaseTextureImpl_UnBindTexture(IWineD3DBaseTexture *iface); > /*** class static members ***/ > ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

1 0

Re: [WineD3D] prepare VBO
by Oliver Stieber 23 Jul '05

23 Jul '05

--- Raphael <fenix(a)club-internet.fr> wrote: > Hi, > > Changelog: > - add a new settings for vbo support > - use a struct to handle wined3d settings > - prepare VBO using some abstraction APIs > Hi, I've got debugged and tested VBO support with full support for vertex shaders to go in soon, but I'm trying to stabilize d3d before pushing performance features. > Regards, > Raphael > > ? wined3d.spec.def > Index: directx.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/directx.c,v > retrieving revision 1.41 > diff -u -r1.41 directx.c > --- directx.c 13 Jul 2005 19:38:40 -0000 1.41 > +++ directx.c 22 Jul 2005 19:52:14 -0000 > @@ -1455,7 +1455,7 @@ > *pCaps->MaxStreams = MAX_STREAMS; > *pCaps->MaxStreamStride = 1024; > > - if (((vs_mode == VS_HW) && GL_SUPPORT(ARB_VERTEX_PROGRAM)) || (vs_mode == VS_SW) || > (DeviceType == D3DDEVTYPE_REF)) { > + if (((wined3d_settings.vs_mode == VS_HW) && GL_SUPPORT(ARB_VERTEX_PROGRAM)) || > (wined3d_settings.vs_mode == VS_SW) || (DeviceType == D3DDEVTYPE_REF)) { > *pCaps->VertexShaderVersion = D3DVS_VERSION(1,1); > > if (This->gl_info.gl_vendor == VENDOR_MESA || > @@ -1469,7 +1469,7 @@ > *pCaps->MaxVertexShaderConst = 0; > } > > - if ((ps_mode == PS_HW) && GL_SUPPORT(ARB_FRAGMENT_PROGRAM) && (DeviceType != > D3DDEVTYPE_REF)) { > + if ((wined3d_settings.ps_mode == PS_HW) && GL_SUPPORT(ARB_FRAGMENT_PROGRAM) && (DeviceType > != D3DDEVTYPE_REF)) { > *pCaps->PixelShaderVersion = D3DPS_VERSION(1,4); > *pCaps->PixelShader1xMaxValue = 1.0; > } else { > Index: drawprim.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/drawprim.c,v > retrieving revision 1.20 > diff -u -r1.20 drawprim.c > --- drawprim.c 22 Jul 2005 18:27:04 -0000 1.20 > +++ drawprim.c 22 Jul 2005 19:52:19 -0000 > @@ -365,8 +365,8 @@ > TRACE("Stream is up %d, %p\n", element->Stream, > This->stateBlock->streamSource[element->Stream]); > data = (BYTE *)This->stateBlock->streamSource[element->Stream]; > } else { > - TRACE("Stream isn't up %d, %p\n", element->Stream, > This->stateBlock->streamSource[element->Stream]); > - data = ((IWineD3DVertexBufferImpl > *)This->stateBlock->streamSource[element->Stream])->resource.allocatedMemory; > + TRACE("Stream isn't up %d, %p\n", element->Stream, > This->stateBlock->streamSource[element->Stream]); > + data = > IWineD3DVertexBufferImpl_GetMemory(This->stateBlock->streamSource[element->Stream], 0); > } > stride = This->stateBlock->streamStride[element->Stream]; > data += (BaseVertexIndex * stride); > @@ -571,12 +571,12 @@ > if (This->stateBlock->streamIsUP) { > data = (BYTE *)This->stateBlock->streamSource[nStream]; > } else { > - data = ((IWineD3DVertexBufferImpl > *)This->stateBlock->streamSource[nStream])->resource.allocatedMemory; > + data = > IWineD3DVertexBufferImpl_GetMemory(This->stateBlock->streamSource[nStream], 0); > } > } else { > #if 0 /* TODO: Vertex shader support */ > thisFVF = This->stateBlock->vertexShaderDecl->fvf[nStream]; > - data = ((IDirect3DVertexBuffer8Impl > *)This->stateBlock->streamSource[nStream])->allocatedMemory; > + data = > IWineD3DVertexBufferImpl_GetMemory(This->stateBlock->streamSource[nStream], 0); > #endif > } > VTRACE(("FVF for stream %d is %lx\n", nStream, thisFVF)); > Index: vertexbuffer.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/vertexbuffer.c,v > retrieving revision 1.13 > diff -u -r1.13 vertexbuffer.c > --- vertexbuffer.c 13 Jul 2005 14:15:54 -0000 1.13 > +++ vertexbuffer.c 22 Jul 2005 19:52:19 -0000 > @@ -1,8 +1,8 @@ > /* > * IWineD3DVertexBuffer Implementation > * > - * Copyright 2002-2004 Jason Edmeades > - * Copyright 2003-2004 Raphael Junqueira > + * Copyright 2002-2005 Jason Edmeades > + * Raphael Junqueira > * Copyright 2004 Christian Costa > * > * This library is free software; you can redistribute it and/or > @@ -149,3 +149,13 @@ > IWineD3DVertexBufferImpl_Unlock, > IWineD3DVertexBufferImpl_GetDesc > }; > + > +BYTE* WINAPI IWineD3DVertexBufferImpl_GetMemory(IWineD3DVertexBuffer* iface, DWORD iOffset) { > + IWineD3DVertexBufferImpl *This = (IWineD3DVertexBufferImpl *)iface; > + > + return This->resource.allocatedMemory + iOffset; > +} > + > +HRESULT WINAPI IWineD3DVertexBufferImpl_ReleaseMemory(IWineD3DVertexBuffer* iface) { > + return D3D_OK; > +} > Index: wined3d_main.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/wined3d_main.c,v > retrieving revision 1.11 > diff -u -r1.11 wined3d_main.c > --- wined3d_main.c 22 Jul 2005 18:26:05 -0000 1.11 > +++ wined3d_main.c 22 Jul 2005 19:52:19 -0000 > @@ -30,8 +30,14 @@ > int num_lock = 0; > void (*wine_tsx11_lock_ptr)(void) = NULL; > void (*wine_tsx11_unlock_ptr)(void) = NULL; > -int vs_mode = VS_HW; /* Hardware by default */ > -int ps_mode = PS_NONE; /* Disabled by default */ > + > + > +wined3d_settings_t wined3d_settings = > +{ > + VS_HW, /* Hardware by default */ > + PS_NONE, /* Disabled by default */ > + VBO_HW /* Hardware by default */ > +}; > > WineD3DGlobalStatistics *wineD3DGlobalStatistics = NULL; > CRITICAL_SECTION resourceStoreCriticalSection; > @@ -128,12 +134,12 @@ > if (!strcmp(buffer,"none")) > { > TRACE("Disable vertex shaders\n"); > - vs_mode = VS_NONE; > + wined3d_settings.vs_mode = VS_NONE; > } > else if (!strcmp(buffer,"emulation")) > { > TRACE("Force SW vertex shaders\n"); > - vs_mode = VS_SW; > + wined3d_settings.vs_mode = VS_SW; > } > } > if ( !get_config_key( hkey, appkey, "PixelShaderMode", buffer, size) ) > @@ -141,14 +147,34 @@ > if (!strcmp(buffer,"enabled")) > { > TRACE("Allow pixel shaders\n"); > - ps_mode = PS_HW; > + wined3d_settings.ps_mode = PS_HW; > + } > + if (!strcmp(buffer,"disabled")) > + { > + TRACE("Disable pixel shaders\n"); > + wined3d_settings.ps_mode = PS_NONE; > + } > + } > + if ( !get_config_key( hkey, appkey, "VertexBufferMode", buffer, size) ) > + { > + if (!strcmp(buffer,"none")) > + { > + TRACE("Disable Vertex Buffer Hardware support\n"); > + wined3d_settings.vbo_mode = VS_NONE; > + } > + else if (!strcmp(buffer,"hardware")) > + { > + TRACE("Allow Vertex Buffer Hardware support\n"); > + wined3d_settings.vbo_mode = VS_HW; > } > } > } > - if (vs_mode == VS_HW) > + if (wined3d_settings.vs_mode == VS_HW) > TRACE("Allow HW vertex shaders\n"); > - if (ps_mode == PS_NONE) > + if (wined3d_settings.ps_mode == PS_NONE) > TRACE("Disable pixel shaders\n"); > + if (wined3d_settings.vbo_mode == VBO_NONE) > + TRACE("Disable Vertex Buffer Hardware support\n"); > > if (appkey) RegCloseKey( appkey ); > if (hkey) RegCloseKey( hkey ); > Index: wined3d_private.h > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/wined3d_private.h,v > retrieving revision 1.42 > diff -u -r1.42 wined3d_private.h > --- wined3d_private.h 22 Jul 2005 09:06:03 -0000 1.42 > +++ wined3d_private.h 22 Jul 2005 19:52:20 -0000 > @@ -69,16 +69,28 @@ > extern const DWORD SavedVertexStates_T[NUM_SAVEDVERTEXSTATES_T]; > extern const DWORD SavedVertexStates_S[NUM_SAVEDVERTEXSTATES_S]; > > -/* vertex and pixel shader modes */ > -extern int vs_mode; > +/** > + * Settings > + */ > #define VS_NONE 0 > #define VS_HW 1 > #define VS_SW 2 > > -extern int ps_mode; > #define PS_NONE 0 > #define PS_HW 1 > > +#define VBO_NONE 0 > +#define VBO_HW 1 > + > +typedef struct wined3d_settings_s { > +/* vertex and pixel shader modes */ > + int vs_mode; > + int ps_mode; > + int vbo_mode; > +} wined3d_settings_t; > + > +extern wined3d_settings_t wined3d_settings; > + > /* X11 locking */ > > extern void (*wine_tsx11_lock_ptr)(void); > @@ -979,6 +991,9 @@ > extern void WINAPI IWineD3DBaseTextureImpl_GenerateMipSubLevels(IWineD3DBaseTexture > *iface); > extern BOOL WINAPI IWineD3DBaseTextureImpl_SetDirty(IWineD3DBaseTexture *iface, BOOL); > extern BOOL WINAPI IWineD3DBaseTextureImpl_GetDirty(IWineD3DBaseTexture *iface); > + > + extern BYTE* WINAPI IWineD3DVertexBufferImpl_GetMemory(IWineD3DVertexBuffer* iface, DWORD > iOffset); > + extern HRESULT WINAPI IWineD3DVertexBufferImpl_ReleaseMemory(IWineD3DVertexBuffer* iface); > extern HRESULT WINAPI IWineD3DBaseTextureImpl_BindTexture(IWineD3DBaseTexture *iface); > extern HRESULT WINAPI IWineD3DBaseTextureImpl_UnBindTexture(IWineD3DBaseTexture *iface); > /*** class static members ***/ > ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

1 0

Re: glu32: fix some of -Wmissing-declarations warinings
by Vincent Béron 23 Jul '05

23 Jul '05

Le sam 23/07/2005 à 12:06, Stefan Huehner a écrit : [snip] 2 small nits: > --- /dev/null 2005-03-29 14:09:30.000000000 +0200 > +++ dlls/glu32/glu_local.h 2005-07-23 16:55:03.000000000 +0200 > @@ -0,0 +1,104 @@ > +/* A line indicating what this file is for, along with a copyright assignment, would be good. > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. [snip] How about a double include protection? (I know there's only one .c file in which it is included and that it's not likely to change, but I still recommend using one.) Vincent

1 0

Re: Move 16bit header to include/wine
by Francois Gouget 23 Jul '05

23 Jul '05

On Fri, 22 Jul 2005, Vincent Béron wrote: > Similar to previous one, only this time it's a whole file. I don't know > if current PSDK still carry it, in which case maybe we want to keep it > where it is? It's still present in the main directory of the XP-SP2 PSDK. So I think it should remain where it is. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In theory, theory and practice are the same, but in practice they're different.

1 0

Thought you all should know....
by Dustin Navea 22 Jul '05

22 Jul '05

To the PC reporters and journalists that this email gets sent to, this should probably be sent to people on your lists, pending further research on your part. I got this from the EFF (for those that dont know, thats the Electronic Frontires Foundation, the guys that monitor your privacy), and for those that dont care, just delete this.. I just figured you all should know.. ---Contents of the message below--- * Is Your Printer Spying On You? Help EFF Watch the Watchers Imagine that every time you printed a document, it automatically included a secret code that could be used to identify the printer - and potentially, the person who used it. Sounds like something from an episode of "Alias," right? Unfortunately, the scenario isn't fictional. In an effort to identify counterfeiters, the US government has succeeded in persuading some color laser printer manufacturers to encode each page with identifying information. That means that without your knowledge or consent, an act you assume is private could become public. A communication tool you're using in everyday life could become a tool for government surveillance. And what's worse, there are no laws to prevent abuse. The ACLU recently issued a report revealing that the FBI has amassed more than 1,100 pages of documents on the organization since 2001, as well as documents concerning other non-violent groups, including Greenpeace and United for Peace and Justice. In the current political climate, it's not hard to imagine the government using the ability to determine who may have printed what document for purposes other than identifying counterfeiters. Yet there are no laws to stop the Secret Service - or for that matter, any other governmental agency or private company - from using printer codes to secretly trace the origin of non-currency documents. We're unaware of any printer manufacturer that has a privacy policy that would protect you, and no law regulates what people can do with the information once it's turned over. And that doesn't even reach the issue of how such a privacy-invasive tool could be developed and implemented in printers without the public becoming aware of it in the first place. With nothing on the books, we lack tools to stop the privacy and anonymity violations this technology enables. For this reason, EFF is gathering information about what printers are revealing and how - a necessary precursor to any legal challenge or new legislation to protect your privacy. And we could use your help. In the preliminary research paper linked below, we explain what we've observed so far, briefly explore the privacy implications, and ask you to print and send us test sheets from your color laser printer and/or a color laser printer at your local print shop. That way, we can watch the watchers and ensure that your privacy isn't compromised in ways that harm your fundamental constitutional rights. In addition to documenting what printers are revealing, EFF is filing a Freedom of Information Act (FOIA) request, and we will keep you updated on what we discover. In the meantime, we urge you to participate in this research project and pass the word along. Thank you for your support! EFF paper: "Investigating Machine Identification Code Technology in Color Laser Printers": <http://www.eff.org/Privacy/printers/wp.php> Directions for printing test sheets: <http://www.eff.org/Privacy/printers/wp.php#testsheets> PC World: "Government Uses Color Laser Printer Technology to Track Documents": <http://www.pcworld.com/news/article/0,aid,118664,00.asp> ACLU: "FBI Is Keeping Documents on ACLU and Other Peaceful Groups": <http://www.aclu.org/SafeandFree/SafeandFree.cfm?ID=18784&c=206>

1 0

Re: RICHED20: EM_SETZOOM / EM_GETZOOM implementation
by Dimi Paun 22 Jul '05

22 Jul '05

From: "Phil Krylov" <phil(a)newstar.rinet.ru> > Added EM_GETZOOM and EM_SETZOOM RichEdit message handlers. > + case EM_GETZOOM: > + if (!wParam || !lParam) > + return FALSE; > + *(int *)wParam = editor->nZoomNumerator; > + *(int *)lParam = editor->nZoomDenominator; > + return TRUE; I don't know what Windows does, but it may also do: + case EM_GETZOOM: + if (wParam) *(int *)wParam = editor->nZoomNumerator; + if (lParam) *(int *)lParam = editor->nZoomDenominator; + return TRUE; Have you checked? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

Re: Fix the ldap_search_sA/W prototypes
by Hans Leidekker 22 Jul '05

22 Jul '05

On Friday 22 July 2005 19:34, Francois Gouget wrote: @ cdecl ldap_search_s(ptr str long str ptr long) ldap_search_sA -@ cdecl ldap_search_sA(ptr str long str ptr long) -@ cdecl ldap_search_sW(ptr wstr long wstr ptr long) +@ cdecl ldap_search_sA(ptr str long str ptr long ptr) +@ cdecl ldap_search_sW(ptr wstr long wstr ptr long ptr) ldap_search_s also needs the extra argument. -Hans

1 0

Re: [wined3d] drawprint tidyup initilization of strided data.
by Dimi Paun 22 Jul '05

22 Jul '05

> +#define SET_STRIDED (_usage, _name) \ > +case _usage: \ > +strided->u.s._name.lpData = data; \ > +strided->u.s._name.dwType = element->Type; \ > +strided->u.s._name.dwStride = stride; \ > +break; > + > +#define SET_STRIDED_(_usage, _name) \ > +case _usage: \ > +strided->u.s._name.lpData = data; \ > +strided->u.s._name.dwType = element->Type; \ > +strided->u.s._name.dwStride = stride; \ This is pretty ugly: the resulting code doesn't look like C. In fact, it looks rather magical.For example, why pass in _usage as a param to the macro, just to get rid of the case _usage: which you actually want outside the macro for readability. Also, accessing the magic strided, data, element, stride directly is very weird, and problematic. The casual user wouldn't know what hit him :) I say let it be as is. If you really want the macro, something like this would be better: +#define SET_STRIDED_(_strided, _name, _data, _element, _stride) \ +_strided->u.s._name.lpData = _data; \ +_strided->u.s._name.dwType = _element->Type; \ +_strided->u.s._name.dwStride = _stride; -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 4