July 2005 - Wine-devel - list.winehq.org

Re: WLDAP32: improve error handling for the bind functions
by Dimi Paun 25 Jul '05

25 Jul '05

From: "Hans Leidekker" <hans(a)it.vu.nl> > > - credW = strAtoW( cred ); > - if (!credW) return LDAP_NO_MEMORY; > + if (dn) { > + dnW = strAtoW( dn ); > + if (!dnW) return LDAP_NO_MEMORY; > + } > + if (cred) { > + credW = strAtoW( cred ); > + if (!credW) return LDAP_NO_MEMORY; > + } This leaks memory, if credW fails to allocate. Something like this would work: + WCHAR *dnW = NULL, *credW = NULL; + int ret = LDAP_NO_MEMORY; + + if (dn) { + dnW = strAtoW( dn ); + if (!dnW) goto exit; + } + if (cred) { + credW = strAtoW( cred ); + if (!credW) goto exit; + } + ret = ldap_bindW( ld, dnW, credW, method ); + exit: + free dnW, credW + return ret;

1 0

rpc problems with kohan2 installer.
by Oliver Stieber 25 Jul '05

25 Jul '05

Hi, I picked up a copy of Kohan 2, but I can't get it to install it looks like an RPC error. trace:rpc:I_RpcSend (0x7bc84e18) trace:rpc:RPCRT4_OpenBinding (Binding == ^0x7bc84e50) trace:rpc:RPCRT4_Receive buffer length = 12 trace:rpc:I_RpcGetBuffer (0x7ba8a6e4): BufferLength=12 trace:rpc:I_RpcGetBuffer Buffer=0x7bc44978 trace:rpc:RPCRT4_CloseBinding (Binding == ^0x7bc84e50) trace:rpc:RPCRT4_process_packet freeing Buffer=0x7bc84ed8 trace:rpc:RPCRT4_DestroyBinding binding: 0x7bc84e50 trace:rpc:I_RpcFreeBuffer (0x7bc84e18) Buffer=0x7bc850d0 trace:rpc:RPCRT4_CloseBinding (Binding == ^0x7bcae5f8) trace:rpc:RPCRT4_DestroyConnection connection: 0x7bc36cf0 trace:rpc:RPCRT4_CloseConnection (Connection == ^0x7bc36cf0) warn:rpc:RPCRT4_Receive Short read of header, 0/16 bytes warn:rpc:RPCRT4_io_thread receive failed with error 6c0 trace:rpc:RPCRT4_DestroyConnection connection: 0x7bc435d0 trace:rpc:RPCRT4_CloseConnection (Connection == ^0x7bc435d0) trace:ole:rpc_sendreceive_thread completed with status 0x0 trace:ole:DllMain 0x7b7c0000 0x3 (nil) trace:ole:DllMain 0x7b570000 0x3 (nil) trace:ole:CoWaitForMultipleHandles waiting for rpc completion or window message trace:ole:CoWaitForMultipleHandles -- 0x00000000 trace:ole:RpcChannelBuffer_SendReceive RPC call status: 0x0 trace:ole:RpcChannelBuffer_SendReceive -- 0x00000000 trace:ole:deserialize_param vt 26 at 0x7ba8a760 trace:ole:deserialize_param vt 3 at 0x7ba8c3d0 trace:ole:ITypeInfo_fnRelease (0x7bc880c0)->(6) trace:ole:ITypeLib2_fnRelease (0x7bc39748)->(8) ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

2 2

Re: hhctrl: Add the WebBrowser implementation [take 5]
by Alexandre Julliard 25 Jul '05

25 Jul '05

James Hawkins <truiken(a)gmail.com> writes: > +typedef struct IOleInPlaceFrameImpl > +{ > + IOleInPlaceFrame frame; > + HWND window; > +} IOleInPlaceFrameImpl; > + > +typedef struct IOleInPlaceSiteImpl > +{ > + IOleInPlaceSite inplace; > + IOleInPlaceFrameImpl frame; > +} IOleInPlaceSiteImpl; > + > +typedef struct IOleClientSiteImpl > +{ > + IOleClientSite client; > + IOleInPlaceSiteImpl inplace; > + IDocHostUIHandler ui; > +} IOleClientSiteImpl; You should define a single structure with multiple vtbl pointers, and compute the This pointer based on structure offsets. Look at how this is done in other places, like shelllink.c for instance. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: hhctrl: Add the remaining commands to HtmlHelp
by Alexandre Julliard 25 Jul '05

25 Jul '05

James Hawkins <truiken(a)gmail.com> writes: > Hey, > > Changelog > * Add the remaining commands to HtmlHelp. That switch is not supposed to list all the commands, it's here to only display the message box on calls caused by direct user action, to avoid spamming the user with message boxes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: theming "framework"
by Frank Richter 25 Jul '05

25 Jul '05

On 16.07.2005 01:13, Frank Richter wrote: > Frank Richter <frank.richter(a)gmail.com> > Added some generic code to allow subclassing(for the purpose of theming) > of standard controls. What are the issues with this one? -f.r.

2 1

Re: hhctrl: Add the CHM implemenation
by Dmitry Timoshkov 25 Jul '05

25 Jul '05

"James Hawkins" <truiken(a)gmail.com> wrote: > --- /dev/null 2005-07-23 07:02:07.637731864 -0500 > +++ dlls/hhctrl.ocx/itss.h 2005-07-25 01:09:16.000000000 -0500 > @@ -0,0 +1,302 @@ > +/*** Autogenerated by WIDL 0.1 from itss.idl - Do not edit ***/ Probably we need to move itss.idl to include/ so that a generated itss.h could be accessed globally. > + hr = pStorage->lpVtbl->OpenStream(pStorage, stringsW, NULL, STGM_READ, 0, &pStream); Please use IStorage_OpenStream macro here and similar macros instead of accessing vtable directly. -- Dmitry.

2 2

Writing tests when creating patches
by Paul Vriens 24 Jul '05

24 Jul '05

Hi, I've noticed that in the past weeks there were several patches that contained a remark like: - checked on on windows - compared with native - ... Wouldn't it be nice if tests accompanied these fixes? Do we have some guidelines in this? I know that writing tests is not everybody's hobby. Cheers, Paul.

2 1

Wine causing strange messages in Linux dmesg log
by Chris Rankin 24 Jul '05

24 Jul '05

Hi, Ever since (approx) when the winecfg tool became active, a Windows tool that examined IDE capabilities has stopped working. Instead, the following messages are being written into the dmesg log: hdc: write_intr: wrong transfer direction! hdd: write_intr: wrong transfer direction! hdc is a DVD-ROM drive, whereas hdd is a CD-RW drive, and the tool (DiscInfo.exe v1.5.5) tries to use SPTI. However, the tool identified both as hard disks. Does anyone have any ideas what's broken, please? Cheers, Chris ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

1 0

QuickTime Problems
by Andrew Neil Ramage 24 Jul '05

24 Jul '05

I installed the latest RPM release for SuSE 9.3 on my new laptop. Having installed Quick Time, I tried to view some .mov files (trailers) Anyone know what is wrong ? The output to the command window I started wine from is below. andrew(a)apollo:~/.wine/drive_c/Program Files/QuickTime> wine QuickTimePlayer.exe Sample.mov fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x403bf200)->(00000000,00000008) fixme:font:CreateScalableFontResourceA (0,"c:\\windows\\QTFont.for","c:\\windows\\QTFont.qfn",(null)): stub fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy fixme:system:SystemParametersInfoW Unimplemented action: 4122 (SPI_GETCURSORSHADOW) fixme:system:SystemParametersInfoW Unimplemented action: 4132 (SPI_GETDROPSHADOW) fixme:system:SystemParametersInfoW Unimplemented action: 4116 (SPI_GETSELECTIONFADE) fixme:menu:TrackPopupMenuEx not fully implemented fixme:system:SystemParametersInfoW Unimplemented action: 4122 (SPI_GETCURSORSHADOW) fixme:system:SystemParametersInfoW Unimplemented action: 4132 (SPI_GETDROPSHADOW) fixme:system:SystemParametersInfoW Unimplemented action: 4116 (SPI_GETSELECTIONFADE) fixme:menu:TrackPopupMenuEx not fully implemented fixme:system:SystemParametersInfoW Unimplemented action: 4122 (SPI_GETCURSORSHADOW) fixme:system:SystemParametersInfoW Unimplemented action: 4132 (SPI_GETDROPSHADOW) fixme:system:SystemParametersInfoW Unimplemented action: 4116 (SPI_GETSELECTIONFADE) fixme:menu:TrackPopupMenuEx not fully implemented X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 67 (X_PolyRectangle) Resource id in failed request: 0x4200007 Serial number of failed request: 13172 Current serial number in output stream: 13199 andrew(a)apollo:~/.wine/drive_c/Program Files/QuickTime> -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 0

Re: Treat LDAP as X for macro detection in winapi_check
by Alexandre Julliard 24 Jul '05

24 Jul '05

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Since we don't use HAVE_LDAP_H, it's an exception as well. There's no reason not to use HAVE_LDAP_H for header checks. -- Alexandre Julliard julliard(a)winehq.org

1 0