July 2005 - Wine-devel - list.winehq.org

Looking for a good disassembler
by James Liggett 11 Jul '05

11 Jul '05

Hi all, Can someone recommend a good win32 disassembler, preferably one that shows the contents of data segments and shows imports/exports? Thanks a lot, James Liggett

8 7

Re: ListBox: Fix LB_SETTABSTOPS (Resend)
by Alexandre Julliard 10 Jul '05

10 Jul '05

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -1277,12 +1286,14 @@ static INT LISTBOX_SetFont( LB_DESCR *de > return 16; > } > if (font) oldFont = SelectObject( hdc, font ); > - GetTextMetricsW( hdc, &tm ); > + GetTextExtentPointA( hdc, alphabet, 52, &sz); > if (oldFont) SelectObject( hdc, oldFont ); > ReleaseDC( descr->self, hdc ); > + > + descr->avg_char_width = (sz.cx / 26 + 1) / 2; > if (!IS_OWNERDRAW(descr)) > - LISTBOX_SetItemHeight( descr, 0, tm.tmHeight, FALSE ); > - return tm.tmHeight; > + LISTBOX_SetItemHeight( descr, 0, sz.cy, FALSE ); > + return sz.cy; I think tm.tmHeight is a better choice for the height. Do you have evidence that Windows doesn't use the font metrics here? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: AppDB Not accepting backslashes in HOWTOs
by James Liggett 10 Jul '05

10 Jul '05

Thanks Andrew, that worked. Duh...I should have thought of that. BTW, did you get Windows Installer working? James On Sun, 2005-07-10 at 03:08 +0100, Andrew Neil Ramage wrote: > Sounds like a Unix/Linux feature where the backslash is used for escape > codes, so you should use double backslashes. eg, C:\\Some\\Directory\\File > > Andrew > > You can be the captain > I will draw the chart > Sailing into destiny > Closer to the heart > > Closer to the Heart by Rush (A Farewell to Kings, 1977) > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > James Liggett wrote: > > I took a look at a howto in one of my AppDB entries, and I noticed that > > where thare are supposed to be backslash characters (mostly in windows > > paths,) they don't show up. If I enter something like Windows\system, it > > shows up fine in the preview, but when it actually goes to the real page > > it shows as Windowssystem. See > > http://appdb.winehq.org/appview.php?versionId=1043 for a few more > > examples. Has anyone seen anything like this before? > > > > Thanks, > > James Liggett > > > > > > > >

2 1

Managementness of borderless windows
by Stefan Dösinger 10 Jul '05

10 Jul '05

Hello List, Wine has problems with Windows which don't have the WS_CAPTION flag set. These Windows are usually not managed, which leads to focus problems(no keyboard) and the window constantly stays on top. I had a look on this and tried to find a solution: (Applications tested: Steam, Quicktime, Realoneplayer) *All windows seem to have the WS_POPUP and WS_SYSMENU flag set *GetParent(hwnd) returns NULL on the windows hwnd. *GetAncestor(hwnd, GA_PARENT) returns the same as GetDesktopWindow() I added a line which checks for GetAncestor() in is_window_managed(). This made the problematic windows managed nicely on my KDE Desktop, but it broke the menus which are also children of the desktop window. Checking GetParent(hwnd) == NULL seems to work too, and it doesn't break the menus. I've sent a patch in March 2005 (http://www.winehq.org/hypermail/wine-patches/2005/03/0504.html) but it wasn't accepted, and according to my information using GetParent in this situation is wrong, and it affects other windows too, like some parts of the main window of Half Life 1. The last thing that came into my mind is to make windows with WS_SYSMENU managed. This works without any side effects for me, but it doesn't appear right to me. Can anyone suggest a solution? Are there any other apps which I can test(Freely downloadable, small download preferable)? Thanks, Stefan Dösinger

3 3

WineD3D glx -> wgl patch
by Nick Burns 10 Jul '05

10 Jul '05

I have made a patch to make wined3d use wgl instead of glx (tested under win98se gf4 4200 and winxp gffx 5500) and would like to extend it and see it into the wine tree. This patch also applies the d3d9patch.2005-06-13.diff (heavily modified due to changes in wine head). I can send the files (sources and binaries) (and patch) and test programs (d3d9 demos mainly), if interested. The patch is rather large (1.3 MB raw text) and I'm hesitant to simply post it. The dlls (d3d9.dll -> wined3d.dll -> cygwin1.dll) were compiled under cygwin. Most of the simple d3d9 demos work perfect (even supports window resizing kinda) But the more complex demos are giving me some trouble (crashing) I have not really had time to run real games under this... Also I deactivated all the debugging stuff for windows/cygwin compiles (it gave lots of problems) --I will be looking into this soon

2 2

commctrl: initial button theming support - next try
by Frank Richter 10 Jul '05

10 Jul '05

Hi, I've worked the suggestions made wrt into that new patch. In particular, - subclassing is now properly done with SetWindowSubclass - uxtheme is delay-loaded - minor things like a correct "hot" flag and more cleanliness due the better subclassing. I've uploaded the patch to: http://www.minet.uni-jena.de/~res/commctrl-themedbutton.diff [or would have ~32k been an okay size for the list?] Reviews are appreciated. -f.r.

1 0

Re: [RESENT] Check for a valid buffer in NTReadFile
by Alexandre Julliard 10 Jul '05

10 Jul '05

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog: > wine/dlls/ntdll/file.c: NtReadFile() > Reject a NULL buffer That should be handled by the EFAULT case already. Why does it make a difference for you? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [RESENT] Add --all option to crosstest
by Alexandre Julliard 10 Jul '05

10 Jul '05

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog > wine/include/wine/test.h > Add --all option to run all tests in the testlist This has been discussed before, tests should be able to assume a clean environment when starting. It's much better to do that in a wrapper script. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Make Size Returned from HeapSize Always Match The Requested Size
by Alexandre Julliard 10 Jul '05

10 Jul '05

Robert Shearman <rob(a)codeweavers.com> writes: > --- dlls/ntdll/heap.c 25 Jun 2005 18:00:57 -0000 1.41 > +++ dlls/ntdll/heap.c 8 Jul 2005 16:22:47 -0000 > @@ -52,6 +52,9 @@ typedef struct tagARENA_INUSE > { > DWORD size; /* Block size; must be the first field */ > DWORD magic; /* Magic number */ > + BYTE unused_bytes; /* Number of bytes in the block not used by user data */ > + BYTE reserved0[3]; /* Not used. Set to 0 */ > + DWORD reserved1; /* Not used. Set to 0 */ > } ARENA_INUSE; I don't think we want to double the arena size for that. You can just steal a few bits from the magic number. -- Alexandre Julliard julliard(a)winehq.org

1 0

Debugger startup
by Robert Lunnon 10 Jul '05

10 Jul '05

To implement a Solaris debugger I have traced the wineservers startup and there is something I don't understand. I get the following stack trace: send_thread_signal+0x4a(80aab90, 10) stop_thread+0x1f(80aab90) suspend_process+0x4d(81c72a8) debugger_attach+0xf1(81c72a8, 81d1b58) req_debug_process+0x4c(81d1c38, 80477a0) call_req_handler+0x74(81d1b58) read_request+0x68(81d1b58) thread_poll_event+0x62(81d22b0, 1) fd_poll_event+0x14(81d22b0, 1) main_loop+0x9e(804785c, 8056a51, 1, 8047868, 8047870, 804785c) main+0xc6(1, 8047868, 8047870) _start+0x5d(1, 804795c, 0, 8047979, 80479f6, 8047a0a) bebugger_attach calls suspend_process then stop_thread stop_thread sends a SIGUSR1 at the thread of interest. The result of this is that the thread is terminated and there is nothing to attach to.... Why is this SIGUSR1 sent ? Bob

3 3