July 2005 - Wine-devel - list.winehq.org

Re: shell32.dll/Printer_LoadIconsW implemented (v2)
by Frank Richter 06 Jul '05

06 Jul '05

On 06.07.2005 01:01, Detlef Riekenberg wrote: > + /* Icon in native printui.dll: "Not the default, connected Local Printer" */ > + SHELL32_hmodule = LoadLibraryA("printui.dll"); > + iconindex = 1; > + > + if (SHELL32_hmodule == NULL) > + { > + /* Icon in shell32.dll: "Not the default, connected Local Printer" */ > + SHELL32_hmodule = shell32_hInstance; > + iconindex = IDI_SHELL_PRINTER; > + } Actually, all the different printer icons are contained in shell32.dll; hence, trying to use printui.dll there is probably rather counter-productive... -f.r.

2 1

Theming
by Frank Richter 06 Jul '05

06 Jul '05

Hi, I've recently submitted a patch to add initial theming support for push buttons. Most likely I'll have to iterate over it a few times before it could get accepted into CVS, so I'd like to just query for comments/questions/criticism on it. Thanks! Patch: http://www.winehq.org/hypermail/wine-patches/2005/07/0073.html -f.r.

2 3

Re: [WINECFG] Japanese translation
by Frank Richter 06 Jul '05

06 Jul '05

On 05.07.2005 09:28, Hajime Segawa wrote: > +FONT 9, "MS UI Gothic" Isn't it on Windows the case that dialogs generally use "MS Shell Dlg[ 2]", which is at runtime mapped to a font appropriate for the language (e.g. "MS UI Gothic" for Japanese)? This link, while not 100% on that topic, contains some links: http://blogs.msdn.com/michkap/archive/2005/03/20/399322.aspx -f.r.

3 2

Re: support for gradient captions (resend)
by Dmitry Timoshkov 06 Jul '05

06 Jul '05

"Frank Richter" <frank.richter(a)gmail.com> wrote: > (Now using GradientFill() instead of GdiGradientFill().) > --- dlls/user/Makefile.in (/wine/trunk/dlls/user) (revision 21713) > +++ dlls/user/Makefile.in (/me/trunk/dlls/user) (local) > @@ -5,7 +5,7 @@ > VPATH = @srcdir@ > MODULE = user32.dll > IMPORTLIB = libuser32.$(IMPLIBEXT) > -IMPORTS = gdi32 advapi32 kernel32 ntdll > +IMPORTS = gdi32 msimg32 advapi32 kernel32 ntdll It's even worse. user32 can't depend on msimg32 or any other high level dll. Just add GdiGradientFill to wingdi.h and resend your 1st patch. -- Dmitry.

2 2

Re: support for gradient captions
by Dmitry Timoshkov 06 Jul '05

06 Jul '05

"Frank Richter" <frank.richter(a)gmail.com> wrote: > --- dlls/user/nonclient.c (/wine/trunk) (revision 21713) > +++ dlls/user/nonclient.c (/me/trunk) (local) > @@ -197,6 +197,69 @@ > return hIcon; > } > > +extern BOOL WINAPI GdiGradientFill (HDC, PTRIVERTEX, ULONG, PVOID, ULONG, ULONG); wingdi.h is a more appropriate place for this. -- Dmitry.

1 0

Re: [ntdll] load all dll sections no matter what attributes say
by Eric Pouech 06 Jul '05

06 Jul '05

Vitaliy Margolen a écrit : > Vitaliy Margolen > > changelog: > dlls/ntdll/virtual.c > Load all dll sections no matter what attributes say why do you need this ? A+ -- Eric Pouech

3 4

sample msxml3 implementation
by Vijay Kiran Kamuju 06 Jul '05

06 Jul '05

Hi, I thought i have some suggestions in implementing the msxml3.dll I am sending an old sample stub implemenation (incomplete). I am rewriting the msxml3.dll need some suggestions. Thanks, Vijay

2 3

wine configuration via the registry and such
by Ray 06 Jul '05

06 Jul '05

Hi, I'm Ray, and I am a wine addict. ;) Seeing how a big step is made, I thought I'd drop a line concerning the "new way" to configure wine. First off, it's great to have some GUI to setup wine, though the config file was kind of handy and simple to use. There had to be changes with the winecfg tool though. But seeing how the configuration now is plainy stuffed into the "normal" registry, and how the important keys are simply get mixed up with other stuff makes me wonder if it could be done otherwise. I also wondered why exactly the registry is used for wine configuration and not a single config file? Winecfg could store the exactly same settings in the config file, too. Of course, on one hand to be as much "windows-ish" as possible, the registry seems to be the way, on the other hand, since wine comes from the linux side, I cannot really see some argument against ONE SINGLE easy-to-handle config file. >From the aspect of a GUI usage, I can't think of an real difference between both, except where the settings are stored. I might miss something else as well, though. But secondly, the winecfg tool is basically not usable for a basic setup or the switch from config file to the registry (yet). In other words, I based my configuration on the Sidenet-configuration-tool once and simply can't be bothered to hack all those DLL settings in via the GUI. And this everytime I have to reconfigure or setup (a new) wine. And there are more settings than just the DLL ones. Of course, once the basic configuration is done, one could use the registry editor to export a couple .reg files for later reimports. Basically it is what I do/did, I just "patched" the Sidenet-1.8.2-script to import .reg files, of course shortly before 1.8.3 came out ;* So I now ended up in doing it the .INF-file way .. it appears to be the best one for script based setup, too. But using simply and ONLY winecfg for setting wine up is hardly practicable if you have an existing configuration to implement. Editing the .reg files in an editor is somewhat strange since all the registrykeys are re-arranged every time wine is started, that means a lot of searching, especially if software has been installed. It also appears there is no coherent block of wine configuration settings, which was some kind of advance for the config file. Another advance was the ability to comment things out in the config file, if you do it the same way in the .reg file it gets deleted with the next wine start. A possible solution is not to comment the whole line out, but change the key's name (e.g. "comctl32"="native" => ";comctl32"="native"). But that again causes the key to be re-arranged and you have to find it again. Granted, using this example it is just moved up to the beginning of the section, plus you can see all the "commented" keys at once.. on the other hand, I don't really know what happens with those keys, since they are not really taken out of the configuration. And it's not very handy to delete and recreate those entries via winecfg in case of error/bug search or whatever. There is an option "disable" on the libraries tab, but it seems to completely disable the use of a DLL. (Err.. just like it says ^^) Speaking of comments, there is also no possibility to comment sections in the configuration anymore, which make it difficult to always remember why a setting has been made, what are there for options etc. This is not good, and even more if the whole configuration stuff is not arranged using my (the users) order/system but wine's :~ I think some im- and export interface for settings in the winecfg tool could be useful. (Using Sidenet seems to be useful, too, but .. I don't think it'd be too much of a redundance :D) Maybe there also should be some kind of description/comment lines available in the GUI. And I think it would be nice to have a way to disable a setting (read: comment out), mostly and especially on the libraries tab. And what I would like to see is some extra .reg file like "wine.reg" where all (real) wine related stuff is stored. This way one can simply transfer wine settings from one wine instance to another without having any worries about accidently catching some keys made by other software. "Native" editing would be much more simpler, too. Another advantage would be that one can easily "reset" a screwed configuration by restoring a backup of the file without the risk of screwing registry entries of installed software. And finally, there is the documentation issue. Many basic config file sections and options are documented, but not all, most of them can be simply "converted" to the registry ones, some of them are commented in the source but may lack of documentation, some are just .. however, the point I am trying to make is, that guessing things because they are undocumented is something from the windows world I do not really want to be "emulated" with wine. ;D -Rayston

1 0

Re: PATCH: EXTRACFLAGS removal from configure
by Alexandre Julliard 06 Jul '05

06 Jul '05

Marcus Meissner <marcus(a)jet.franken.de> writes: > EXTRACFLAGS and CFLAGS complement it each other in the configure.ac script, > I see no need to have it "EXTRA". The reason for it is that the user is allowed to set his own CFLAGS, so the Wine flags have to be in EXTRACFLAGS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: avifile init/exit handling
by Andreas Mohr 06 Jul '05

06 Jul '05

Hi, On Wed, Jul 06, 2005 at 08:14:14AM +0200, Marcus Meissner wrote: > Hi, > > This implements Roberts suggestion of uninitializing Ole if it is no > longer needed. > > Ciao, Marcus > > Changelog: > Call OleUninitialize() on last AVIFileExit() > +static int ole_initialized = 0; > + > + if (!ole_initialized++) > + OleInitialize(NULL); Isn't that somewhat racey? Probably better to use InterlockedIncrement() here. Andreas Mohr

1 0