July 2005 - Wine-devel - list.winehq.org

How to pass / convert file names?
by Christian Britz 27 Jul '05

27 Jul '05

Hi, I discovered only recently a problem which is probably quite prevalent, but I could not find the answer on the web. Example: I want to configure Mozilla for opening .DOC files with the free Word Viewer that can be downloaded at http://www.microsoft.com. To do so I go to Edit -> Preferences -> Navigator -> "Helper Applications" and create a new MIME-Type "application/msword", extensions "doc dot" and tell the beast to open such files with /home/cbritz/.wine/drive_c/Programme/Microsoft Office/WORDVIEW.EXE (I have configured binfmt support, so I can call the EXE directly) Expected behaviour: The viewer program starts, opens the doc file and displays it. What happens: The viewer program starts and does not open any file. I must manually select Z:\tmp\Example.doc from the application. Next try from command line: .wine/drive_c/Programme/Microsoft\ Office/WORDVIEW.EXE /tmp/Example.doc - Again the doc file doesn't open. It DOES WORK when I manually translate the path name to: .wine/drive_c/Programme/Microsoft\ Office/WORDVIEW.EXE Z:\tmp\Example.doc first. I expected naively that wine automatically translates the Unix scheme to it's own convention but this doesn's seem to be true. Is it possible to instruct wine to translate the path string before it passes it to the windows binary? If not, is there a workaround to do that trick? One solution would probably be to write a wrapper script that translates the path name before it is passed to wine. One discussion board entry I found indicates the CrossOver plugin does it that way. I might even volunteer for trying to write a patch to wine if someone could tell me where to start to look at in the code ;) But probably the solution is already out there and I just don't see it. Any help would be much appreciated! Regards Christian

2 4

bugs #3148 - Still in wine-20050725
by Hiji 27 Jul '05

27 Jul '05

Can anyone help out with this bug? It's still in existence in the July Wine release. Basically, I select 3 files, and I click on the highlighted files to try to drag all 3. However, as soon as I click on them, they deselect, and one file is now selected. If I attempt to click+drag the one file, it gets stuck on the click+drag -- that is, I let get go of the mouse button and the highlighted file is still attached to the mouse arrow. Help! I want to use the latest Wine, but it's useless to me if I can't get proper mouse behavior. :S (I'm still stuck on wine-20041201 otherwise.) Hiji __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 2

Re: hhctrl: Add the WebBrowser implementation
by James Hawkins 27 Jul '05

27 Jul '05

On 7/27/05, James Hawkins <truiken(a)gmail.com> wrote: > Hey, > > This patch includes these changes: > * no more HH_* macros, no more hhctrl.h > * uses proper ref counting > * stores pointers instead of using ptr arithmetic > * IOleClientSiteImpl frees itself so there is no mem leak > * uses the ICOM_THIS_MULTI macro > * misc cleanups > > Changelog > * Add the WebBrowser implementation. > Can you tell me what needs to be fixed to get this accepted? This is a bare-bones implementation of a embedded web browser, so the S_OKs and the E_NOTIMPL are necessary to make shdocvw happy, but we really don't need those particular api in HTML Help. -- James Hawkins

1 0

Re: hhctrl: Add the WebBrowser implementation
by Dmitry Timoshkov 27 Jul '05

27 Jul '05

"James Hawkins" <truiken(a)gmail.com> wrote: > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) IMO using 'const' before the type looks more natural. Also adding 'const' to all type conversions wouldn't hurt: const impl* This = (const impl*)((const char*)(iface) - offsetof(impl,field)) > +static HRESULT STDMETHODCALLTYPE Site_SaveObject(IOleClientSite *iface) > +{ > + return E_NOTIMPL; > +} Any chance to add a FIXME to all not implemented interfaces even if you return S_OK in them? > +static IOleClientSiteVtbl MyIOleClientSiteTable = Please make all OLE vtables const and use const keyword for pointers to them in the structures of interface implementations. > + switch (dwAction) > + { > + case WB_GOBACK: > + IWebBrowser2_GoBack(pWebBrowser2); > + break; > + case WB_GOFORWARD: > + IWebBrowser2_GoForward(pWebBrowser2); > + break; > + case WB_GOHOME: > + IWebBrowser2_GoHome(pWebBrowser2); > + break; > + case WB_SEARCH: > + IWebBrowser2_GoSearch(pWebBrowser2); > + break; > + case WB_REFRESH: > + IWebBrowser2_Refresh(pWebBrowser2); If it's intented to not use 'break;' here a comment telling that wouldn't hurt. > + case WB_STOP: > + IWebBrowser2_Stop(pWebBrowser2); > + } default: here wouldn't hurt as well and would show some not expected/implemented cases with a FIXME message. -- Dmitry.

2 3

Re: dlls/winmm/winealsa/midi.c: Bug in MIDI_CMD_BENDER fixed
by Marcus Meissner 27 Jul '05

27 Jul '05

On Tue, Jul 26, 2005 at 11:52:55PM +0200, Johannes Koch wrote: > The pitch value was wrongly converted and has to be centered around zero. > > Changelog > Fixed pitch bending in the alsa midi driver. > > ? patch.diff > Index: dlls/winmm/winealsa/midi.c > =================================================================== > RCS file: /home/wine/wine/dlls/winmm/winealsa/midi.c,v > retrieving revision 1.16 > diff -u -p -r1.16 midi.c > --- dlls/winmm/winealsa/midi.c 27 Apr 2005 09:39:56 -0000 1.16 > +++ dlls/winmm/winealsa/midi.c 26 Jul 2005 21:31:05 -0000 > @@ -833,7 +833,7 @@ static DWORD modData(WORD wDevID, DWORD > snd_seq_ev_set_controller(&event, evt&0x0F, d1, d2); > break; > case MIDI_CMD_BENDER: > - snd_seq_ev_set_pitchbend(&event, evt&0x0F, ((WORD)d1 << 7) | (WORD)d2); > + snd_seq_ev_set_pitchbend(&event, evt&0x0F, ((WORD)d2 << 7 | (WORD)d1) - 0x2000); This is not correct, you need extra ( ) around the << 7, like this perhaps: > + snd_seq_ev_set_pitchbend(&event, evt&0x0F, (((WORD)d2 << 7) | (WORD)d1) - 0x2000); Ciao, Marcus

3 2

Re: RICHED20: TODO list additions
by Dmitry Timoshkov 27 Jul '05

27 Jul '05

"Phil Krylov" <phil(a)newstar.rinet.ru> wrote: > Added some missing but useful items to the RichEdit TODO list. > + * - full justification > + * - hyphenation > + * - tables What kind of hyphenation richedit needs? Would an automatic, not dictionary based algorithm suffice? In 1996-97 I've developed and implemented that kind of algorithm for russian language and MS Word/Pagemaker. It produces much better results than Ventura Publisher for DOS and similar results to (released later) builtin automatic hyphenation in Pagemaker 6.0 (russian edition). The code has been written for TurboC/DOS but should be easy enough to port), and I would be happy if it could be handy for Wine's richedit. Just let me know and I'll send the sources. -- Dmitry.

3 2

Re: Reimplement EnumDateFormats, make it work for all available locales
by Paul Vriens 27 Jul '05

27 Jul '05

> Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > - Reimplement EnumDateFormats, make it work for all available locales. > - Add a test for EnumDateFormats > ... > -BOOL WINAPI EnumDateFormatsA( DATEFMT_ENUMPROCA lpDateFmtEnumProc, LCID > Locale, DWORD dwFlags) > +BOOL WINAPI EnumDateFormatsA(DATEFMT_ENUMPROCA proc, LCID lcid, DWORD > flags) Why did you change the names ? I thought we sticked to the MSDN ones ? Paul.

2 1

crypt32: Re: exception handling, part 2
by Saulius Krasuckas 27 Jul '05

27 Jul '05

* Log message from [1]: > > Juan Lang <juan_lang(a)yahoo.com> > - fix decoding of long-form data lengths > - use exception handling in decoding > - tests for these changes One of added tests in the patch fails on winME: | encode.c:313: Test failed: Expected CRYPT_E_ASN1_LARGE, got c0000005 But the bad thing is that after running small code chunk another calls to CryptEncodeObjectEx() starts generating exceptions here. Mentioned code: + /* Try to decode some bogus large items */ + /* The buffer size is smaller than the encoded length, so this should fail + * with CRYPT_E_ASN1_EOD if it's being decoded. It's failing with + * CRYPT_E_ASN1_LARGE, meaning there's a limit on the size decoded. + * The magic limit under XP seems to be 0x061a8000 bytes--more than this + * fails with CRYPT_E_ASN1_LARGE. + */ + ret = CryptDecodeObjectEx(dwEncoding, X509_MULTI_BYTE_INTEGER, tooBig, + 0x7fffffff, CRYPT_DECODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &bufSize); + ok(!ret && GetLastError() == CRYPT_E_ASN1_LARGE, + "Expected CRYPT_E_ASN1_LARGE, got %08lx\n", GetLastError()); And example of parameters for the mentioned call (which after throws an exception of "Access violation" in another tests): CryptEncodeObjectEx( X509_ASN_ENCODING, X509_ENUMERATED, 1, CRYPT_ENCODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &bufSize ); HTH to fix exceptions. If that informations is not enough, I will be glad to debug this via e-mail, Juan. :-) [1] http://www.winehq.org/hypermail/wine-cvs/2005/06/0683.html

3 6

Re: Add ShellExecute() conformance tests
by Saulius Krasuckas 27 Jul '05

27 Jul '05

* On Fri, 22 Jul 2005, Francois Gouget wrote: > > So the goal of this conformance test is to at least get things started > and to test a few sticking points like putting quotes around the One test fails on my box: | $ make -C dlls/shell32/tests/ test | make: Entering directory `/mnt/antras/usr/src/wine-cvs/wine/dlls/shell32/tests' | ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so shlexec.c && touch shlexec.ok | shlexec.c:275: Test failed: ShellExecute(null, "C:\windows\temp\\test_shortcut_shlexec.lnk", null, null) failed: rc=31 err=0 | make: *** [shlexec.ok] Error 1 Any ideas?

3 2

Version
by jstrupeni 27 Jul '05

27 Jul '05

Hello, I have a Novell Linux Desktop Version 9 and I don't know what version of Wine I should install. Thank you very much in advance. Juan

1 0