September 2006 - Wine-devel

Re: [WINED3D] Pbuffer/ActiveRender cleanup #2
by H. Verbeet 19 Sep '06

19 Sep '06

On 17/09/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote: > @@ -156,6 +160,7 @@ typedef struct wined3d_settings_s { > BOOL glslRequested; > int vs_selected_mode; > int ps_selected_mode; > + int offscreen_selected_mode; > /* nonpower 2 function */ > int nonpower2_mode; > int rendertargetlock_mode; When you change wined3d_settings, you should make sure that you update the defaults in wined3d_main.c as well. I know those are currently mismatched, but I've got a patch to clean it up. I'm currently waiting for Alexandre to apply/reject some of the wined3d patches sent over the past couple days before sending it (and some other patches). I'm not sure if using wined3d_settings is really the right place to store things that don't have a corresponding registry key, but it seems like the best place for now. To clarify what OFFSCREEN_NONE does, it renders to the backbuffer for the current context, rather than using a separate context, and copies it to a texture when done. That's also why, depending on the primitive drawing order, you sometimes see the offscreen surface in the lower left corner of the screen.

2 3

My Wineconf 2006 trip report
by Marcus Meissner 19 Sep '06

19 Sep '06

Hi folks, I had to write it up for my dear colleagues anyway, so here my notes... Feel free to reuse as you like. Attendance was around 35 people, all developers. Location was the university campus of Reading, a lecture hall in the Agriculture Department. The conference was organized by CodeWeavers, but sponsored by mostly 2 donors of each 1000 (?) US$ to the Wine project, one private person and a Poker website (strange enough). Around 10 - 15 developers were CodeWeavers employees, the other were volunteer developers. 1. Keynote by Alexandre Julliard (CW) Alexandre Julliard, our resident dictator and lone committer held the keynote. - The beta (0.9.*) works out fine. The 2 month code freeze before Beta has helped, and bugs got nicely pruned. The bugzilla stat char showed a nice increase in reported and also in fixed bugs. - Wine 1.0 plans Code Freeze perhaps later this year, for several months, then 1.0 release early next year. - Post 1.0 Unclear. Likely will have a stable and a feature branch. - GIT GIT is working out nicely. Number of monthly (?) commits grew from 400 at the turnover point to around 700 now. Reasons: * More smaller and confined patches (also thanks to GIT allowing incremental local commits). * GIT patch submission is in one defined patch format. Earlier patches were occcasionaly generated from subdirectories, misformatted, hand edited or similar. GIT changes this to one defined format, making his work easier. * "Developers might not like it, but I do". - Goals for 1.0 * Better Game Support (DirectX). This is pretty much heavy work in progress currently. * Regressiontests, Documentation are fine as-is. * Copy Protection support for Games etc. Necessary to run lots of games. However this is not a release stopper. - LOC still increasing, around 1.800.000 now. - COM (Component Object Model) report by Rob Shearman (CW) Rob (and others) spent most of last year enhancing and fixing the COM, OLE and RPCRT parts of WINE and summarized it. The out of process COM used by InstallShield has seen lots of changes and is working much better now. Work on remote COM was necessary for Outlook which talks COM via RPC over TCP sockets with the Outlook server. - GIT Tutorial by Mike McCormack (CW) Not WINE specific, so no details. - cxtest by Martin Pilka (CW) cxtest is the ongoing developed GUI testing kit from Codeweavers. Basic idea is that it can generate keypresses, mouseclicks and similar things and then captures images at various intervals and compares them with previous runs. Needs review of problems, but has definitely spotted some already. - Google's use of WINE by Dan Kegel (Google) 2 major Windows applications that wanted a Linux port. - Picasa Requirement: _No_ Windows binary code change. Hired Codeweavers as company to fix issues: - lots of bugfixes - IWebBrowser implementation - File change notification (implemented with inotify) - Video Codec handling fixes (both in MSVIDEO and DSHOW) - However: Needed to disable CD Burning Module of Picasa. Works on almost all distros nicely. - Google Earth WINE has OpenGL-in-Window problems, otherwise this might have been a WINE job too likely. The Loki Installer guy (Brad something?) did the port on-site (this 1 person did the port). Exposes lots of OpenGL / GFX card related related problems. -> But received more press and recognition. No other Windows applications of Google need to be ported currently. (Google Desktop would be one, but it requires integration into native browsers, so it is too Windows specific.) Dan also oversees 4 Google interns working on Wine. - CrossOver on Mac by Andrew Bogott (CW) Beta on MacOS/X (Intel) of CrossOver Office available. Andrew demoed MS Excel, including installation of it. GUI toolkit is in TCL + Coco (? graphical Mac scripting language) Use X11 graphics driver, Quartz driver is currently being considered. Caused stability problems with Mac Kernel. Caused stability problems with Mac X Server. Is slower than on Linux due to lack of some fast methods we use on Linux (I guess something like threading, futexes or so. -Marcus) - Governance breakout session The point sometimes comes up whether to replace Alexandre. The present developers did not agree, so there was not much discussion. We evaluated _why_ they want it: - They want low quality hacks into the tree to make apps work. This is a no go, you need to fix it right. - They get no reply on their submission _why_ it was rejected. True reason, we discussed a bit how to improve. - A bot welcoming new patch posters? - checks for most common problem, // comments - people actively taking care of areas and responding to people - Alexandre waiting for comments from those responsibles on difficult patches - Branch Maintainership post 1.0 ... Briefly touched, but we will see when we get there. - Packaging breakout session Its unclear (to me at least) what is wanted ;) Paul Millar wants nightly regression tests (cxtest runs with downloaded binaries?) Some want nightly builds. Some want .spec files in a central repository. Marcus is trying to bring up RPM builds for SUSE, Mandriva 2006.0, Fedora Core 4 and 5 on the openSUSE buildservice. Debian to come. Ciao, Marcus

2 2

Wine 0.9.21 fails to run
by Ken Zalewski 19 Sep '06

19 Sep '06

I just upgraded from 0.9.20 to 0.9.21, and now nothing will run, including simple programs such as sol.exe and notepad.exe. The error message I'm receiving is: X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 145 (NV-GLX) Minor opcode of failed request: 4 () Resource id in failed request: 0x242 Serial number of failed request: 19 Current serial number in output stream: 19 My system is a Slackware 10.2 system, running kernel 2.6.17.13, x11 6.8.2, and NVidia driver 8774. I have seen some other postings on the Net about this, including postings in the Ubuntu forums (which means that this is not limited to Slackware). Downgrading to 0.9.20 gets everything working again. My guess, based on the "NV-GLX" message, is that something was changed in the OpenGL support between 0.9.20 and 0.9.21, and it has broken Wine. I'll be happy to help debug this. Sincerely, Ken Zalewski Slackware package maintainer Linuxpackages.net

2 1

wine conf group photo
by EA Durbin 18 Sep '06

18 Sep '06

The link on the winehq.org page for the photo is returning 404 not found.

2 1

Re: winex11.drv: cleanup better in X11DRV_WineGL_InitOpenglInfo
by Jesse Allen 18 Sep '06

18 Sep '06

On 9/17/06, Phil Costin <philcostin(a)hotmail.com> wrote: > Roderick Colenbrander wrote: > > > The problem is that I'm not sure (and I think it is Alexandre his issue > > aswell) whether this patch is a workaround or a real fix. I think that > > wined3d created a GLX context in lets say thread '1' and that it wants to > > create lets say another one in a different thread. If this is the case it > > could happen that for the new thread the x11drv visual needs to be > > 'rechosen'. This causes the 'info' code to be called again. Because this > > code creates a context we mess up the already active context. > > > > Your patch indeed fixes that by storing the current GLX context and > > restoring it later on. Perhaps there's a nicer way to prevent this issue > > to happen at all. > > > > In any case I think it might be nicer to use glXGetCurrentContext in case > > there's already some GLX context around. So in that case don't create a > > new context and don't kill it at the end. This would already be cleaner. > > > > Roderick > > > > > > > >> I don't know myself either. I was just going to wait. I want to add a > >> little more to say about it. > >> > >> It's funny that the patch was only meant to affect the opengl/wgl code > >> and the crashing apps are all d3d ones. However winex11 will now > >> change the context on it's own when doing the opengl query and not set > >> it back. What I noticed a couple weeks ago and now is that winex11 > >> does usually gets inited twice, therefore it will change the current > >> context twice. One at the start of the program, and another later on > >> -- maybe on creation of a window or something. By that time wined3d is > >> probably inited too, and making glXMakeCurrent calls too since it's > >> based on opengl. So perhaps winex11 is causing wined3d to trip up at > >> some point by changing the context. So if InitOpenglInfo just sets > >> things back, then wined3d won't go boom. > >> > >> >>From comments in wined3d, I can tell there isn't any "context > >> manager". So what wined3d does at most is very simple management of > >> contextes. We probably need a manager to coordinate things like this > >> better between the two libraries. But that will likely be a bigger > >> patch and to do so... I don't know, we need a fix for all the broken > >> d3d apps now. > >> > >> Jesse > >> > > > > > At the moment, this patch fixes regressions so if we don't have the code in > there at all, many games do not work. > > It may not be the ideal solution but is it not better for now to fix the > regression and think about a proper solution separately without breaking > applications by not having the patch applied? > > Regards, > Phil > > > > Phil, Roderick, I'm going to look at what I can do to improve the patch and gather more information on the handling of contextes. I just haven't had time yet. And Roderick, I'll discuss with you the newer patch when I'm ready so to see if you agree with it. I do lean towards agreeing with Phil on that this is simply needed and more than a workaround. I've already been asked many times if the patch has gotten in and that is why I posted to wine-patches so quickly; your patch broke alot of D3D apps for alot of people... The d3d9 stateblock test is the best clue. Jesse

2 2

Visual C++ does not seem to have snprinft
by Jeff L 18 Sep '06

18 Sep '06

When compiling dlls/gdi/tests/metafile.c on line 1357 I get a warning C4013: "snprintf" is undefined. Looking around, it seems that snprinft is in fact _snprintf in Visual C++. I have found a define #if !defined(HAVE_SNPRINTF) && defined(HAVE__SNPRINTF) #define snprintf _snprintf #endif in wine/port.h but it requires config.h and they don't appear in my Visual C++ system. What is the best way to address this problem? It seems to be fairly common but I have not found an example in a test. Jeff Latimer

6 5

Re: If there is no space for strings GetOutlineTextMetricsA should not indicate that they present
by Paul Vriens 18 Sep '06

18 Sep '06

On Mon, 2006-09-18 at 19:00 +0900, Dmitry Timoshkov wrote: > Hello, > > this patch prevents my test application from crashing by dereferencing > memory beyond allocated memory block. > > Changelog: > If there is no space for strings GetOutlineTextMetricsA should not > indicate that they present. > > --- cvs/hq/wine/dlls/gdi/font.c 2006-08-15 14:51:46.000000000 +0900 > +++ wine/dlls/gdi/font.c 2006-09-18 18:38:57.000000000 +0900 > @@ -1483,6 +1483,20 @@ UINT WINAPI GetOutlineTextMetricsA( > if(output != lpOTM) { > memcpy(lpOTM, output, cbData); > HeapFree(GetProcessHeap(), 0, output); > + > + /* check if the string offsets really fit into the provided size */ > + /* FIXME: should we check string length as well? */ > + if ((UINT_PTR)lpOTM->otmpFamilyName >= lpOTM->otmSize) > + lpOTM->otmpFamilyName = 0; /* doesn't fit */ > + > + if ((UINT_PTR)lpOTM->otmpFaceName >= lpOTM->otmSize) > + lpOTM->otmpFaceName = 0; /* doesn't fit */ > + > + if ((UINT_PTR)lpOTM->otmpStyleName >= lpOTM->otmSize) > + lpOTM->otmpStyleName = 0; /* doesn't fit */ > + > + if ((UINT_PTR)lpOTM->otmpFullName >= lpOTM->otmSize) > + lpOTM->otmpFullName = 0; /* doesn't fit */ > } > > end: this one also fixes an issue I was looking into this morning: Try to create a key via regedit with the name {44444444-4444-4444-44444444} and press enter. Cheers and thanks, Paul.

1 0

Wine directx and xinerama
by Roland Kaeser 17 Sep '06

17 Sep '06

Hello all I just regognized that I get serious trouble trying to run apps on a xinerama screen (Matrox Parhelia) with Triple display configuration (http://www.matrox.com/graphics/workstation/cre_pro/products/pseries/p750.cfm / 01:00.0 VGA compatible controller: Matrox Graphics, Inc. Millenium P650/P750 (rev 02)). Running the same apps (such as Railroad Tycoon) on a "normal" machine with intel 945G (VGA compatible controller: Intel Corporation 945G/GZ Express Integrated Graphics Controller (rev 02)) its works fine. But running RT3 on my Matrox card makes it crashing or just bringing a error message, even when I configured a virtual desktop (1024x768). Does somebody has a idea about this behaviour? Thanks Roland

3 2

Will Wine run with Linspire 5?
by Ctm007 17 Sep '06

17 Sep '06

Will Wine run with Linspire 5? Carl Martin ctm007(a)houston.rr.com

1 0

Re: secur32: Add a warning if ntlm_auth is not found or in a wrongversion.
by Dmitry Timoshkov 17 Sep '06

17 Sep '06

"Kai Blin" <kai.blin(a)gmail.com> wrote: > + else > + { > + WARN("ntlm_auth not found, or in an outdated version.\n" \ > + "Make sure you are using ntlm_auth =< 3.x and it is in your path.\n"); > + } If the message is supposed to be user visible (otherwise why to bother with wording?) it would be better to use either FIXME or MESSAGE. Also "=<" is not really understandable in this context. Did you mean that a version 3.x or better is required (then >= 3.x), or <= 3.x (then the word "outdated" is misleading)? -- Dmitry.

2 1