September 2006 - Wine-devel

How to report code errors?
by Andrew Talbot 16 Sep '06

16 Sep '06

How should one report minor code errors that don't necessarily produce known bad behaviour? To give a concrete example, in msacm32:driver.c acmDriverPriority(), formal parameter dwPriority is of type DWORD, which is unsigned, but it contains a line that reads: if (dwPriority < 0) dwPriority = -1; ... which can never happen. Bugzilla seems inappropriate, so does wine-devel. If Coverity has abandoned us, would it be worth having a web/wiki page for posting any such code anomalies, so that the knowledgable might consider fixing them? Thanks, -- Andy.

3 4

Already Error while installing MS Office 2003
by Roland Kaeser 16 Sep '06

16 Sep '06

Hello Just tried to test install office 2003 on wine 0.9.21. But getting already errors. I read in C't (german it magazine) that office 2003 works on codeweavers. Can somebody declare me this? Does codeweavers voluntary not provide the corrections to wine to sell their product? Looks very strange to me. Roland Debug Output while installing office (breaks down when it trieds to start installation of the files (after setup configuration and serial number request) --------------------------------------------------------------------------------------------------------- fixme:imm:ImmDisableIME (-1): stub fixme:advapi:CheckTokenMembership ((nil) 0x190388 0x346d3c) stub! err:ole:CoUninitialize Mismatched CoUninitialize err:ole:CoUninitialize Mismatched CoUninitialize fixme:advapi:CheckTokenMembership ((nil) 0x1ad6f8 0x7d3683b8) stub! err:msidb:WHERE_VerifyCondition Couldn't find column L"Lock" fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 67 ignored L"Upgrade" table values err:msidb:WHERE_VerifyCondition Couldn't find column L"Lock" err:msi:msi_dialog_set_font No font entry for L"52" err:msi:msi_dialog_set_font No font entry for L"9" err:msi:msi_dialog_set_font No font entry for L"52" fixme:msi:ControlEvent_SpawnWaitDialog Doing Nothing fixme:msi:ControlEvent_SpawnWaitDialog Doing Nothing err:msi:msi_dialog_set_font No font entry for L"100" err:heap:HEAP_ValidateInUseArena Heap 0x110000: in-use arena 0x1ed990 next block has PREV_FREE flag fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 67 ignored L"Upgrade" table values err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\1031\\OFREADME.HTM") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\1031\\OFREADME.HTM") fixme:msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" fixme:msi:deformat_component component key L"HTM_Editor_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"HTM_Editor_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"Core_IDE_Resource_DLLs_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"Core_IDE_Resource_DLLs_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"Core_IDE_Cmd_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"Core_IDE_Cmd_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"VS_SCC_Core_TeamCore_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"VS_SCC_Core_TeamCore_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"CSS_Package_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"CSS_Package_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"_VS_Debugging_SDM2_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"_VS_Debugging_SDM2_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"_VS_Debugging_VSDebug_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"_VS_Debugging_VSDebug_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"WbBrwsrPckgRsrcDLLDEUX86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"WbBrwsrPckgRsrcDLLDEUX86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"URL_Font_Color_Picker_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" fixme:msi:deformat_component component key L"URL_Font_Color_Picker_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8" err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\CSSPKGUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\CSSPKGUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\HTMEDUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\HTMEDUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\htmdlgsUI.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\htmdlgsUI.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\vsdebugui.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\vsdebugui.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\MSDBGUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\MSDBGUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\MSENVUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\MSENVUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\vsbrowseUI.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\vsbrowseUI.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\VisualStudioTeamCoreUI.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\VisualStudioTeamCoreUI.dll") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\CMDDEFUI.DLL") err:msi:deformat_file Unable to get ShortPath size (L"c:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\CMDDEFUI.DLL") err:msi:ITERATE_Actions Execution halted, action L"SKURED" returned 1603 err:msi:ITERATE_Actions Execution halted, action L"ExecuteAction" returned 1603 fixme:msi:msi_dialog_set_control_condition Unhandled action L"Default" fixme:msi:msi_dialog_set_control_condition Unhandled action L"Default"

10 14

Re: winex11.drv: cleanup better in X11DRV_WineGL_InitOpenglInfo
by Jesse Allen 16 Sep '06

16 Sep '06

On 9/14/06, Phil Costin <philcostin(a)hotmail.com> wrote: > This patch fixes many games for me, what is the reason it was not applied? > > Regards > Phil Costin > > I don't know myself either. I was just going to wait. I want to add a little more to say about it. It's funny that the patch was only meant to affect the opengl/wgl code and the crashing apps are all d3d ones. However winex11 will now change the context on it's own when doing the opengl query and not set it back. What I noticed a couple weeks ago and now is that winex11 does usually gets inited twice, therefore it will change the current context twice. One at the start of the program, and another later on -- maybe on creation of a window or something. By that time wined3d is probably inited too, and making glXMakeCurrent calls too since it's based on opengl. So perhaps winex11 is causing wined3d to trip up at some point by changing the context. So if InitOpenglInfo just sets things back, then wined3d won't go boom. >From comments in wined3d, I can tell there isn't any "context manager". So what wined3d does at most is very simple management of contextes. We probably need a manager to coordinate things like this better between the two libraries. But that will likely be a bigger patch and to do so... I don't know, we need a fix for all the broken d3d apps now. Jesse

2 1

Re: X11DRV: fix fbconfig regression
by Roderick Colenbrander 16 Sep '06

16 Sep '06

Ati doesn't advertise GLX_SGIX_fbconfig. They only advertise a GLX client version of 1.3. Because the Xserver only supports 1.2, the reported version is also 1.2 (only the client version number is 1.3, the rest not). Roderick > Roderick Colenbrander wrote: > > The issue is that ATI's drivers don't advertise GLX_SGIX_fbconfig (which > really all opengl drivers do) but on the other hand they advertise GLX > client version 1.3 which promoted GLX_SGIX_fbconfig to core functionality. So > ATI doesn't advertise GLX_SGIX_fbconfig but it is available because their > libs are 1.3. They only ship the 1.3 functions so not the SGIX ones. > > > > So, ATI correctly advertises what they support, I don't see any reason > to have workarounds there. > > tom -- "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

1 0

configure error
by Tijl Coosemans 16 Sep '06

16 Sep '06

I get the following error running configure on FreeBSD: config.status: creating Makefile sed: 14: ./confstathEGAkR/subs-4.sed: unescaped newline inside substitute pattern There's one of those for every Makefile. The problem is with the following lines in configure.ac where I had to add '\\' to every line to work around the problem. Is this a FreeBSD only thing? AC_SUBST(DEPENDENCIES,"### Dependencies:\\ \\ .INIT: Makefile\\ .BEGIN: Makefile\\ Makefile: dummy\\ -\$(MAKEDEP) -C\$(SRCDIR) -S\$(TOPSRCDIR) -T\$(TOPOBJDIR) \$(EXTRAINCL) \$(DEPEND_SRCS)\\ \\ \$(ALL_OBJS): \$(IDL_SRCS:.idl=.h)\\ \$(LEX_SRCS:.l=.yy.o): \$(LEX_SRCS:.l=.yy.c)\\ \$(BISON_SRCS:.y=.tab.o): \$(BISON_SRCS:.y=.tab.c)")

2 1

Re: X11DRV: fix fbconfig regression
by Roderick Colenbrander 16 Sep '06

16 Sep '06

> Roderick Colenbrander wrote: > > There's this check: > > if ((!WineGLInfo.glxDirect && !strcmp("1.2", > WineGLInfo.glxServerVersion)) || > > (WineGLInfo.glxDirect && !strcmp("1.2", > WineGLInfo.glxClientVersion))) > > > This is not the correct way of loading opengl functions or deciding > whether they are available or not. According to the > GLX_ARB_get_proc_address spec, we need to check _only_ > glXQueryExtensionsString() and glXQueryVersion() and it's not correct to > make assumptions based on server/client versions or extension strings. > > This patch removes all the client/server code and replaces it with the > correct checks. The patch fixes the code in has_opengl() (and also > replaces one wine_dlsym() with pglXGetProcAddressARB()) as well as the > helper function glxRequireExtension() and fixes the code that decices > whether pbuffers are available. Pbuffers are part of GLX 1.3, so if the > GLX version is 1.3 we _have_ pbuffers, no need to check for the > GLX_SGIX_pbuffers extension anymore (&& -> ||) > > If this patch works with ATI drivers, I don't know, but that's certainly > the correct way of querying functions. I'm aware of the GLX version / extension issues. The check is more or less a workaround for buggy drivers like ATI's :( I'm against workarounds but in this case without it, there won't be any OpenGL support on ATI's drivers as GLX_SGIX_fbconfig is a requirement for wine. (I have submitted a bugreport) BTW I had the same stuff in opengl32. The issue is that ATI's drivers don't advertise GLX_SGIX_fbconfig (which really all opengl drivers do) but on the other hand they advertise GLX client version 1.3 which promoted GLX_SGIX_fbconfig to core functionality. So ATI doesn't advertise GLX_SGIX_fbconfig but it is available because their libs are 1.3. They only ship the 1.3 functions so not the SGIX ones. When direct rendering is enabled we look at the GLX client version :( This only works for fbconfig stuff and not for other things like pbuffers (it does work on ATI cards but not on Mesa). I hope this clears it up, Roderick -- "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

1 0

Re: Already Error while installing MS Office 2003
by jimtabor 16 Sep '06

16 Sep '06

Hi! > Hello > > >Codeweavers version of Wine has changes that Alexandre deems > >unacceptable for the "clean" WineHQ tree. > > If this is that way, it would be real a horror. Why are code patches > which allows a huge major app (key application) to run on linux > "unacceptable" (From point of view of the MS users). Do we here make > trench warfares? Or are there quality conceivabilities which are > completely unrealistic? Shouldn't we not see the major goal of wine? > To run windows apps on linux? Not to have a few lines code a bit > better quality etc. I think we don't have the choice to reject code. > Be very very thankful for each line which is checked in!! I think some > responsible persons are to deep in the code. They are looking just > into the code but can't see the benefit of the code for the wine > project itself. Why don't just accept the code? There is enough time > later to make it more "beautiful" or correct it to a better quality. > But for the moment, some of the code directly allows important apps to > work. > > Roland > > > I checked the Codeweavers version of Wine, there are a lot of "Codeweaver "HACK HACK HACK" Alerts" everywhere in key dlls. I compared it with 0.9.16 since the Codeweavers wine VERSION stated it. Amazing! James > >----- Ursprüngliche Mail ---- > >Von: Jim White <jim(a)pagesmiths.com> > >An: Roland Kaeser <roli8200(a)yahoo.de> > >CC: wine-devel(a)winehq.com > >Gesendet: Freitag, den 15. September 2006, 19:41:45 Uhr > >Betreff: Re: Already Error while installing MS Office 2003 > > > >Roland Kaeser wrote: > > > >> Just tried to test install office 2003 on wine 0.9.21. But getting > >> already errors. I read in C't (german it magazine) that office 2003 > >> works on codeweavers. Can somebody declare me this? Does codeweavers > >> voluntary not provide the corrections to wine to sell their product? > >> Looks very strange to me. > >> ... > > > >Codeweavers version of Wine has changes that Alexandre deems > >unacceptable for the "clean" WineHQ tree. > > > >The Codeweavers Wine source is here: > > > >http://www.codeweavers.com/products/source/ > > > >Jim > > >------------------------------------------------------------------------ >

1 0

[OT] Wine reveals bug in Microsoft Installer
by Segin 16 Sep '06

16 Sep '06

I was recently just feeding random crap to Wine, in an attempt to "stress-test" Wine, for a lack of better words. I fed it the Microsoft Platform SDK Installer, and it revealed a bug in the program, probably related to translation. Image URI: http://segin.no-ip.org/wtf.png -- The real problem with C++ for kernel modules is: the language just sucks. -- Linus Torvalds

1 0

Re: X11DRV: fix fbconfig regression
by Tomas carnecky 16 Sep '06

16 Sep '06

Roderick Colenbrander wrote: > There's this check: > if ((!WineGLInfo.glxDirect && !strcmp("1.2", WineGLInfo.glxServerVersion)) || > (WineGLInfo.glxDirect && !strcmp("1.2", WineGLInfo.glxClientVersion))) This is not the correct way of loading opengl functions or deciding whether they are available or not. According to the GLX_ARB_get_proc_address spec, we need to check _only_ glXQueryExtensionsString() and glXQueryVersion() and it's not correct to make assumptions based on server/client versions or extension strings. This patch removes all the client/server code and replaces it with the correct checks. The patch fixes the code in has_opengl() (and also replaces one wine_dlsym() with pglXGetProcAddressARB()) as well as the helper function glxRequireExtension() and fixes the code that decices whether pbuffers are available. Pbuffers are part of GLX 1.3, so if the GLX version is 1.3 we _have_ pbuffers, no need to check for the GLX_SGIX_pbuffers extension anymore (&& -> ||) If this patch works with ATI drivers, I don't know, but that's certainly the correct way of querying functions. tom

2 1

Note and patch about strange UDP packets
by Florian Echtler 15 Sep '06

15 Sep '06

Hi everybody, we are using a certain tracking software from Advanced Realtime Tracking. This is a windows software, but we decided yesterday that it would be more flexible to be able to use it under Linux, too, so I gave it a try with Wine. As this software communicates with customized (expensive) cameras via UDP, I noted a strange bug in the Wine debug channel "winsock": the software was sending UDP packets to IP _254_.255.255.255 (note the first octet). After some experimentation, I noticed that while Windows just sends this as a broadcast packet, Linux rejects this address, because the corresponding RFC states that the network 240.0.0.0/4 is reserved and should not be used. I therefore build a small patch which checks for these strange adresses and replaces them by broadcast adresses. This enabled our software to work. However, the question now is whether it makes sense to include this patch into Wine? On the one hand, it increases the similarity between Wine's behaviour and Windows's, OTOH it decreases Wine's RFC compliance.. Comments? Thanks, Yours, Florian

2 1