September 2006 - Wine-devel

Re: *RESEND* wininet: Make CheckInternetConnection behave like Windows does
by Hans Leidekker 14 Sep '06

14 Sep '06

On Thursday 14 September 2006 14:07, Daniel Skorka wrote: > The function CheckInternetConnection in dlls/wininet/internet.c is too > naive ATM; it just sends a ping to the specified host. Like Mike McCormack suggested in the bug report, UNIX connect() does not deal with a proxy. It would be nice if you could confirm that CheckInternetConnection on Windows ignores a configured proxy, especially since you seem to have access to such a configuration. -Hans

2 1

Re: usp10: Match output of WinXP for ScriptGetProperties.
by Jeff Latimer 14 Sep '06

14 Sep '06

Hans Leidekker wrote: > -Hans > >Changelog > Match output of WinXP for ScriptGetProperties. > Add a test for ScriptGetProperties. > > >------------------------------------------------------------------------ > >+static const SCRIPT_PROPERTIES script_0 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; >+static const SCRIPT_PROPERTIES script_1 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; >+static const SCRIPT_PROPERTIES script_2 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; > > >------------------------------------------------------------------------ > > > > Hans, what is the status of this patch? Looks pretty comprehensive but is unapplied. Are you going pursue it? Jeff

2 1

Re: configure.ac: Do not pass "-fPIC" to mingw for "make crosstest"
by Detlef Riekenberg 14 Sep '06

14 Sep '06

On Mi, 2006-09-13 at 15:23 +0200, Detlef Riekenberg wrote: > When we do a "make crosstest" with mingw32msvc-gcc, > the compiler give a warning about "-fPIC" > > > Changelog: > - configure.ac: Do not pass "-fPIC" to mingw for "make crosstest" > > > Changes for configure are not included. > I crosscompiled the tests, dlls and programs and it still works. > Please ignoge this patch. There are more gcc-only flags, that we use without checking -- By by ... Detlef

1 0

MSI : GetInstallDriver, Can not find InstallDriver in ROT table, Return Code = 0x800401e3
by wino＠piments.com 14 Sep '06

14 Sep '06

Hi, I have a refractory (faulty ?) MSI to deal with . I ran an msi based installer for autosketch today and it all went very well. Thanks for the current progress on MSI. Greatly cheered by this news I returned to one that I have never got to work since trying with 0.9.8 . I always thought it was wine that was not up to speed but it seems there some less than sorted versions of installsheild which give problems on some machines. In fact it may well be ALL Installsheild from v6 to v9. Only the lastest is fixed. I get the following the log file from msi: The InstallScript engine version currently installed on this machine is adequate. Event 'E2716761' is created GetInstallDriver, Can not find InstallDriver in ROT table, Return Code = 0x800401e3 {DDDD0C4B-57F7-4A85-ACF0-DB3FC8F1DBB4} Extract supporting files Failed to extract _IsUser.dll, Ignore it. Failed to extract IGdi.dll, Ignore it. ISMsiServerStartup Failure, Failed to RegisterMsiServer, Error = 0x8000ffff MsiServerStartup failed. Abort installation. Shutting down the PRC server... RPC runtime reported exception 0x6ba Googling parts of that soon shows a known issue , even on windows: http://forums1.itrc.hp.com/service/forums/questionanswer.do?threadId=993353… http://support.installshield.com/kb/view.asp?articleid=Q107249 http://support.installshield.com/kb/view.asp?articleid=Q107182 and specifically : http://www.voicerecognition.com/forums/ubb/Forum1/HTML/002282-2.html symtomatically , when it gets to the stage of copying the files to $TEMP , it seems to create a few zero length files only before failing. So the bug is in InstallSheild but it does not affect all machines. This version _usually_ installs correctly , what remains to be found out is why Wine falls into the broken category and how to work around it. Since I see this is was one area marked in 0.9.21 changelog I thought this may be a good time to bring it to your attention. best regards.

1 0

Re: cabinet: Add breaks to switch statements
by Dan Kegel 13 Sep '06

13 Sep '06

On 9/13/06, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > On Wednesday 13 September 2006 04:22, you wrote: > > Does adding the breaks fix conformance tests? > > No, I haven't fixed anything with this patch: it was a neutral one, in that > respect. I just put it in because I perceived that those switch statements > were not relying on any fallthrough, so I thought it good practice to isolate > the cases. Let's see: your change was --- a/dlls/cabinet/fci.c 2006-09-12 11:55:48.000000000 +0100 +++ b/dlls/cabinet/fci.c 2006-09-12 23:29:02.000000000 +0100 @@ -454,11 +454,12 @@ switch (cb % 4) { case 3: ul |= (((ULONG)(*pb++)) << 16); + break; case 2: ul |= (((ULONG)(*pb++)) << 8); + break; case 1: ul |= *pb++; - default: break; } Offhand that looks like a more serious change than you thought. You'd better either really understand the code, or add a conformance test that shows this fixes a bug, IMHO. - Dan

3 2

Low-level coding
by Aaron Slunt 13 Sep '06

13 Sep '06

Hi, I was interested in starting to play with wine and maybe even build a few functions for it...but then I realized that it's low-level coding, something I'm not familiar with (higher level is more of my expertise). Correct me if I'm wrong, I could be looking at the wrong files :S. Does anyone have any good places to go to to learn about low-level coding, and afterwards coding for wine specifically? Thanks. -- Tired of being hammered by spyware, or want to browse the internet in a whole new way? Download Firefox and enjoy a much better internet experience. http://getfirefox.com/

7 8

Re: cabinet: Add breaks to switch statements
by H. Verbeet 13 Sep '06

13 Sep '06

On 13/09/06, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > Changelog: > cabinet: Add breaks to switch statements. > > diff -urN a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c > --- a/dlls/cabinet/fci.c 2006-09-12 11:55:48.000000000 +0100 > +++ b/dlls/cabinet/fci.c 2006-09-12 23:29:02.000000000 +0100 > @@ -454,11 +454,12 @@ > switch (cb % 4) { > case 3: > ul |= (((ULONG)(*pb++)) << 16); > + break; > case 2: > ul |= (((ULONG)(*pb++)) << 8); > + break; > case 1: > ul |= *pb++; > - default: > break; > } > csum ^= ul; > diff -urN a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c > --- a/dlls/cabinet/fdi.c 2006-05-23 13:47:35.000000000 +0100 > +++ b/dlls/cabinet/fdi.c 2006-09-12 23:29:13.000000000 +0100 > @@ -302,9 +302,15 @@ > } > > switch (bytes & 3) { > - case 3: ul |= *data++ << 16; > - case 2: ul |= *data++ << 8; > - case 1: ul |= *data; > + case 3: > + ul |= *data++ << 16; > + break; > + case 2: > + ul |= *data++ << 8; > + break; > + case 1: > + ul |= *data; > + break; > } > csum ^= ul; > I think that's supposed to fall through.

1 0

RTL language support in usp.dll
by Vijay Kiran Kamuju 13 Sep '06

13 Sep '06

Hi, Your patch for RTL support in usp10.dll. http://www.winehq.org/pipermail/wine-patches/2006-September/030571.html Only includes support for Arabic. If you could include for other RTL languages esp Hebrew (other RTL languages are Farsi and Urdu). I think that would be an easy task for you as you know the usp internals. ;) bye, VJ

2 1

Find out which handle corresponds to which window
by David Gümbel 13 Sep '06

13 Sep '06

Hi, - I'm almost sure that question has been asked here before, but I can't seem to find the corresponding post: I am trying to debug an application (Net Support Manager) that has trouble displaying a window in fullscreen mode. NSM enables you (among other things) to remotely look onto somebody else's Desktop, a bit like VNC or NX. It's quite annoying not to be able to look onto that remote desktop in fullscreen mode. Anyway, my guess is that it tries to put itself on top of everything in a wierd way that does not work properly under wine. In order to verify or falsify my guess, it would be extremely helpful to find out which handle corresponds to the window showing the symtoms. I've tried my luck with Process Explorer, but that tool doesn't show me the information I need. Any help is greatly appreciated. Cheers, David

2 4

Re: resend: tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory
by Alexandre Julliard 13 Sep '06

13 Sep '06

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > When creating the wineprefix, create a directory for the menu and a > configuration file that enables this menu in the freedesktop.org menu > structure. As suggested on wine-devel the menu directory is a > subdirectory of ~/.wine, so if the user deletes it, all menu items > created there will be automatically removed. > > Is there something wrong with this patch? That sort of desktop-specific code does not belong in wineprefixcreate. I'm not really convinced that this approach to menus is correct, but even if it is, it should be handled by wineshelllink and friends. -- Alexandre Julliard julliard(a)winehq.org

1 0