October 2007 - Wine-devel - list.winehq.org

Re: "typos" on some include files
by Dmitry Timoshkov 24 Oct '07

24 Oct '07

"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > $ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def > --- liboleaut32.def 2007-08-23 16:15:48.000000000 +0200 > +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.000000000 +0200 > @@ -366,7 +366,6 @@ EXPORTS > OleCreatePictureIndirect(a)16 @419 > OleCreateFontIndirect(a)12 @420 > OleTranslateColor(a)12 @421 > - OleLoadPictureFile(a)12 @422 > OleLoadPicturePath(a)24 @424 > VarUI4FromI8(a)12 @425 > VarUI4FromUI8(a)12 @426 Also you can't just add an entry to the .def file, it's auto generated. You have to add a stub to the source file, and change the 'stub' entry in the .spec file. -- Dmitry.

2 4

Re: "typos" on some include files
by Dmitry Timoshkov 24 Oct '07

24 Oct '07

"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > Attached is the "patch" file (diff -up) regarding the bug: > > http://bugs.winehq.org/show_bug.cgi?format=multiple&id=10156 The patch is reversed, please change the source/dest, rediff and resend. -- Dmitry.

2 1

Re: dlls/rpcrt4/rpc_server.c initiale variable
by Robert Shearman 24 Oct '07

24 Oct '07

Gerald Pfeifer wrote: > It seems there are some code paths (in the error case?) which may > leave this unitialized. At least the compiler thinks so, and I > could not convince myself otherwise reading this code for a while. > It's a false positive, probably coming from the compiler not picking up that it is set when the exception variable is false and that when exception is true it is set earlier in the function. > - RpcPktHdr *response; > + RpcPktHdr *response = 0; > > If you're going to change the code at all, then at least keep to the coding convention used in the rest of the function and use NULL here. -- Rob Shearman

2 1

Re: oleaut32 [2/2]: Use widl to generate oaidl_p.c
by Alexandre Julliard 24 Oct '07

24 Oct '07

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This patch sets up the oleaut32 Makefile and shuffles some files > around so we can use widl to generate oaidl_p.c. The patch is *very* > large since it contains a diff for all of oaidl_p.c (which was > removed), and also two for oaidl.idl (which was moved). That's ugly, we need to make this work without having to rename the public headers. -- Alexandre Julliard julliard(a)winehq.org

1 0

windows on solaris
by S E 24 Oct '07

24 Oct '07

Hi , I have an executable that resides and compiled on windows 2003 server, I want to approach from my UNIX Solaris machine and run the executable. If anyone knows how to do that, or what can I use to run that I will be very happy. Thanks, SE

1 0

wineconf photos
by Steven Edwards 23 Oct '07

23 Oct '07

Hi, I was not lucky enough to have my digital camara with me during Wineconf, so if you've got photos uploaded somewhere please post urls or better yet add them to the Wiki. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: start:start.c Display messages in the console encoding.
by Dmitry Timoshkov 23 Oct '07

23 Oct '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > static void output(const char *message) > { > - DWORD count; > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); > + DWORD count = 0; > + WCHAR *mesW = NULL; > + char *mes = NULL; > + int wlen = 0; > + int len = 0; There is no need to initialize variables to 0 since you are going to explicitly initialize them later anyway. > + wlen = MultiByteToWideChar( CP_ACP, 0, message, -1, NULL, 0 ); > + mesW = HeapAlloc( GetProcessHeap(), 0, wlen * sizeof(WCHAR) ); > + mes = HeapAlloc( GetProcessHeap(), 0, wlen * sizeof(char) ); Allocating wlen chars for 'mes' won't work correctly on a multibyte locale. > + MultiByteToWideChar( CP_ACP, 0, message, -1, mesW, wlen ); > + len = WideCharToMultiByte( GetConsoleOutputCP(), 0, mesW, wlen, NULL, 0, NULL, NULL ); Just move the call to allocate 'len' bytes for 'mes' here. > + WideCharToMultiByte( GetConsoleOutputCP(), 0, mesW, wlen, mes, len, NULL, NULL ); -- Dmitry.

1 0

rpc: (resend) Add missing headers
by Roy Shea 23 Oct '07

23 Oct '07

Hello, Attached is a corrected version of this patch. I thank Mikolaj who brought to my attention the fact that rpcproxy.h is the incorrect location to include the files I added in the earlier patch. This revised patch adds the includes directly to rpc.h. The Windows version of rpc.h accesses these includes throuh windows.h. Peace, -Roy On Tue, Oct 23, 2007 at 09:50:25AM -0700, Roy Shea wrote: > Howdy, > > The REGISTER_PROXY_DLL_ROUTINES macro defined in rpcproxy.h calls > DisableThreadLibraryCalls. This patch adds two header files needed > for calls to DisableThreadLibraryCalls. > > Peace, > -Roy >

1 0

Re: [PATCH 3/3] configure: Use 0 instead of NULL because NULL isn't defined.
by Stefan Dösinger 23 Oct '07

23 Oct '07

Am Freitag, 19. Oktober 2007 23:18:51 schrieb Ken Thomases: > This makes the test test the proper thing on Mac OS X. It still fails, but > for a good reason. > --- > configure.ac | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > - char *name=NULL; > + char *name=0; Shouldn't that be (void *) 0 or (char *) 0?

6 7

Re: widl [3/4]: Remove printf format strings that aren't really format strings.
by Michael Stefaniuc 23 Oct '07

23 Oct '07

Dan Hipschman wrote: > This is just a minor cleanup patch. Even if we're definitely sure a > string doesn't contain any % signs, it's still better not to use it as a > printf format string. fputs() would be a faster alternative to that. Though i doubt that matters in this case. bye michael > --- > tools/widl/typegen.c | 4 ++-- > tools/widl/widl.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index bf24d3f..53ec78c 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -2501,7 +2501,7 @@ void print_phase_basetype(FILE *file, int indent, enum remoting_phase phase, > fprintf(file, " *)_StubMsg.Buffer = *"); > else > fprintf(file, " *)_StubMsg.Buffer = "); > - fprintf(file, varname); > + fprintf(file, "%s", varname); > fprintf(file, ";\n"); > } > else if (phase == PHASE_UNMARSHAL) > @@ -2510,7 +2510,7 @@ void print_phase_basetype(FILE *file, int indent, enum remoting_phase phase, > print_file(file, indent, ""); > else > print_file(file, indent, "*"); > - fprintf(file, varname); > + fprintf(file, "%s", varname); > if (pass == PASS_IN && is_ptr(type)) > fprintf(file, " = ("); > else > diff --git a/tools/widl/widl.c b/tools/widl/widl.c > index 53c9e29..37f1a5e 100644 > --- a/tools/widl/widl.c > +++ b/tools/widl/widl.c > @@ -422,13 +422,13 @@ int main(int argc,char *argv[]) > idfile_name = xstrdup(optarg); > break; > case 'V': > - printf(version_string); > + printf("%s", version_string); > return 0; > case 'W': > pedantic = 1; > break; > default: > - fprintf(stderr, usage); > + fprintf(stderr, "%s", usage); > return 1; > } > } > @@ -458,7 +458,7 @@ int main(int argc,char *argv[]) > input_name = xstrdup(argv[optind]); > } > else { > - fprintf(stderr, usage); > + fprintf(stderr, "%s", usage); > return 1; > } > > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

3 3