October 2007 - Wine-devel - list.winehq.org

SHChangeNotify()
by Francois Gouget 28 Oct '07

28 Oct '07

shlwapi.spec exports SHChangeNotify. However I see no implementation of this function in shlwapi. There is an SHChangeNotifyWrap() function however. Weirder still, SHChangeNotifyWrap() does not seem to be called anywhere, is not exported by shlwapi.spec, and calls SHChangeNotify(). So I'm confused as to how this is supposed to work. Could you clarify things for me? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

1 0

ddraw:d3d tests failing consistently
by Reece Dunn 27 Oct '07

27 Oct '07

Hi, Looking at the ddraw:d3d tests, they are failing consistently on many Windows platforms: d3d.c:1039: Test failed: IDirect3DViewport_SetViewport returned 80070057 d3d.c:1050: Test failed: Vertex 2 differs. Got 129.000000 127.000000 1.000000 1.000000, expexted 133.000000 123.000000 1.000000 1.000000 d3d.c:1050: Test failed: Vertex 3 differs. Got 127.000000 129.000000 -1.000000 1.000000, expexted 123.000000 133.000000 -1.000000 1.000000 d3d.c:1050: Test failed: Vertex 4 differs. Got 128.500000 127.500000 0.500000 1.000000, expexted 130.500000 125.500000 0.500000 1.000000 d3d.c:1050: Test failed: Vertex 5 differs. Got 127.500000 128.500000 -0.500000 1.000000, expexted 125.500000 130.500000 -0.500000 1.000000 d3d.c:1050: Test failed: Vertex 6 differs. Got 127.500000 128.500000 0.000000 1.000000, expexted 125.500000 130.500000 0.000000 1.000000 d3d.c:1060: Test failed: IDirect3DViewport_SetViewport returned 80070057 d3d.c:1071: Test failed: Vertex 1 differs. Got 128.000000 128.000000 0.000000 1.000000, expexted 138.000000 148.000000 0.000000 1.000000 d3d.c:1071: Test failed: Vertex 2 differs. Got 129.000000 127.000000 1.000000 1.000000, expexted 143.000000 143.000000 1.000000 1.000000 d3d.c:1071: Test failed: Vertex 3 differs. Got 127.000000 129.000000 -1.000000 1.000000, expexted 133.000000 153.000000 -1.000000 1.000000 d3d.c:1071: Test failed: Vertex 4 differs. Got 128.500000 127.500000 0.500000 1.000000, expexted 140.500000 145.500000 0.500000 1.000000 d3d.c:1071: Test failed: Vertex 5 differs. Got 127.500000 128.500000 -0.500000 1.000000, expexted 135.500000 150.500000 -0.500000 1.000000 d3d.c:1071: Test failed: Vertex 6 differs. Got 127.500000 128.500000 0.000000 1.000000, expexted 135.500000 150.500000 0.000000 1.000000 d3d.c:1134: Test failed: Cliptest 3 differs. Got 00000020 expexted 00000026 d3d.c:1134: Test failed: Cliptest 4 differs. Got 00000010 expexted 00000019 d3d.c:1143: Test failed: IDirect3DViewport_SetViewport returned 80070057 d3d.c:1157: Test failed: Cliptest 1 differs. Got 00000000 expexted 00000002 d3d.c:1157: Test failed: Cliptest 2 differs. Got 00000000 expexted 00000001 d3d.c:1157: Test failed: Cliptest 3 differs. Got 00000020 expexted 00000022 d3d.c:1157: Test failed: Cliptest 4 differs. Got 00000010 expexted 00000011 d3d.c:1166: Test failed: IDirect3DViewport_SetViewport returned 80070057 d3d.c:1195: Test failed: IDirect3DViewport_SetViewport returned 80070057 d3d.c:1206: Test failed: Offscreen is 0 d3d.c:1217: Test failed: Offscreen is 0 d3d.c:1231: Test failed: Offscreen is 2 Does anyone know if this is a change in ddraw:d3d behaviour on Windows between versions/graphics drivers or has this test always failed? - Reece

5 17

MENU_TrackMenu trouble
by nicholai＠t-online.de 27 Oct '07

27 Oct '07

Hello, I'm struggling to make recent Chessbase applications such as Fritz 9 and 10 work with wine. A free download which shows the same symptoms described below is available here: http://fritzserver.org/download/CBLightEnglishSetup.exe I have tried to look into this and this is what I've found: The application uses TrackPopupMenuEx() (user32/menu.c) which in wine is just a call to TrackPopupMenu(). The latter function calls MENU_TrackMenu() and that's where things seem to go wrong. In the loop going through the message queue the application will crash (see output below) whenever the following message is sent: SendMessageW( mt.hOwnerWnd, WM_ENTERIDLE, MSGF_MENU, (LPARAM)win ); If I uncomment that line, the application will stay alive but I will obviously experience weird menu behaviour. I'm stuck trying to find out what the problem is and would really appreciate any help on how to proceed with this Thanks and best regards, Nicholai ------------------------------------------------------------------------------------------------------------------------------- wine: Unhandled page fault on read access to 0x00000020 at address 0x15a60c5 (thread 03da), starting debugger... Unhandled exception: page fault on read access to 0x00000020 in 32-bit code (0x015a60c5). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:015a60c5 ESP:0034ea64 EBP:0034eb10 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:00000000 ECX:0272e930 EDX:782ba9e0 ESI:015a60c0 EDI:0272e930 Stack dump: 0x0034ea64: 015a60c0 782021cb 00000002 00000000 0x0034ea74: 62a7f85f 00000121 0272e930 00138218 0x0034ea84: 00000000 00000000 015cfe20 782bafa4 0x0034ea94: 7fffffff 7bc3f3de 00000000 00000000 0x0034eaa4: 00000090 7bc326a1 00000000 00000010 0x0034eab4: 0034eb04 7bc40bff 00110014 7bc8443c Backtrace: =>1 0x015a60c5 in sviewnet (+0x760c5) (0x0034eb10) 2 0x78201ca1 in mfc80 (+0x31ca1) (0x0034eb30) 3 0x78200a43 in mfc80 (+0x30a43) (0x0034eb98) 4 0x78200c53 in mfc80 (+0x30c53) (0x0034ebbc) 5 0x781fedad in mfc80 (+0x2edad) (0x0034ec04) 6 0x7ed63b8a WINPROC_wrapper+0x1a() in user32 (0x0034ec34) 7 0x7ed6429e in user32 (+0xa429e) (0x0034ec74) 8 0x7ed685db in user32 (+0xa85db) (0x0034f144) 9 0x7ed69a0b WINPROC_call_window+0x15b() in user32 (0x0034f184) 10 0x7ed3036c in user32 (+0x7036c) (0x0034f1f4) 11 0x7ed340a2 in user32 (+0x740a2) (0x0034f254) 12 0x7ed3451a SendMessageW+0x4a() in user32 (0x0034f294) 13 0x7ed2d327 in user32 (+0x6d327) (0x0034f354) 14 0x7ed2e0af TrackPopupMenu+0x11f() in user32 (0x0034f394) 15 0x7ed2e14e TrackPopupMenuEx+0x5e() in user32 (0x0034f3c4) 16 0x015a757a in sviewnet (+0x7757a) (0x000005f0) 17 0x00000000 (0x00000000)

1 0

wine tests question?
by Vijay Kiran Kamuju 27 Oct '07

27 Oct '07

Hi, I have been looking into http://test.winehq.org/data/. And I have got a question, when i saw the test data. Why do some tests do not return the data about tests they haven't run/skipped. They spew messages something like below: mapi32:prop start dlls/mapi32/tests/prop.c 1.20 mapi32:prop done (-1073741819) mapi32:util start dlls/mapi32/tests/util.c 1.9 mapi32:util done (-1073741819) I am trying to figure out a reason so that i can fix this. can you guys help me out? thanks, VJ

2 2

What if heap errors caused 'make test' to fail?
by Dan Kegel 27 Oct '07

27 Oct '07

Let's just say, for grins, that we applied a patch that made heap corruption fatal under WINEDEBUG=warn+heap, e.g. --- a/dlls/ntdll/heap.c +++ b/dlls/ntdll/heap.c @@ -909,6 +909,7 @@ static BOOL HEAP_ValidateInUseArena( con WARN( "Heap %p: unaligned arena pointer %p\n", subheap->heap, pArena ); if ( TRACE_ON(heap) ) HEAP_Dump( subheap->heap ); + assert( FALSE ); } return FALSE; } @@ -924,6 +925,7 @@ static BOOL HEAP_ValidateInUseArena( con WARN("Heap %p: invalid in-use arena magic for %p\n", subheap->heap, pArena ); if (TRACE_ON(heap)) HEAP_Dump( subheap->heap ); + assert( FALSE ); } return FALSE; } How many tests would that break? Any guesses? Scroll down for the answer: 25! Here's the output of WINEDEBUG=warn+heap make -k test piped through grep make.*Error: make[2]: *** [alloc.ok] Error 134 make[2]: *** [pipe.ok] Error 1 make[2]: *** [systray.ok] Error 6 make[2]: *** [thread.ok] Error 9 make[2]: *** [security.ok] Error 1 make[1]: *** [advapi32/tests/__test__] Error 2 make[2]: *** [info.ok] Error 134 make[1]: *** [ntdll/tests/__test__] Error 2 make[2]: *** [heap.ok] Error 134 make[2]: *** [change.ok] Error 2 make[2]: *** [heap.ok] Error 5 make[2]: *** [util.ok] Error 134 make[1]: *** [msvcrt/tests/__test__] Error 2 make[1]: *** [snmpapi/tests/__test__] Error 2 make[2]: *** [apibuf.ok] Error 134 make[1]: *** [netapi32/tests/__test__] Error 2 make[2]: *** [device.ok] Error 4 make[1]: *** [d3d9/tests/__test__] Error 2 make[2]: *** [moniker.ok] Error 134 make[2]: *** [toolhelp.ok] Error 8 make[2]: *** [webbrowser.ok] Error 134 make[1]: *** [shdocvw/tests/__test__] Error 2 make[2]: *** [input.ok] Error 64 make[2]: *** [editor.ok] Error 5 make[1]: *** [riched20/tests/__test__] Error 2 make[2]: *** [mixer.ok] Error 10 make[2]: *** [msg.ok] Error 18 make[2]: *** [shellpath.ok] Error 3 make[2]: *** [class.ok] Error 2 make[2]: *** [comm.ok] Error 3 make[2]: *** [vartype.ok] Error 134 make[1]: *** [oleaut32/tests/__test__] Error 2 make[2]: *** [parser.ok] Error 134 make[1]: *** [setupapi/tests/__test__] Error 2 make[2]: *** [win.ok] Error 8 make[2]: *** [capture.ok] Error 134 make[1]: *** [dsound/tests/__test__] Error 2 make[2]: *** [htmldoc.ok] Error 134 make[2]: *** [timer.ok] Error 1 make[2]: *** [mci.ok] Error 134 make[1]: *** [mshtml/tests/__test__] Error 2 make[2]: *** [font.ok] Error 26 make[1]: *** [gdi32/tests/__test__] Error 2 make[1]: *** [kernel32/tests/__test__] Error 2 make[2]: *** [wave.ok] Error 8 make[1]: *** [winmm/tests/__test__] Error 2 make[2]: *** [server.ok] Error 4 make[1]: *** [rpcrt4/tests/__test__] Error 2 make[2]: *** [dde.ok] Error 5 make[1]: *** [user32/tests/__test__] Error 2 make[2]: *** [shlexec.ok] Error 35 make[1]: *** [shell32/tests/__test__] Error 2 make[1]: *** [ole32/tests/__test__] Error 2 I wonder if some of these tests are themselves buggy such that they pass on Wine by accident (without this patch) but fail on Windows? - Dan

4 5

wine needs a relatively new version of fontforge?
by Lei Zhang 27 Oct '07

27 Oct '07

Hi, Dan K. and I both ran into bug 10103 [1] because the fontforge on our systems is too old. I noticed some of the font tests failed on my system for the same reason. So what is the minimum version of fontforge that will generate correct fonts? Should we add a check for it? - Lei [1] http://bugs.winehq.org/show_bug.cgi?id=10103

1 0

Re: makefiles: add a notest target
by Maarten Lankhorst 26 Oct '07

26 Oct '07

Hi Lei, Lei Zhang schreef: > Hi, > > This patch adds a notest target to build everything but the dll unit > tests and winetest. This cuts down build time by 25%. > Julliard will never accept such patch. In the hacks.git tree there is a patch I did that has a configuration time option for it. It would be cleaner if you used something like 'make SKIPTESTS=1'. I doubt that alexandre would ever accept any patch that would disable building tests, though. Cheers, Maarten.

3 2

Re: user32: Fix a test that now passes in Windows
by Reece Dunn 26 Oct '07

26 Oct '07

On 25/10/2007, James Hawkins wrote: > Hi, > > Changelog: > * Fix a test that now passes in Windows. Looking at the code, it looks as if they are now passing in Wine :). > dlls/user32/tests/dde.c | 13 ++++++++++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > + str = (LPSTR)DdeAccessData(hdata, &size); > + ok(!lstrcmpA(str, "requested data\r\n"), "Expected 'requested data\\r\\n', got %s\n", str); Shouldn't there be quote marks around the %s (i.e. '%s', to match the expected value)? > + ok(size == 19, "Expected 19, got %d\n", size); > + > + ret = DdeUnaccessData(hdata); > + ok(ret == TRUE, "Expected TRUE, got %d\n", ret); These are new test cases. Since these are not fixes to existing test cases, they should really be in a separate patch. - Reece

3 3

my first patch
by viny 26 Oct '07

26 Oct '07

Can someone tell me if this patch is correct for submitting to wine-patches. I have generated this patch with "git format-patch -o out origin" (related bug : http://bugs.winehq.org/show_bug.cgi?id=9805) >From c5eab13b67e6f24b3518dd77840f260dc101520e Mon Sep 17 00:00:00 2001 From: Vincent Hardy <vincent.hardy.be(a)gmail.com> Date: Fri, 26 Oct 2007 13:37:39 +0200 Subject: [PATCH] Add TypeLib version for W2K, WXP, and Vista --- dlls/oleaut32/typelib16.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/dlls/oleaut32/typelib16.c b/dlls/oleaut32/typelib16.c index a010f7d..31bbf93 100644 --- a/dlls/oleaut32/typelib16.c +++ b/dlls/oleaut32/typelib16.c @@ -153,6 +153,9 @@ HRESULT WINAPI LoadTypeLib16( *| OLE 2.1 NT 1993-95 ?? ??? *| OLE 2.3.1 W95 23 700 *| OLE2 4.0 NT4SP6 1993-98 40 4277 + *| OLE 2.1 W2K 2000 10 3029 + *| OLE 2.1 WXP 2002 10 3029 + *| OLE 2.1 Vista 2007 10 3029 */ DWORD WINAPI OaBuildVersion16(void) { @@ -171,6 +174,12 @@ DWORD WINAPI OaBuildVersion16(void) return MAKELONG(3024, 10); /* W98 SE */ case 0x00000004: /* NT4 */ return MAKELONG(4277, 40); /* NT4 SP6 */ + case 0x00000005: /* W2K */ + return MAKELONG(3029, 10); /* W2K SP4 */ + case 0x00000105: /* WXP */ + return MAKELONG(3029, 10); /* WXP SP2 */ + case 0x00000006: /* Vista */ + return MAKELONG(3029, 10); /* Vista */ default: FIXME("Version value not known yet. Please investigate it!\n"); return 0; -- 1.5.2.5

3 2

Improving http://tests.winehq.org/data/
by Francois Gouget 26 Oct '07

26 Oct '07

Here are some things I noticed while using this site. Let me know if I it would help to make bug reports for these: * Some result entries are red with a dash in them and a blue border. See the Windows 98 results for http://test.winehq.org/data/200710241000/ I assume these means that the test did not load. However we should distinguish two cases there: - if it did not run because the tested dll did not exist at all, then it's not a test failure and thus the background should be green. A typical case would be the crypt32 tests on Windows 98. - if the dll was there but the test still did not run, typically because the dll is missing an export, then that's a bug in the test: it should dynamically load that function so the other checks it performs can be run. A typical case is the gdi32 tests on Windows 98. Ideally we'd even have a log showing the missing API but that's probably too tricky to do on Windows. * Downloading the log file for a given test run gives me a file that's called 'report'. It would be nice if it was called something like 'vmware-win98-report' instead so that saving a couple of them in a directory leads to fewer collisions. * It would be nice if the /data page looked more like a calendar with the most current date easily accessible, and a less like the directory listing it currently is. Then a / page would be nice too. I'm pretty unlikely to fix these, but at least here is a starting if someone is inclined to do so: you will find the source for the test.winehq.org website in the tools.git repository: http://source.winehq.org/git/tools.git/?a=tree;f=winetest To get hold of the sources, see the instructions there: http://www.winehq.org/site/git#modules -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

6 9