October 2007 - Wine-devel - list.winehq.org

Re: wininet: ftp test hangs behind firewall, so turn it off by default
by Alexandre Julliard 23 Oct '07

23 Oct '07

"Dan Kegel" <dank(a)kegel.com> writes: > This gets rid of one more place I have to do 'wineserver -k' to > make tests complete. I don't think it really hangs, it just takes a long time to complete. > It would be better to embed a little ftp server into the test, > and connect to that instead of a public one, but that would > be a pain. No, we clearly want to run the test against a real ftp server. Running it against different types of servers would be even better. What we should probably do is try to connect to a server on localhost first, this way people can install the server of their choice to provide more test coverage. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: msi: Propogate errors from events all the way up to the parent dialog
by Alexandre Julliard 23 Oct '07

23 Oct '07

"James Hawkins" <truiken(a)gmail.com> writes: > Fixes bug 10107. http://bugs.winehq.org/show_bug.cgi?id=10107 > > Changelog: > * Propogate errors from events all the way up to the parent dialog. This one fails for me: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so package.c && touch package.ok package.c:587: Test failed: wrong return val make: *** [package.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32 (2/2): fix unchecked NULL ptr in BIDI_Reorder
by Alexandre Julliard 23 Oct '07

23 Oct '07

Alexander Dorofeyev <alexd14(a)hushmail.com> writes: > 3rd try. In this version I don't create a temp buffer, instead pass the original > string to subroutines; in BidiLines an additional parameter had to be added, to > indicate that the original string has been passed and in-place modifications it > normally does on the buffer must be skipped. You should pass separate in and out pointers, since the input pointer is const you can't use it in place of the output one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] updated authors
by Dmitry Timoshkov 23 Oct '07

23 Oct '07

"Marcus Meissner" <meissner(a)suse.de> wrote: > --- > AUTHORS | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 136 insertions(+), 2 deletions(-) I've found more duplicates, sorry for the trouble. > +Veksler Michael This is a duplicate due to the reversed last/first names. > Zoltan Nagy > +Zoly Nagy The two names above look similar enough, but changelog doesn't provide enough information to distinguish them. > +Brouard Nicolas Again a duplicate due to the reversed last/first names. > +Tom Spear Not sure if have him already under an old name (can't remember which one). -- Dmitry.

3 2

Re: pdh: Remove or fix tests that fail on Windows.
by Hans Leidekker 23 Oct '07

23 Oct '07

On Monday 22 October 2007 14:43:59 Jeff Latimer wrote: > to test with and hence the delay. The current patch I submitted was > cleaning up the Null reference issue before moving on to sorting out the I don't see any crash on Wine or XP when running the test. You are trying to protect against a hypothetical case where an app specifies a size > 0 but no buffer. XP won't accept that anyway and it's unlikely any app will do that on non-XP systems. In fact your patch will break in another - also unlikely - situation where an app relies on non-XP behaviour, which is to accept a null buffer and size > 0 but less than the required size. So a crash is even desirable here, because it tells us immediately that the app is doing something peculiar. -Hans

2 1

iexplore text input
by Luke Bratch 23 Oct '07

23 Oct '07

Hi all As you probably know, text input in iexplore isn't working at the moment, and hasn't worked since this commmit: http://source.winehq.org/git/wine.git/?a=commit;h=92b3cab7916445d79d2559e4b… (Found by Simon in this bug: http://bugs.winehq.org/show_bug.cgi?id=9746) I've posted a patch in there: http://bugs.winehq.org/attachment.cgi?id=8647 That seems to make text input work be reversing part of that commit. As far as I can see that doesn't break anything else. Your thoughts? Thanks Luke ___________________________________________________________ Want ideas for reducing your carbon footprint? Visit Yahoo! For Good http://uk.promotions.yahoo.com/forgood/environment.html

2 1

Re: [PATCH] updated AUTHORS according to "git log"
by Dmitry Timoshkov 23 Oct '07

23 Oct '07

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: I briefly looked over the diff and found some duplicates, perhaps there are more of them: > Guy Albertelli > +Guy L. Albertelli This one is probably a duplicate. > +Turchanov Sergei And this one already exists as 'Sergey Turchanov'. > +NF Stevens > Norman Stevens According to the e-mail addresses the two above is a single person. > +Josh Thielen > Joshua Thielen And these two as well. > +Sergei Turchanov > Sergey Turchanov Again a duplicate. -- Dmitry.

1 0

urlmon: Fix the MIME type reported by the HTTP protocol when the Content-Type headers contains charset data too.
by Misha Koshelev 23 Oct '07

23 Oct '07

> Sorry to send this out after the patch has already been committed, but > this patch is wrong. If you just output the Content-Type in > test/protocol.c you'll see that the charset data is included in the > "MIME type" in both Windows XP and on wine with native urlmon (from > WinME or 98; I believe the XP one crashes wine or at least it used to). > That is why when I was fixing the original test I just changed it to a > memcmp from a strcmp. > Misha > Just checked on Win98, the behavior to keep the charset in the "MIME type" is correct on Win98 as well. Misha

1 0

urlmon: Fix the MIME type reported by the HTTP protocol when the Content-Type headers contains charset data too.
by Misha Koshelev 23 Oct '07

23 Oct '07

Sorry to send this out after the patch has already been committed, but this patch is wrong. If you just output the Content-Type in test/protocol.c you'll see that the charset data is included in the "MIME type" in both Windows XP and on wine with native urlmon (from WinME or 98; I believe the XP one crashes wine or at least it used to). That is why when I was fixing the original test I just changed it to a memcmp from a strcmp. Misha

1 0

Photoshop Elements 5 Tryout?
by Dan Kegel 22 Oct '07

22 Oct '07

Anyone have a URL for PSE 5 trial version? I'm updating http://wiki.winehq.org/AdobePhotoshop Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

7 15